Minor: Format code + fix psalm

pull/5649/head
Angel Fernando Quiroz Campos 1 year ago
parent f53d420b45
commit 80fd6c6497
No known key found for this signature in database
GPG Key ID: B284841AE3E562CD
  1. 3
      src/CoreBundle/Component/Utils/ChamiloApi.php
  2. 3
      src/CoreBundle/Form/PermissionType.php
  3. 2
      src/CoreBundle/Migrations/Schema/V200/Version20230215072918.php
  4. 9
      src/CoreBundle/Migrations/Schema/V200/Version20240713125400.php
  5. 4
      src/CoreBundle/Migrations/Schema/V200/Version20240715183456.php

@ -6,6 +6,7 @@ declare(strict_types=1);
namespace Chamilo\CoreBundle\Component\Utils;
use Chamilo\CoreBundle\Framework\Container;
use ChamiloSession as Session;
use Database;
use DateInterval;
@ -156,7 +157,7 @@ class ChamiloApi
): string {
$logoPath = Container::getThemeHelper()->getThemeAssetUrl('images/header-logo.svg');
if (empty($logo)) {
if (empty($logoPath)) {
$logoPath = Container::getThemeHelper()->getThemeAssetUrl('images/header-logo.png');
}

@ -11,6 +11,9 @@ use Symfony\Component\Form\Extension\Core\Type\CheckboxType;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;
/**
* @template-extends AbstractType<string>
*/
class PermissionType extends AbstractType
{
public function buildForm(FormBuilderInterface $builder, array $options): void

@ -50,7 +50,7 @@ final class Version20230215072918 extends AbstractMigrationChamilo
if (!empty($items)) {
foreach ($items as $item) {
if (!($item['to_user_id'] === NULL || $item['to_user_id'] === 0)) {
if (!(null === $item['to_user_id'] || 0 === $item['to_user_id'])) {
$sessionId = $item['session_id'] ?? 0;
$userId = $item['to_user_id'] ?? 0;
$session = $sessionRepo->find($sessionId);

@ -25,9 +25,9 @@ final class Version20240713125400 extends AbstractMigrationChamilo
foreach ($users as $user) {
$roles = unserialize($user['roles']);
if ($roles !== false) {
if (false !== $roles) {
$updatedRoles = array_map(function ($role) {
return $role === 'ROLE_RRHH' ? 'ROLE_HR' : $role;
return 'ROLE_RRHH' === $role ? 'ROLE_HR' : $role;
}, $roles);
$newRolesSerialized = serialize($updatedRoles);
@ -35,7 +35,6 @@ final class Version20240713125400 extends AbstractMigrationChamilo
'UPDATE user SET roles = ? WHERE id = ?',
[$newRolesSerialized, $user['id']]
);
}
}
}
@ -49,9 +48,9 @@ final class Version20240713125400 extends AbstractMigrationChamilo
foreach ($users as $user) {
$roles = unserialize($user['roles']);
if ($roles !== false) {
if (false !== $roles) {
$updatedRoles = array_map(function ($role) {
return $role === 'ROLE_HR' ? 'ROLE_RRHH' : $role;
return 'ROLE_HR' === $role ? 'ROLE_RRHH' : $role;
}, $roles);
$newRolesSerialized = serialize($updatedRoles);

@ -31,7 +31,5 @@ final class Version20240715183456 extends AbstractMigration
$this->addSql("DELETE FROM extra_field WHERE variable = 'special_course' AND item_type = $extraFieldType");
}
public function down(Schema $schema): void
{
}
public function down(Schema $schema): void {}
}

Loading…
Cancel
Save