From 88e6fdf967f155495f95f0cdd1ebf56b99472417 Mon Sep 17 00:00:00 2001
From: christianbeeznst <christian.fasanando@beeznest.com>
Date: Thu, 15 Aug 2024 01:11:10 -0500
Subject: [PATCH] Gradebook: Fix undefined user_id in Evaluation for edit -
 refs BT#21911

---
 public/main/gradebook/gradebook_edit_eval.php   | 3 ---
 public/main/gradebook/lib/fe/evalform.class.php | 2 +-
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/public/main/gradebook/gradebook_edit_eval.php b/public/main/gradebook/gradebook_edit_eval.php
index fc8b0849dc..bd67e8290d 100644
--- a/public/main/gradebook/gradebook_edit_eval.php
+++ b/public/main/gradebook/gradebook_edit_eval.php
@@ -39,9 +39,6 @@ if ($form->validate()) {
     $evaluation->setTitle($values['name']);
     $evaluation->setDescription($values['description']);
 
-    $user = $entityManager->getRepository(User::class)->find($values['hid_user_id']);
-    $evaluation->setUser($user);
-
     $course = $entityManager->getRepository(Course::class)->findOneBy(['code' => $values['hid_course_code']]);
     $evaluation->setCourse($course);
 
diff --git a/public/main/gradebook/lib/fe/evalform.class.php b/public/main/gradebook/lib/fe/evalform.class.php
index 18c3ad1c00..daf7c119c9 100644
--- a/public/main/gradebook/lib/fe/evalform.class.php
+++ b/public/main/gradebook/lib/fe/evalform.class.php
@@ -500,7 +500,7 @@ class EvalForm extends FormValidator
             'hid_id' => $this->evaluation_object->get_id(),
             'name' => $this->evaluation_object->get_name(),
             'description' => $this->evaluation_object->get_description(),
-            'hid_user_id' => $this->evaluation_object->get_user_id(),
+            'hid_user_id' => $evaluation_object->user_id ?? 0,
             'hid_course_code' => $this->evaluation_object->get_course_code(),
             'hid_course_id' => $this->evaluation_object->getCourseId(),
             'hid_category_id' => $this->evaluation_object->get_category_id(),