diff --git a/main/inc/lib/link.lib.php b/main/inc/lib/link.lib.php index 2563ae737c..2cd743d5ac 100755 --- a/main/inc/lib/link.lib.php +++ b/main/inc/lib/link.lib.php @@ -1,4 +1,5 @@ save($params); - if ((api_get_setting('search_enabled') == 'true') && + if ((api_get_setting('search_enabled') === 'true') && $link_id && extension_loaded('xapian') ) { require_once api_get_path(LIBRARY_PATH).'specific_fields_manager.lib.php'; @@ -325,7 +326,7 @@ class Link extends Model return $link_id; } - } elseif ($type == 'category') { + } elseif ($type === 'category') { $tbl_categories = Database::get_course_table(TABLE_LINK_CATEGORY); $category_title = trim($_POST['category_title']); @@ -500,7 +501,7 @@ class Link extends Model } $sql = "SELECT * FROM $tbl_link - WHERE c_id = $course_id AND id='".intval($id)."' "; + WHERE c_id = $course_id AND id='".(int) $id."' "; $result = Database::query($sql); $data = []; if (Database::num_rows($result)) { @@ -519,7 +520,7 @@ class Link extends Model $tbl_link = Database::get_course_table(TABLE_LINK); $_course = api_get_course_info(); $course_id = $_course['real_id']; - $id = intval($id); + $id = (int) $id; $values['url'] = trim($values['url']); $values['title'] = trim($values['title']); @@ -588,7 +589,7 @@ class Link extends Model ); // Update search enchine and its values table if enabled. - if (api_get_setting('search_enabled') == 'true') { + if (api_get_setting('search_enabled') === 'true') { $course_int_id = api_get_course_int_id(); $course_id = api_get_course_id(); $link_title = Database:: escape_string($values['title']); @@ -990,6 +991,7 @@ class Link extends Model $linksAdded = []; foreach ($links as $myrow) { $linkId = $myrow['id']; + $linkUrl = Security::remove_XSS($myrow['url']); if (in_array($linkId, $linksAdded)) { continue; @@ -999,10 +1001,7 @@ class Link extends Model $categoryId = $myrow['category_id']; // Validation when belongs to a session. - $session_img = api_get_session_image( - $myrow['link_session_id'], - $_user['status'] - ); + $session_img = api_get_session_image($myrow['link_session_id'], $_user['status']); $toolbar = ''; $link_validator = ''; @@ -1013,7 +1012,7 @@ class Link extends Model 'check-circle-o', 'default btn-sm', [ - 'onclick' => "check_url('".$linkId."', '".addslashes($myrow['url'])."');", + 'onclick' => "check_url('".$linkId."', '".addslashes($linkUrl)."');", 'title' => get_lang('CheckURL'), ] ); @@ -1136,7 +1135,7 @@ class Link extends Model null, ICON_SIZE_SMALL ); - $url = api_get_path(WEB_CODE_PATH).'link/link_goto.php?'.api_get_cidreq().'&link_id='.$linkId.'&link_url='.urlencode($myrow['url']); + $url = api_get_path(WEB_CODE_PATH).'link/link_goto.php?'.api_get_cidreq().'&link_id='.$linkId; $content .= '
'.$myrow['description'].'
'; + $content .= ''.Security::remove_XSS($myrow['description']).'
'; $content .= '