Validate enabled payments types - refs #7768

plugin/buycourses/src/error.php

@@ -7,20 +7,6 @@
 /**
  * Config
  */
-$course_plugin = 'buycourses';
-require_once 'buy_course.lib.php';
-require_once 'buy_course_plugin.class.php';
-
-unset($_SESSION['bc_user_id']);
-unset($_SESSION['bc_registered']);
-unset($_SESSION['bc_code']);
-unset($_SESSION['bc_title']);
-unset($_SESSION['Payment_Amount']);
-unset($_SESSION['currencyCodeType']);
-unset($_SESSION['PaymentType']);
-unset($_SESSION['nvpReqArray']);
-unset($_SESSION['TOKEN']);
-$_SESSION['bc_success'] = false;
-$_SESSION['bc_message'] = 'CancelOrder';
+unset($_SESSION['bc_sale_id']);
 
 header('Location: course_catalog.php');

plugin/buycourses/src/process.php

@@ -59,11 +59,18 @@ $form->addText('name', get_lang('Name'), false, ['cols-size' => [5, 7, 0]]);
 $form->addText('username', get_lang('Username'), false, ['cols-size' => [5, 7, 0]]);
 $form->addText('email', get_lang('EmailAddress'), false, ['cols-size' => [5, 7, 0]]);
 $form->addHeader($plugin->get_lang('PaymentMethods'));
-$form->addRadio(
-    'payment_type',
-    null,
-    $plugin->getPaymentTypes()
-);
+
+$paymentTypesOptions = $plugin->getPaymentTypes();
+
+if (!$paypalEnabled) {
+    unset($paymentTypesOptions[BuyCoursesPlugin::PAYMENT_TYPE_PAYPAL]);
+}
+
+if (!$transferEnabled) {
+    unset($paymentTypesOptions[BuyCoursesPlugin::PAYMENT_TYPE_TRANSFER]);
+}
+
+$form->addRadio('payment_type', null, $paymentTypesOptions);
 $form->addHidden('t', intval($_GET['t']));
 $form->addHidden('i', intval($_GET['i']));
 $form->freeze(['name', 'username', 'email']);
@@ -82,8 +89,6 @@ $tpl = new Template($templateName);
 $tpl->assign('buying_course', $buyingCourse);
 $tpl->assign('buying_session', $buyingSession);
 $tpl->assign('user', api_get_user_info());
-$tpl->assign('paypal_enabled', $paypalEnabled);
-$tpl->assign('transfer_enabled', $transferEnabled);
 $tpl->assign('form', $form->returnForm());
 
 if ($buyingCourse) {

plugin/buycourses/src/success.php

@@ -11,6 +11,11 @@ require_once '../config.php';
 require_once dirname(__FILE__) . '/buy_course.lib.php';
 
 $plugin = BuyCoursesPlugin::create();
+$paypalEnabled = $plugin->get('paypal_enable') === 'true';
+
+if (!$paypalEnabled) {
+    api_not_allowed(true);
+}
 
 $sale = $plugin->getSale($_SESSION['bc_sale_id']);