diff --git a/main/work/upload.php b/main/work/upload.php index 95bdf390fa..1ab7a34c5e 100644 --- a/main/work/upload.php +++ b/main/work/upload.php @@ -77,11 +77,15 @@ if (!empty($parent_data) && !empty($parent_data['qualification'])) { } }*/ +$has_expired = false; +$has_ended = false; +$message = null; + if (!empty($my_folder_data)) { $homework = get_work_assignment_by_id($my_folder_data['id']); if ($homework['expires_on'] != '0000-00-00 00:00:00' || $homework['ends_on'] != '0000-00-00 00:00:00') { - $time_now = time(); + $time_now = time(); if (!empty($homework['expires_on']) && $homework['expires_on'] != '0000-00-00 00:00:00') { $time_expires = api_strtotime($homework['expires_on'], 'UTC'); @@ -106,6 +110,16 @@ if (!empty($my_folder_data)) { $ends_on = api_convert_and_format_date($homework['ends_on']); $expires_on = api_convert_and_format_date($homework['expires_on']); } + + if ($has_ended) { + $message = Display::return_message(get_lang('EndDateAlreadyPassed').' '.$ends_on, 'error'); + } elseif ($has_expired) { + $message = Display::return_message(get_lang('ExpiryDateAlreadyPassed').' '.$expires_on, 'warning'); + } else { + if ($has_expired) { + $message = Display::return_message(get_lang('ExpiryDateToSendWorkIs').' '.$expires_on); + } + } } $interbreadcrumb[] = array('url' => api_get_path(WEB_CODE_PATH).'work/work.php?'.api_get_cidreq(), 'name' => get_lang('StudentPublications')); @@ -318,6 +332,9 @@ $htmlHeadXtra[] = to_javascript_work(); Display :: display_header(null); if (!empty($work_id)) { + + echo $message; + if ($is_allowed_to_edit) { if (api_resource_is_locked_by_gradebook($work_id, LINK_STUDENTPUBLICATION)) { echo Display::display_warning_message(get_lang('ResourceLockedByGradebook')); @@ -331,6 +348,7 @@ if (!empty($work_id)) { Display::display_error_message(get_lang('ActionNotAllowed')); } } elseif ($student_can_edit_in_session && $has_ended == false) { + $form->display(); } else { Display::display_error_message(get_lang('ActionNotAllowed')); diff --git a/main/work/work.lib.php b/main/work/work.lib.php index f5efc3606a..a194dfe7c6 100644 --- a/main/work/work.lib.php +++ b/main/work/work.lib.php @@ -577,7 +577,7 @@ function display_student_publications_list($id, $my_folder_data, $work_parents, list($d_year, $d_month, $d_day) = explode('-', $parts[0]); list($d_hour, $d_minute) = explode(':', $parts[1]); - $qualification_input[] = FormValidator :: createElement('text', 'qualification'); + $qualification_input[] = $form_folder->createElement('text', 'qualification'); $form_folder -> addGroup($qualification_input, 'qualification', get_lang('QualificationNumeric')); if (Gradebook::is_active()) { @@ -593,7 +593,7 @@ function display_student_publications_list($id, $my_folder_data, $work_parents, //Loading gradebook select load_gradebook_select_in_tool($form_folder); - $weight_input2[] = FormValidator :: createElement('text', 'weight'); + $weight_input2[] = $form_folder->createElement('text', 'weight'); $form_folder -> addGroup($weight_input2, 'weight', get_lang('WeightInTheGradebook'), 'size="10"'); $form_folder -> addElement('html', ''); diff --git a/main/work/work.php b/main/work/work.php index 30c12ee7e3..3315e6cf2b 100644 --- a/main/work/work.php +++ b/main/work/work.php @@ -41,7 +41,7 @@ use ChamiloSession as Session; * */ -/* INIT SECTION */ +/* INIT SECTION */ $language_file = array('exercice', 'work', 'document', 'admin', 'gradebook'); @@ -114,10 +114,6 @@ $title = isset($_REQUEST['title']) ? $_REQUEST['title'] : ''; $description = isset($_REQUEST['description']) ? $_REQUEST['description'] : ''; $uploadvisibledisabled = isset($_REQUEST['uploadvisibledisabled']) ? Database::escape_string($_REQUEST['uploadvisibledisabled']) : $course_info['show_score']; -// get data for publication assignment -$has_expired = false; -$has_ended = false; - //directories management $sys_course_path = api_get_path(SYS_COURSE_PATH); $course_dir = $sys_course_path . $_course['path']; @@ -147,10 +143,10 @@ if (isset ($_POST['cancelForm']) && !empty ($_POST['cancelForm'])) { if ($_SERVER['REQUEST_METHOD'] == 'POST' && !sizeof($_POST)) { if (strstr($_SERVER['REQUEST_URI'], '?')) { header('Location: ' . $_SERVER['REQUEST_URI'] . '&submitWork=1'); - exit (); + exit(); } else { header('Location: ' . $_SERVER['REQUEST_URI'] . '?submitWork=1'); - exit (); + exit(); } } @@ -257,59 +253,16 @@ if (!in_array($action, array('add','create_dir'))) { $token = Security::get_token(); } -if (!empty($my_folder_data)) { - $homework = get_work_assignment_by_id($my_folder_data['id']); - - if ($homework['expires_on'] != '0000-00-00 00:00:00' || $homework['ends_on'] != '0000-00-00 00:00:00') { - $time_now = time(); - - if (!empty($homework['expires_on']) && $homework['expires_on'] != '0000-00-00 00:00:00') { - $time_expires = api_strtotime($homework['expires_on'], 'UTC'); - $difference = $time_expires - $time_now; - if ($difference < 0) { - $has_expired = true; - } - } - - if (empty($homework['expires_on']) || $homework['expires_on'] == '0000-00-00 00:00:00') { - $has_expired = false; - } - - if (!empty($homework['ends_on']) && $homework['ends_on'] != '0000-00-00 00:00:00') { - $time_ends = api_strtotime($homework['ends_on'], 'UTC'); - $difference2 = $time_ends - $time_now; - if ($difference2 < 0) { - $has_ended = true; - } - } - - $ends_on = api_convert_and_format_date($homework['ends_on']); - $expires_on = api_convert_and_format_date($homework['expires_on']); - - if ($has_ended) { - $message = Display::return_message(get_lang('EndDateAlreadyPassed').' '.$ends_on, 'error'); - } elseif ($has_expired) { - $message = Display::return_message(get_lang('ExpiryDateAlreadyPassed').' '.$expires_on, 'warning'); - } else { - if ($has_expired) { - $message = Display::return_message(get_lang('ExpiryDateToSendWorkIs').' '.$expires_on); - } - } - } -} - display_action_links($work_id, $curdirpath, $action); -echo $message; - -//for teachers +// for teachers switch ($action) { case 'settings': //if posts if ($is_allowed_to_edit && !empty($_POST['changeProperties'])) { // Changing the tool setting: default visibility of an uploaded document - // @todo i + // @todo $query = "UPDATE ".$main_course_table." SET show_score='" . $uploadvisibledisabled . "' WHERE code='" . api_get_course_id() . "'"; $res = Database::query($query);