diff --git a/main/forum/forumfunction.inc.php b/main/forum/forumfunction.inc.php index 7e6491c674..65f275387d 100644 --- a/main/forum/forumfunction.inc.php +++ b/main/forum/forumfunction.inc.php @@ -1,4 +1,4 @@ -addElement('header', '', get_lang('AddForum').$session_header); // we have a hidden field if we are editing - if (is_array($inputvalues)) { + if (is_array($inputvalues) && isset($inputvalues['forum_id'])) { $form->addElement('hidden', 'forum_id', $inputvalues['forum_id']); } // The title of the forum @@ -279,7 +284,7 @@ function show_add_forum_form($inputvalues=array()) { // Forum image $form->add_progress_bar(); - if (strlen($inputvalues['forum_image']) > 0) { + if (isset($inputvalues['forum_image']) && strlen($inputvalues['forum_image']) > 0) { $show_preview_image=''; $div = '
@@ -292,8 +297,8 @@ function show_add_forum_form($inputvalues=array()) { $form->addElement('html', $div .'
'); $form->addElement('checkbox', 'remove_picture', null, get_lang('DelImage')); } - - $form->addElement('file', 'picture', ($inputvalues['forum_image'] != '' ? get_lang('UpdateImage') : get_lang('AddImage'))); + $forum_image=isset($inputvalues['forum_image']) ? $inputvalues['forum_image'] : ''; + $form->addElement('file', 'picture', ($forum_image != '' ? get_lang('UpdateImage') : get_lang('AddImage'))); $form->addRule('picture', get_lang('OnlyImagesAllowed'), 'mimetype', array('image/gif', 'image/jpeg', 'image/png')); @@ -319,18 +324,18 @@ function show_add_forum_form($inputvalues=array()) { $defaults['forum_category']=Security::remove_XSS($_GET['forumcategory']); } } else { // the default values when editing = the data in the table - $defaults['forum_id']=$inputvalues['forum_id']; - $defaults['forum_title']=prepare4display(html_entity_decode($inputvalues['forum_title'],ENT_QUOTES,$charset)); - $defaults['forum_comment']=prepare4display($inputvalues['forum_comment']); - $defaults['forum_category']=$inputvalues['forum_category']; - $defaults['allow_anonymous_group']['allow_anonymous']=$inputvalues['allow_anonymous']; - $defaults['students_can_edit_group']['students_can_edit']=$inputvalues['allow_edit']; - $defaults['approval_direct_group']['approval_direct']=$inputvalues['approval_direct_post']; - $defaults['allow_attachments_group']['allow_attachments']=$inputvalues['allow_attachments']; - $defaults['allow_new_threads_group']['allow_new_threads']=$inputvalues['allow_new_threads']; - $defaults['default_view_type_group']['default_view_type']=$inputvalues['default_view']; - $defaults['public_private_group_forum_group']['public_private_group_forum']=$inputvalues['forum_group_public_private']; - $defaults['group_forum']=$inputvalues['forum_of_group']; + $defaults['forum_id']=isset($inputvalues['forum_id']) ? $inputvalues['forum_id'] : null; + $defaults['forum_title']=prepare4display(html_entity_decode(isset($inputvalues['forum_title']) ? $inputvalues['forum_title'] : null,ENT_QUOTES,$charset)); + $defaults['forum_comment']=prepare4display(isset($inputvalues['forum_comment'])?$inputvalues['forum_comment']:null); + $defaults['forum_category']=isset($inputvalues['forum_category']) ? $inputvalues['forum_category'] : null; + $defaults['allow_anonymous_group']['allow_anonymous']=isset($inputvalues['allow_anonymous']) ? $inputvalues['allow_anonymous'] :null; + $defaults['students_can_edit_group']['students_can_edit']=isset($inputvalues['allow_edit'])?$inputvalues['allow_edit']:null; + $defaults['approval_direct_group']['approval_direct']=isset($inputvalues['approval_direct_post'])?$inputvalues['approval_direct_post']:null; + $defaults['allow_attachments_group']['allow_attachments']=isset($inputvalues['allow_attachments'])?$inputvalues['allow_attachments']:null; + $defaults['allow_new_threads_group']['allow_new_threads']=isset($inputvalues['allow_new_threads'])?$inputvalues['allow_new_threads']:null; + $defaults['default_view_type_group']['default_view_type']=isset($inputvalues['default_view'])?$inputvalues['default_view']:null; + $defaults['public_private_group_forum_group']['public_private_group_forum']=isset($inputvalues['forum_group_public_private'])?$inputvalues['forum_group_public_private']:null; + $defaults['group_forum']=isset($inputvalues['forum_of_group'])?$inputvalues['forum_of_group']:null; } $form->setDefaults($defaults); // The validation or display