From 9357eab6296e708e650c47de49a8a447ec74cf61 Mon Sep 17 00:00:00 2001 From: Angel Fernando Quiroz Campos Date: Fri, 8 Nov 2019 09:52:38 -0500 Subject: [PATCH] Minor - MigrationMoodle: clean code - refs BT#15992 --- plugin/migrationmoodle/admin.php | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/plugin/migrationmoodle/admin.php b/plugin/migrationmoodle/admin.php index 0f23087552..75c2d36187 100644 --- a/plugin/migrationmoodle/admin.php +++ b/plugin/migrationmoodle/admin.php @@ -1,6 +1,7 @@ $actionTitle) { if (!empty($action)) { echo '

'.$actionNames[$action].'

'; + /** @var BaseTask|null $task */ + $task = null; + switch ($action) { case 'users': - $usersMigration = new UsersTask(); - $usersMigration->execute(); + $task = new UsersTask(); break; case 'course_categories': - $courseCategoriesMigration = new CourseCategoriesTask(); - $courseCategoriesMigration->execute(); + $task = new CourseCategoriesTask(); break; case 'courses': - $coursesMigration = new CoursesTask(); - $coursesMigration->execute(); + $task = new CoursesTask(); break; case 'course_users': - $courseUsersMigration = new CourseUsersTask(); - $courseUsersMigration->execute(); + $task = new CourseUsersTask(); break; case 'quizzes': - $quizTask = new CQuizTask(); - $quizTask->execute(); + $task = new CQuizTask(); break; } + + if ($task) { + $task->execute(); + } }