From a01343e09125228c7df66a6f91ca39db9aaad7fe Mon Sep 17 00:00:00 2001 From: Yannick Warnier Date: Fri, 3 Apr 2015 20:47:46 -0500 Subject: [PATCH] Check variables initialization to avoid notice --- main/exercice/exercise_reminder.php | 36 ++++++++++++++++++++++++----- 1 file changed, 30 insertions(+), 6 deletions(-) diff --git a/main/exercice/exercise_reminder.php b/main/exercice/exercise_reminder.php index e7d8cd549c..9038cb5e49 100755 --- a/main/exercice/exercise_reminder.php +++ b/main/exercice/exercise_reminder.php @@ -20,24 +20,48 @@ if ($debug>0) { // general parameters passed via POST/GET if (empty ($origin)) { - $origin = Security::remove_XSS($_REQUEST['origin']); + if (!empty($_REQUEST['origin'])) { + $origin = Security::remove_XSS($_REQUEST['origin']); + } else { + $origin = ''; + } } if (empty($learnpath_id)) { - $learnpath_id = intval($_REQUEST['learnpath_id']); + if (!empty($_REQUEST['learnpath_id'])) { + $learnpath_id = intval($_REQUEST['learnpath_id']); + } else { + $learnpath_id = 0; + } } if (empty($learnpath_item_id)) { - $learnpath_item_id = intval($_REQUEST['learnpath_item_id']); + if (!empty($_REQUEST['learnpath_item_id'])) { + $learnpath_item_id = intval($_REQUEST['learnpath_item_id']); + } else { + $learnpath_item_id = 0; + } } if (empty($learnpath_item_view_id)) { - $learnpath_item_view_id = intval($_REQUEST['learnpath_item_view_id']); + if (!empty($_REQUEST['learnpath_item_view_id'])) { + $learnpath_item_view_id = intval($_REQUEST['learnpath_item_view_id']); + } else { + $learnpath_item_view_id = 0; + } } if (empty($exerciseId)) { - $exerciseId = intval($_REQUEST['exerciseId']); + if (!empty($_REQUEST['exerciseId'])) { + $exerciseId = intval($_REQUEST['exerciseId']); + } else { + $exerciseId = 0; + } } if (empty($objExercise)) { - $objExercise = $_SESSION['objExercise']; + if (!empty($_SESSION['objExercise'])) { + $objExercise = $_SESSION['objExercise']; + } else { + $objExercise = null; + } } if (!$objExercise) {