diff --git a/main/admin/course_request_edit.php b/main/admin/course_request_edit.php index 9705ab5068..6d7f052cf8 100644 --- a/main/admin/course_request_edit.php +++ b/main/admin/course_request_edit.php @@ -148,7 +148,7 @@ if ($course_validation_feature) { // Filter incoming data. foreach ($course_request_values as &$value) { - $value = trim(Security::remove_XSS($value)); + $value = trim(Security::remove_XSS(stripslashes($value))); } // Detection which submit button has been pressed. diff --git a/main/create_course/add_course.php b/main/create_course/add_course.php index d79cbf05b8..6dbabeb9a9 100755 --- a/main/create_course/add_course.php +++ b/main/create_course/add_course.php @@ -180,38 +180,22 @@ $form->setDefaults($values); if ($form->validate()) { $course_values = $form->exportValues(); - $wanted_code = Security::remove_XSS($course_values['wanted_code']); - $tutor_name = $course_values['tutor_name']; + $wanted_code = trim(Security::remove_XSS(stripslashes($course_values['wanted_code']))); + $tutor_name = stripslashes($course_values['tutor_name']); $category_code = $course_values['category_code']; - $title = Security::remove_XSS($course_values['title']); + $title = Security::remove_XSS(stripslashes($course_values['title'])); $course_language = $course_values['course_language']; $exemplary_content = !empty($course_values['exemplary_content']); if ($course_validation_feature) { - $description = Security::remove_XSS($course_values['description']); - $objetives = Security::remove_XSS($course_values['objetives']); - $target_audience = Security::remove_XSS($course_values['target_audience']); + $description = Security::remove_XSS(stripslashes($course_values['description'])); + $objetives = Security::remove_XSS(stripslashes($course_values['objetives'])); + $target_audience = Security::remove_XSS(stripslashes($course_values['target_audience'])); $status = '0'; - - // TODO: Why escaping quotes is needed here? - $description = str_replace('"', '', $description); - $objetives = str_replace('"', '', $objetives); - $target_audience = str_replace('"', '', $target_audience); - } - - $wanted_code = Database::escape_string($wanted_code); - $title = Database::escape_string($title); - - if ($course_validation_feature) { - $description = Database::escape_string($description); - $objetives = Database::escape_string($objetives); - $target_audience = Database::escape_string($target_audience); } - $wanted_code = trim($wanted_code); if ($wanted_code == '') { $wanted_code = generate_course_code(api_substr($title, 0, $maxlength)); - $wanted_code = Database::escape_string($wanted_code); } // Check whether the requested course code has already been occupied. @@ -246,7 +230,7 @@ if ($form->validate()) { // Preparing a confirmation message. $link = api_get_path(WEB_COURSE_PATH).$directory.'/'; $message = get_lang('JustCreated'); - $message .= ' '.$title.''; + $message .= ' '.api_htmlentities($title, ENT_QUOTES).''; Display :: display_confirmation_message($message, false); echo '