Remove notices and warning messages - refs #7670

1.10.x
Imanol Losada 11 years ago
parent fa51c538aa
commit a5de6f1e75
  1. 40
      plugin/ticket/src/myticket.php
  2. 5
      plugin/ticket/src/new_ticket.php
  3. 18
      plugin/ticket/src/ticket.class.php
  4. 12
      plugin/ticket/src/ticket_details.php

@ -199,9 +199,35 @@ $isAdmin = api_is_platform_admin();
Display::display_header($plugin->get_lang('MyTickets'));
if ($isAdmin) {
$get_parameter = '&keyword=' . Security::remove_XSS($_GET['keyword']) . '&keyword_status=' . Security::remove_XSS($_GET['keyword_status']) . '&keyword_category=' .Security::remove_XSS($_GET['keyword_category']). '&keyword_request_user=' . Security::remove_XSS($_GET['keyword_request_user']);
$get_parameter .= '&keyword_admin=' . Security::remove_XSS($_GET['keyword_admin']) . '&keyword_start_date=' . Security::remove_XSS($_GET['keyword_start_date']) . '&keyword_unread=' . Security::remove_XSS($_GET['keyword_unread']);
$get_parameter2 = '&Tickets_per_page=' . Security::remove_XSS($_GET['Tickets_per_page']) . '&Tickets_column=' . Security::remove_XSS($_GET['Tickets_column']);
$getParameters = [
'keyword',
'keyword_status',
'keyword_category',
'keyword_request_user',
'keyword_admin',
'keyword_start_date',
'keyword_unread',
'Tickets_per_page',
'Tickets_column'
];
$get_parameter = '';
foreach ($getParameters as $getParameter) {
if (isset($_GET[$getParameter])) {
$get_parameter .= "&$getParameter=".Security::remove_XSS($_GET[$getParameter]);
}
}
$getParameters = [
'Tickets_per_page',
'Tickets_column'
];
$get_parameter2 = '';
foreach ($getParameters as $getParameter) {
if (isset($_GET[$getParameter])) {
$get_parameter2 .= "&$getParameter=".Security::remove_XSS($_GET[$getParameter]);
}
}
if (isset($_GET['submit_advanced'])) {
$get_parameter .= "&submit_advanced=";
}
@ -209,7 +235,7 @@ if ($isAdmin) {
$get_parameter .= "&submit_simple=";
}
//select categories
$select_types .= '<select class="chzn-select" name = "keyword_category" id="keyword_category" ">';
$select_types = '<select class="chzn-select" name = "keyword_category" id="keyword_category" ">';
$select_types .= '<option value="">---' . get_lang('Select') . '---</option>';
$types = TicketManager::get_all_tickets_categories();
foreach ($types as $type) {
@ -217,7 +243,7 @@ if ($isAdmin) {
}
$select_types .= "</select>";
//select admins
$select_admins .= '<select class ="chzn-select" name = "keyword_admin" id="keyword_admin" ">';
$select_admins = '<select class ="chzn-select" name = "keyword_admin" id="keyword_admin" ">';
$select_admins .= '<option value="">---' . get_lang('Select') . '---</option>';
$select_admins .= '<option value = "0">' . $plugin->get_lang('Unassigned') . '</option>';
$admins = UserManager::get_user_list_like(array("status" => "1"), array("username"), true);
@ -226,7 +252,7 @@ if ($isAdmin) {
}
$select_admins .= "</select>";
//select status
$select_status .= '<select class ="chzn-select" name = "keyword_status" id="keyword_status" >';
$select_status = '<select class ="chzn-select" name = "keyword_status" id="keyword_status" >';
$select_status .= '<option value="">---' . get_lang('Select') . '---</option>';
$status = TicketManager::get_all_tickets_status();
foreach ($status as $stat) {
@ -234,7 +260,7 @@ if ($isAdmin) {
}
$select_status .= "</select>";
//select priority
$select_priority .= '<select name = "keyword_priority" id="keyword_priority" >';
$select_priority = '<select name = "keyword_priority" id="keyword_priority" >';
$select_priority .= '<option value="">' . get_lang('All') . '</option>';
$select_priority .= '<option value="NRM">' . $plugin->get_lang('PriorityNormal') . '</option>';
$select_priority .= '<option value="HGH">' . $plugin->get_lang('PriorityHigh') . '</option>';

@ -411,8 +411,11 @@ function show_form_send_ticket()
'button',
'compose',
get_lang('SendMessage'),
null,
null,
null,
'save',
array(
'class' => 'save',
'id' => 'btnsubmit'
)
);

@ -504,9 +504,12 @@ class TicketManager
if (!$isAdmin) {
$sql .= " AND request_user = '$user_id' ";
}
$keyword_unread = Database::escape_string(
trim($_GET['keyword_unread'])
);
$keyword_unread = '';
if (isset($_GET['keyword_unread'])) {
$keyword_unread = Database::escape_string(
trim($_GET['keyword_unread'])
);
}
//Search simple
if (isset($_GET['submit_simple'])) {
if ($_GET['keyword'] != '') {
@ -812,9 +815,12 @@ class TicketManager
OR user.username LIKE '%$keyword%') ";
}
}
$keyword_unread = Database::escape_string(
trim($_GET['keyword_unread'])
);
$keyword_unread = '';
if (isset($_GET['keyword_unread'])) {
$keyword_unread = Database::escape_string(
trim($_GET['keyword_unread'])
);
}
//Search advanced
if (isset($_GET['submit_advanced'])) {
$keyword_category = Database::escape_string(

@ -247,13 +247,14 @@ if (!isset($_POST['compose'])) {
}
}
$titulo = '<center><h1>Ticket #' . $ticket['ticket']['ticket_code'] . '</h1></center>';
$img_assing = '';
if ($isAdmin && $ticket['ticket']['status_id'] != 'CLS' && $ticket['ticket']['status_id'] != 'REE') {
if ($ticket['ticket']['assigned_last_user'] != 0 && $ticket['ticket']['assigned_last_user'] == $user_id) {
$img_assing = '<a href="' . api_get_self() . '?ticket_id=' . $ticket['ticket']['ticket_id'] . '&amp;action=unassign" id="unassign">
<img src="' . api_get_path(WEB_CODE_PATH) . 'img/admin_star.png" style="height: 32px; width: 32px;" border="0" title="Unassign" align="center"/>
</a>';
} else {
$img_assing .= '<a href="#" id="assign"><img src="' . api_get_path(WEB_CODE_PATH) . 'img/admin_star_na.png" style="height: 32px; width: 32px;" title="Assign" align="center"/></a>';
$img_assing = '<a href="#" id="assign"><img src="' . api_get_path(WEB_CODE_PATH) . 'img/admin_star_na.png" style="height: 32px; width: 32px;" title="Assign" align="center"/></a>';
}
}
$bold = '';
@ -306,7 +307,7 @@ if (!isset($_POST['compose'])) {
</tr>';
}
//select admins
$select_admins .= '<select class ="chzn-select" style="width: 350px; " name = "admins" id="admins" ">';
$select_admins = '<select class ="chzn-select" style="width: 350px; " name = "admins" id="admins" ">';
$admins = UserManager::get_user_list_like(array("status" => "1"), array("username"), true);
foreach ($admins as $admin) {
@ -450,9 +451,10 @@ function show_form_send_message()
'button',
'compose',
get_lang('SendMessage'),
array(
'class' => 'save'
)
null,
null,
null,
'save'
);
$form->display();

Loading…
Cancel
Save