From a9840b8d60e7b772abb550ffbc3b5b47bec80a1b Mon Sep 17 00:00:00 2001 From: Angel Fernando Quiroz Campos Date: Wed, 10 Jan 2018 15:11:40 -0500 Subject: [PATCH] Improve code + Format code #2160 --- main/exercise/TestCategory.php | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/main/exercise/TestCategory.php b/main/exercise/TestCategory.php index 17beee1fc0..e9d54b09c7 100644 --- a/main/exercise/TestCategory.php +++ b/main/exercise/TestCategory.php @@ -615,21 +615,19 @@ class TestCategory /** * @param int $questionId - * @param int $displayCategoryName */ - public static function displayCategoryAndTitle($questionId, $displayCategoryName = 1) + public static function displayCategoryAndTitle($questionId) { - echo self::returnCategoryAndTitle($questionId, $displayCategoryName); + echo self::returnCategoryAndTitle($questionId); } /** * @param int $questionId - * @param int $showCategoryName * @return null|string */ - public static function returnCategoryAndTitle($questionId, $showCategoryName = 1) + public static function returnCategoryAndTitle($questionId) { - $is_student = !(api_is_allowed_to_edit(null, true) || api_is_session_admin()); + $isStudent = !(api_is_allowed_to_edit(null, true) || api_is_session_admin()); $objExercise = Session::read('objExercise'); if (empty($objExercise)) { return ''; @@ -638,7 +636,7 @@ class TestCategory $showCategoryName = !!$objExercise->display_category_name; //double negation to get a boolean value $categoryName = self::getCategoryNameForQuestion($questionId); - if (empty($categoryName) || (!$showCategoryName && $is_student)) { + if (empty($categoryName) || (!$showCategoryName && $isStudent)) { return ''; }