From ad358ef7b98569f4b25f1b7b58f067159a9377e1 Mon Sep 17 00:00:00 2001 From: Angel Fernando Quiroz Campos Date: Tue, 4 Aug 2020 19:04:12 -0500 Subject: [PATCH] Minor - Flint fixes --- plugin/zoom/Entity/RegistrantEntity.php | 12 ++++++------ plugin/zoom/lang/english.php | 1 - plugin/zoom/lib/MeetingEntityRepository.php | 7 +++---- plugin/zoom/lib/ZoomPlugin.php | 6 ++---- 4 files changed, 11 insertions(+), 15 deletions(-) diff --git a/plugin/zoom/Entity/RegistrantEntity.php b/plugin/zoom/Entity/RegistrantEntity.php index fd339e0151..2aad05e3ea 100644 --- a/plugin/zoom/Entity/RegistrantEntity.php +++ b/plugin/zoom/Entity/RegistrantEntity.php @@ -131,9 +131,9 @@ class RegistrantEntity } /** - * @return MeetingRegistrantListItem * @throws Exception * + * @return MeetingRegistrantListItem */ public function getMeetingRegistrantListItem() { @@ -143,9 +143,9 @@ class RegistrantEntity /** * @param MeetingRegistrantListItem $meetingRegistrantListItem * - * @return $this * @throws Exception * + * @return $this */ public function setMeetingRegistrantListItem($meetingRegistrantListItem) { @@ -176,9 +176,9 @@ class RegistrantEntity } /** - * @return CreatedRegistration * @throws Exception * + * @return CreatedRegistration */ public function getCreatedRegistration() { @@ -188,9 +188,9 @@ class RegistrantEntity /** * @param CreatedRegistration $createdRegistration * - * @return $this * @throws Exception * + * @return $this */ public function setCreatedRegistration($createdRegistration) { @@ -205,9 +205,9 @@ class RegistrantEntity } /** - * @return MeetingRegistrant * @throws Exception * + * @return MeetingRegistrant */ public function getMeetingRegistrant() { @@ -217,9 +217,9 @@ class RegistrantEntity /** * @param MeetingRegistrant $meetingRegistrant * - * @return $this * @throws Exception * + * @return $this */ public function setMeetingRegistrant($meetingRegistrant) { diff --git a/plugin/zoom/lang/english.php b/plugin/zoom/lang/english.php index ef7c5076ba..1c9e799cdc 100755 --- a/plugin/zoom/lang/english.php +++ b/plugin/zoom/lang/english.php @@ -140,4 +140,3 @@ $strings['Meetings'] = "Meetings"; $strings['ConferenceType'] = "Conference type"; $strings['ForEveryone'] = "Everyone"; $strings['SomeUsers'] = "Some users (Select later)"; - diff --git a/plugin/zoom/lib/MeetingEntityRepository.php b/plugin/zoom/lib/MeetingEntityRepository.php index 63d146ac29..84d1c28f1e 100644 --- a/plugin/zoom/lib/MeetingEntityRepository.php +++ b/plugin/zoom/lib/MeetingEntityRepository.php @@ -79,7 +79,6 @@ class MeetingEntityRepository extends EntityRepository Criteria::expr()->andX( Criteria::expr()->eq('course', null), Criteria::expr()->orX(Criteria::expr()->eq('user', null), Criteria::expr()->eq('user', $user)) - ) ) ); @@ -100,9 +99,9 @@ class MeetingEntityRepository extends EntityRepository } /** - * @param DateTime $start - * @param DateTime $end - * @param User $user + * @param DateTime $start + * @param DateTime $end + * @param User $user * * @return ArrayCollection|Collection|MeetingEntity[] */ diff --git a/plugin/zoom/lib/ZoomPlugin.php b/plugin/zoom/lib/ZoomPlugin.php index 9f57d1e810..e565bd1451 100644 --- a/plugin/zoom/lib/ZoomPlugin.php +++ b/plugin/zoom/lib/ZoomPlugin.php @@ -330,7 +330,6 @@ class ZoomPlugin extends Plugin Display::addFlash( Display::return_message($this->get_lang('MeetingUpdated'), 'confirm') ); - } catch (Exception $exception) { Display::addFlash( Display::return_message($exception->getMessage(), 'error') @@ -721,7 +720,7 @@ class ZoomPlugin extends Plugin $form->getSubmitValue('duration'), $form->getSubmitValue('topic'), $form->getSubmitValue('agenda'), - substr(uniqid('z', true),0, 10) + substr(uniqid('z', true), 0, 10) ); Display::addFlash( @@ -790,7 +789,6 @@ class ZoomPlugin extends Plugin } /** - * * @return bool whether the logged-in user can manage conferences in this context, that is either * the current course or session coach, the platform admin or the current course admin */ @@ -969,7 +967,7 @@ class ZoomPlugin extends Plugin } if ('true' === $this->get('enableParticipantRegistration')) { - //if ('true' === $this->get('enableParticipantRegistration') && $meeting->requiresRegistration()) { + //if ('true' === $this->get('enableParticipantRegistration') && $meeting->requiresRegistration()) { // the participant must be registered $registrant = $meeting->getRegistrant($currentUser); if (null !== $registrant) {