From adbe2bbbf0097cbdf6ca3a498eae0244e82ddbb8 Mon Sep 17 00:00:00 2001 From: Julio Montoya Date: Fri, 12 Jun 2020 10:42:36 +0200 Subject: [PATCH] Fix exercise question UI BT#17381 --- ...MultipleAnswerTrueFalseDegreeCertainty.php | 37 +++++++++---------- .../exercise/global_multiple_answer.class.php | 29 +++++---------- .../multiple_answer_true_false.class.php | 10 ++--- 3 files changed, 33 insertions(+), 43 deletions(-) diff --git a/main/exercise/MultipleAnswerTrueFalseDegreeCertainty.php b/main/exercise/MultipleAnswerTrueFalseDegreeCertainty.php index fdb97575e1..8bfac2c249 100644 --- a/main/exercise/MultipleAnswerTrueFalseDegreeCertainty.php +++ b/main/exercise/MultipleAnswerTrueFalseDegreeCertainty.php @@ -65,22 +65,21 @@ class MultipleAnswerTrueFalseDegreeCertainty extends Question $renderer = &$form->defaultRenderer(); $defaults = []; - $html = ''; + $form->addHeader(get_lang('Answers')); + $html = '
' - .get_lang('Number') - .'' - .get_lang('True') - .'' - .get_lang('False') - .'' - .get_lang('Answer') - .'
+ + + + + '; // show column comment when feedback is enable if ($objEx->getFeedbackType() != EXERCISE_FEEDBACK_TYPE_EXAM) { - $html .= ''; + $html .= ''; } $html .= ''; - $form->addElement('label', get_lang('Answers').'
', $html); + + $form->addHtml($html); $correct = 0; $answer = null; @@ -831,17 +830,17 @@ class MultipleAnswerTrueFalseDegreeCertainty extends Question $colWidth = $widthTable / 5; $html .= ' - - - @@ -1147,8 +1146,8 @@ class MultipleAnswerTrueFalseDegreeCertainty extends Question $tblAnswerOption = Database::get_course_table(TABLE_QUIZ_QUESTION_OPTION); $courseId = api_get_course_int_id(); $optionId = (int) $optionId; - $sql = "SELECT position - FROM $tblAnswerOption + $sql = "SELECT position + FROM $tblAnswerOption WHERE c_id = $courseId AND id = $optionId"; $res = Database::query($sql); @@ -1232,7 +1231,7 @@ class MultipleAnswerTrueFalseDegreeCertainty extends Question $tableTrackEExercise = Database::get_main_table(TABLE_STATISTIC_TRACK_E_EXERCISES); $exeId = (int) $exeId; - $sql = "SELECT exe_exo_id + $sql = "SELECT exe_exo_id FROM $tableTrackEExercise WHERE exe_id=".$exeId; $res = Database::query($sql); diff --git a/main/exercise/global_multiple_answer.class.php b/main/exercise/global_multiple_answer.class.php index 32ec89422b..aa3191cd8e 100755 --- a/main/exercise/global_multiple_answer.class.php +++ b/main/exercise/global_multiple_answer.class.php @@ -32,27 +32,18 @@ class GlobalMultipleAnswer extends Question $obj_ex = Session::read('objExercise'); + $form->addHeader(get_lang('Answers')); /* Mise en variable de Affichage "Reponses" et son icone, "N�", "Vrai", "Reponse" */ - $html = '
'.get_lang('Number').''.get_lang('True').''.get_lang('False').''.get_lang('Answer').''.get_lang('Comment').''.get_lang('Comment').'
'. sprintf(get_lang('IncorrectAnswersX'), $nbResponsesInc).' '. sprintf(get_lang('IgnoranceAnswersX'), $nbResponsesIng).' '. sprintf(get_lang('CorrectAnswersX'), $nbResponsesCor).'
+ $html = '
- - - '; - - $html .= ''; - $html .= ''; - $form->addElement( - 'label', - get_lang('Answers'). - '
'.Display::return_icon('fill_field.png'), - $html - ); + + + + + + '; + $form->addHtml($html); + $defaults = []; $correct = 0; $answer = false; diff --git a/main/exercise/multiple_answer_true_false.class.php b/main/exercise/multiple_answer_true_false.class.php index a807a5a932..72ed7d1533 100755 --- a/main/exercise/multiple_answer_true_false.class.php +++ b/main/exercise/multiple_answer_true_false.class.php @@ -45,14 +45,14 @@ class MultipleAnswerTrueFalse extends Question $html = '
- '.get_lang('Number').' - - '.get_lang('True').' - - '.get_lang('Answer').' - '.get_lang('Comment').'
'.get_lang('Number').''.get_lang('True').''.get_lang('Answer').''.get_lang('Comment').'
'; $html .= ''; $html .= ''; - $html .= ''; - $html .= ''; - $html .= ''; - $html .= ''; + $html .= ''; + $html .= ''; + $html .= ''; + $html .= ''; // show column comment when feedback is enable if ($obj_ex->getFeedbackType() != EXERCISE_FEEDBACK_TYPE_EXAM) { - $html .= ''; + $html .= ''; } $html .= '';
'.get_lang('Number').''.get_lang('True').''.get_lang('False').''.get_lang('Answer').''.get_lang('Number').''.get_lang('True').''.get_lang('False').''.get_lang('Answer').''.get_lang('Comment').''.get_lang('Comment').'