From b14b09b3ebddce0a309130174cc4909d93087ec4 Mon Sep 17 00:00:00 2001
From: Hubert Borderiou <baelmyhu@gmail.com>
Date: Tue, 15 Nov 2011 10:50:20 +0100
Subject: [PATCH] #4029 Random and number of attempt menu empty corrected

---
 main/exercice/exercise.class.php | 8 +++++---
 main/exercice/exercise_admin.php | 5 +++--
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/main/exercice/exercise.class.php b/main/exercice/exercise.class.php
index b4eb3c7825..1c9b30af19 100644
--- a/main/exercice/exercise.class.php
+++ b/main/exercice/exercise.class.php
@@ -819,7 +819,8 @@ class Exercise {
 			</div>');
 
 		// Random questions
-		$form->addElement('html','<div id="options" style="display:none">');
+		// style="" and not "display:none" to avoid #4029 Random and number of attempt menu empty
+		$form->addElement('html','<div id="options" style="">');
 
 		if ($type=='full') {
 
@@ -932,9 +933,10 @@ class Exercise {
 			//Attempts
 			$attempt_option=range(0,10);
 			$attempt_option[0]=get_lang('Infinite');
-
+			
 			$form->addElement('select', 'exerciseAttempts',get_lang('ExerciseAttempts'),$attempt_option, array('id'=>'exerciseAttempts','class'=>'chzn-select'));
-
+			
+			// Exercice time limit
 			$form->addElement('checkbox', 'activate_start_date_check',get_lang('EnableStartTime'),null, array('onclick' => 'activate_start_date()'));
 				
 			$var = Exercise::selectTimeLimit();
diff --git a/main/exercice/exercise_admin.php b/main/exercice/exercise_admin.php
index e3b1691835..56bd4951e4 100644
--- a/main/exercice/exercise_admin.php
+++ b/main/exercice/exercise_admin.php
@@ -127,16 +127,17 @@ $htmlHeadXtra[] = '<script type="text/javascript">
 		function check_results_disabled() {		
 			document.getElementById(\'exerciseType_2\').checked = true;
 		}
-                   
 		</script>';
 
+    // to correct #4029 Random and number of attempt menu empty added window.onload=advanced_parameters;
 $htmlHeadXtra[] = '<script type="text/javascript">
 function setFocus(){
     $("#exercise_title").focus();
 }
 $(document).ready(function () {
     setFocus();
-});
+}); 
+    window.onload=advanced_parameters;
 </script>';
 
 // INIT EXERCISE