diff --git a/main/admin/skill_create.php b/main/admin/skill_create.php index 9262ff21d1..b4a38ea636 100644 --- a/main/admin/skill_create.php +++ b/main/admin/skill_create.php @@ -92,7 +92,7 @@ $jquery_ready_content = $returnParams['jquery_ready_content']; if (!empty($jquery_ready_content)) { $htmlHeadXtra[] = ''; } @@ -122,7 +122,7 @@ if ($createForm->validate()) { ); } - header('Location: '.api_get_path(WEB_CODE_PATH) . 'admin/skill_list.php'); + header('Location: '.api_get_path(WEB_CODE_PATH).'admin/skill_list.php'); exit; } diff --git a/main/course_progress/thematic_advance.php b/main/course_progress/thematic_advance.php index 4d5dd27590..8c9e364ab0 100755 --- a/main/course_progress/thematic_advance.php +++ b/main/course_progress/thematic_advance.php @@ -22,7 +22,7 @@ if ($action === 'thematic_advance_add' || $action === 'thematic_advance_edit') { $form = new FormValidator( 'thematic_advance', 'POST', - api_get_self() . '?' . api_get_cidreq() + api_get_self().'?'.api_get_cidreq() ); $form->addElement('header', $header_form); //$form->addElement('hidden', 'thematic_advance_token',$token); @@ -191,7 +191,7 @@ if ($action === 'thematic_advance_add' || $action === 'thematic_advance_edit') { $thematic = new Thematic(); $thematic->set_thematic_advance_attributes( - isset($values['thematic_advance_id']) ? $values['thematic_advance_id']: null, + isset($values['thematic_advance_id']) ? $values['thematic_advance_id'] : null, $values['thematic_id'], $values['start_date_type'] == 1 && isset($values['attendance_select']) ? $values['attendance_select'] : 0, $values['content'], @@ -210,13 +210,13 @@ if ($action === 'thematic_advance_add' || $action === 'thematic_advance_edit') { } } - $redirectUrlParams = 'course_progress/index.php?' . api_get_cidreq() . '&' . + $redirectUrlParams = 'course_progress/index.php?'.api_get_cidreq().'&'. http_build_query([ 'action' => 'thematic_advance_list', 'thematic_id' => $values['thematic_id'] ]); - header('Location: ' . api_get_path(WEB_CODE_PATH) . $redirectUrlParams); + header('Location: '.api_get_path(WEB_CODE_PATH).$redirectUrlParams); exit; } @@ -226,10 +226,10 @@ if ($action === 'thematic_advance_add' || $action === 'thematic_advance_edit') { // thematic advance list echo '
'; echo ''. - Display::return_icon('back.png', get_lang("BackTo"),'',ICON_SIZE_MEDIUM).''; + Display::return_icon('back.png', get_lang("BackTo"), '', ICON_SIZE_MEDIUM).''; if (api_is_allowed_to_edit(false, true)) { echo ' '. - Display::return_icon('add.png', get_lang('NewThematicAdvance'),'',ICON_SIZE_MEDIUM).''; + Display::return_icon('add.png', get_lang('NewThematicAdvance'), '', ICON_SIZE_MEDIUM).''; } echo '
'; $table = new SortableTable( diff --git a/main/coursecopy/copy_course_session.php b/main/coursecopy/copy_course_session.php index bdaf03c682..fcf67a9102 100755 --- a/main/coursecopy/copy_course_session.php +++ b/main/coursecopy/copy_course_session.php @@ -85,7 +85,7 @@ function make_select_session_list($name, $sessions, $attr = array()) function display_form() { - $html = ''; + $html = ''; $sessions = SessionManager::get_sessions_list(array(), array('name', 'ASC')); // Link back to the documents overview @@ -109,7 +109,7 @@ function display_form() //destination $html .= '
'; - $html .= ''; + $html .= ''; $html .= '
'; $html .= '
'; @@ -131,7 +131,7 @@ function display_form() $html .= ''; // Add Security token - $html .= ''; + $html .= ''; $html .= '
'; $html .= ''; @@ -227,7 +227,7 @@ $xajax->processRequests(); /* HTML head extra */ -$htmlHeadXtra[] = $xajax->getJavascript( api_get_path(WEB_LIBRARY_PATH).'xajax/'); +$htmlHeadXtra[] = $xajax->getJavascript(api_get_path(WEB_LIBRARY_PATH).'xajax/'); $htmlHeadXtra[] = ' '; @@ -259,11 +263,9 @@ class CourseSelectForm foreach ($forum_categories as $forum_category_id => $forum_category) { echo '
  • '; echo ''; - echo '
  • '; if (isset($forums[$forum_category_id])) { @@ -394,7 +396,6 @@ class CourseSelectForm public static function get_posted_course($from = '', $session_id = 0, $course_code = '') { $course = null; - if (isset($_POST['course'])) { $course = Course::unserialize(base64_decode($_POST['course'])); } else { diff --git a/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/Announcement.php b/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/Announcement.php index 0c6cb9a63f..3d6b850ef0 100644 --- a/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/Announcement.php +++ b/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/Announcement.php @@ -66,11 +66,10 @@ class Announcement extends Resource $this->date = $date; $this->display_order = $display_order; $this->email_sent = $email_sent; - - $this->attachment_path = $path; + $this->attachment_path = $path; $this->attachment_filename = $filename; - $this->attachment_size = $size; - $this->attachment_comment = $comment; + $this->attachment_size = $size; + $this->attachment_comment = $comment; } /** diff --git a/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/CalendarEvent.php b/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/CalendarEvent.php index 417cf21a53..1a21daecad 100644 --- a/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/CalendarEvent.php +++ b/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/CalendarEvent.php @@ -63,19 +63,19 @@ class CalendarEvent extends Resource $attachment_comment = null, $all_day = 0 ) { - parent::__construct($id, RESOURCE_EVENT); + parent::__construct($id, RESOURCE_EVENT); - $this->title = $title; - $this->content = $content; - $this->start_date = $start_date; - $this->end_date = $end_date; - $this->all_day = $all_day; + $this->title = $title; + $this->content = $content; + $this->start_date = $start_date; + $this->end_date = $end_date; + $this->all_day = $all_day; - $this->attachment_path = $attachment_path; - $this->attachment_filename = $attachment_filename; - $this->attachment_size = $attachment_size; - $this->attachment_comment = $attachment_comment; - } + $this->attachment_path = $attachment_path; + $this->attachment_filename = $attachment_filename; + $this->attachment_size = $attachment_size; + $this->attachment_comment = $attachment_comment; + } /** * Show this Event diff --git a/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/CourseCopyLearnpath.php b/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/CourseCopyLearnpath.php index ae6a79d863..9a9b1de43a 100644 --- a/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/CourseCopyLearnpath.php +++ b/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/CourseCopyLearnpath.php @@ -84,120 +84,119 @@ class CourseCopyLearnpath extends Resource */ public $author; - /** - * Author's image - */ - public $preview_image; - - /** - * Create a new learnpath - * @param integer ID - * @param integer Type (1,2,3,...) - * @param string $name - * @param string $path - * @param string $ref - * @param string $description - * @param string $content_local - * @param string $default_encoding - * @param string $default_view_mode - * @param bool $prevent_reinit - * @param bool $force_commit - * @param string $content_maker - * @param integer $display_order - * @param string $js_lib - * @param string $content_license - * @param integer $debug - * @param string $visibility - * @param array $items - */ - public function __construct( - $id, - $type, - $name, - $path, - $ref, - $description, - $content_local, - $default_encoding, - $default_view_mode, - $prevent_reinit, - $force_commit, - $content_maker, - $display_order, - $js_lib, - $content_license, - $debug, - $visibility, - $author, - $preview_image, - $use_max_score, - $autolaunch, - $created_on, - $modified_on, - $publicated_on, - $expired_on, - $session_id, - $items - ) { - parent::__construct($id, RESOURCE_LEARNPATH); - $this->lp_type = $type; - $this->name = $name; - $this->path = $path; - $this->ref = $ref; - $this->description = $description; - $this->content_local = $content_local; - $this->default_encoding = $default_encoding; - $this->default_view_mod = $default_view_mode; - $this->prevent_reinit = $prevent_reinit; - $this->force_commit = $force_commit; - $this->content_maker = $content_maker; - $this->display_order = $display_order; - $this->js_lib = $js_lib; - $this->content_license = $content_license; - $this->debug = $debug; - $this->visibility = $visibility; - - $this->use_max_score = $use_max_score; - $this->autolaunch = $autolaunch; - $this->created_on = $created_on; - $this->modified_on = $modified_on; - $this->publicated_on = $publicated_on; - $this->expired_on = $expired_on; - $this->session_id = $session_id; + /** + * Author's image + */ + public $preview_image; - $this->author = $author; - $this->preview_image = $preview_image; + /** + * Create a new learnpath + * @param integer ID + * @param integer Type (1,2,3,...) + * @param string $name + * @param string $path + * @param string $ref + * @param string $description + * @param string $content_local + * @param string $default_encoding + * @param string $default_view_mode + * @param bool $prevent_reinit + * @param bool $force_commit + * @param string $content_maker + * @param integer $display_order + * @param string $js_lib + * @param string $content_license + * @param integer $debug + * @param string $visibility + * @param array $items + */ + public function __construct( + $id, + $type, + $name, + $path, + $ref, + $description, + $content_local, + $default_encoding, + $default_view_mode, + $prevent_reinit, + $force_commit, + $content_maker, + $display_order, + $js_lib, + $content_license, + $debug, + $visibility, + $author, + $preview_image, + $use_max_score, + $autolaunch, + $created_on, + $modified_on, + $publicated_on, + $expired_on, + $session_id, + $items + ) { + parent::__construct($id, RESOURCE_LEARNPATH); + $this->lp_type = $type; + $this->name = $name; + $this->path = $path; + $this->ref = $ref; + $this->description = $description; + $this->content_local = $content_local; + $this->default_encoding = $default_encoding; + $this->default_view_mod = $default_view_mode; + $this->prevent_reinit = $prevent_reinit; + $this->force_commit = $force_commit; + $this->content_maker = $content_maker; + $this->display_order = $display_order; + $this->js_lib = $js_lib; + $this->content_license = $content_license; + $this->debug = $debug; + $this->visibility = $visibility; + $this->use_max_score = $use_max_score; + $this->autolaunch = $autolaunch; + $this->created_on = $created_on; + $this->modified_on = $modified_on; + $this->publicated_on = $publicated_on; + $this->expired_on = $expired_on; + $this->session_id = $session_id; + $this->author = $author; + $this->preview_image = $preview_image; + $this->items = $items; + } - $this->items = $items; - } - /** - * Get the items - */ - function get_items() - { - return $this->items; - } + /** + * Get the items + */ + function get_items() + { + return $this->items; + } - /** - * Check if a given resource is used as an item in this chapter - */ - function has_item($resource) - { - foreach ($this->items as $item) { - if ($item['id'] == $resource->get_id() && - isset($item['type']) && $item['type'] == $resource->get_type() - ) { - return true; - } - } - return false; - } + /** + * Check if a given resource is used as an item in this chapter + */ + function has_item($resource) + { + foreach ($this->items as $item) { + if ($item['id'] == $resource->get_id() && + isset($item['type']) && $item['type'] == $resource->get_type() + ) { + return true; + } + } + return false; + } - /** - * Show this learnpath - */ - function show() { - parent::show(); - echo $this->name; - } + /** + * Show this learnpath + */ + function show() + { + parent::show(); + echo $this->name; + } } diff --git a/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/CourseCopyTestCategory.php b/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/CourseCopyTestCategory.php index 8d004162e7..9ea6ea7ec1 100644 --- a/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/CourseCopyTestCategory.php +++ b/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/CourseCopyTestCategory.php @@ -35,7 +35,7 @@ class CourseCopyTestCategory extends Resource /** * Show the test_category title, used in the partial recycle_course.php form */ - function show() + public function show() { parent::show(); echo $this->title; diff --git a/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/Forum.php b/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/Forum.php index 4ce1e8afb5..170b78a44e 100644 --- a/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/Forum.php +++ b/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/Forum.php @@ -117,5 +117,4 @@ class Forum extends Resource parent::show(); echo $this->obj->forum_title; } - } diff --git a/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/QuizQuestion.php b/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/QuizQuestion.php index 6ba94bf277..21d666eb8b 100644 --- a/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/QuizQuestion.php +++ b/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/QuizQuestion.php @@ -97,6 +97,14 @@ class QuizQuestion extends Resource /** * Add an answer to this QuizQuestion + * @param int $answer_id + * @param string $answer_text + * @param string $correct + * @param string $comment + * @param string $ponderation + * @param string $position + * @param string $hotspot_coordinates + * @param string $hotspot_type */ public function add_answer( $answer_id, diff --git a/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/ScormDocument.php b/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/ScormDocument.php index 408f8bd146..f73058d828 100644 --- a/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/ScormDocument.php +++ b/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/ScormDocument.php @@ -21,7 +21,7 @@ class ScormDocument extends Resource */ public function __construct($id, $path, $title) { - parent::__construct($id,RESOURCE_SCORM); + parent::__construct($id, RESOURCE_SCORM); $this->path = 'scorm'.$path; $this->title = $title; } diff --git a/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/Survey.php b/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/Survey.php index e3cf4251ac..3227cf625f 100644 --- a/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/Survey.php +++ b/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/Survey.php @@ -80,7 +80,7 @@ class Survey extends Resource * @param string $lang * @param string $avail_from * @param string $avail_till - * @param char $is_shared + * @param string $is_shared * @param string $template * @param string $intro * @param string $surveythanks diff --git a/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/SurveyInvitation.php b/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/SurveyInvitation.php index e9ea7b734b..ee7bc6fb40 100644 --- a/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/SurveyInvitation.php +++ b/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/SurveyInvitation.php @@ -33,7 +33,7 @@ class SurveyInvitation extends Resource /** * Create a new SurveyInvitation - * @param int $id + * @param int $id * @param string $code * @param string $user * @param string $invitation_code diff --git a/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/SurveyQuestion.php b/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/SurveyQuestion.php index 2260b406c8..098aa084dc 100644 --- a/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/SurveyQuestion.php +++ b/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/SurveyQuestion.php @@ -47,15 +47,15 @@ class SurveyQuestion extends Resource /** * Create a new SurveyQuestion - * @param int $id - * @param int $survey_id + * @param int $id + * @param int $survey_id * @param string $survey_question * @param string $survey_question_comment * @param string $type * @param string $display - * @param int $sort - * @param int $shared_question_id - * @param int $max_value + * @param int $sort + * @param int $shared_question_id + * @param int $max_value */ public function __construct( $id, @@ -83,7 +83,7 @@ class SurveyQuestion extends Resource /** * Add an answer option to this SurveyQuestion * @param string $option_text - * @param int $sort + * @param int $sort */ public function add_answer($option_text,$sort) { diff --git a/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/ToolIntro.php b/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/ToolIntro.php index 00e8f2a251..a3b2b82e54 100644 --- a/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/ToolIntro.php +++ b/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/ToolIntro.php @@ -35,8 +35,7 @@ class ToolIntro extends Resource public function show() { parent::show(); - switch ($this->id) - { + switch ($this->id) { case TOOL_DOCUMENT: $lang_id = 'Documents'; break; diff --git a/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/Wiki.php b/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/Wiki.php index 7ae6433e78..b6bb7a09d7 100644 --- a/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/Wiki.php +++ b/src/Chamilo/CourseBundle/Component/CourseCopy/Resources/Wiki.php @@ -47,7 +47,7 @@ class Wiki extends Resource $progress, $version ) { - parent::__construct($id,RESOURCE_WIKI); + parent::__construct($id, RESOURCE_WIKI); $this->id = $id; $this->page_id = $page_id; $this->reflink = $reflink; diff --git a/src/Chamilo/CourseBundle/Entity/CToolIntro.php b/src/Chamilo/CourseBundle/Entity/CToolIntro.php index d37bd4cc3c..e3b9750216 100644 --- a/src/Chamilo/CourseBundle/Entity/CToolIntro.php +++ b/src/Chamilo/CourseBundle/Entity/CToolIntro.php @@ -94,7 +94,7 @@ class CToolIntro /** * Get id * - * @return string + * @return integer */ public function getId() { diff --git a/tests/behat/features/bootstrap/FeatureContext.php b/tests/behat/features/bootstrap/FeatureContext.php index 74dceace86..de7353e21f 100644 --- a/tests/behat/features/bootstrap/FeatureContext.php +++ b/tests/behat/features/bootstrap/FeatureContext.php @@ -27,6 +27,7 @@ class FeatureContext extends MinkContext $this->pressButton('submitAuth'); $this->getSession()->back(); } + /** * @Given /^I am a session administrator$/ */ @@ -40,6 +41,7 @@ class FeatureContext extends MinkContext ])); $this->pressButton('submitAuth'); } + /** * @Given /^I am a teacher$/ */ @@ -51,6 +53,7 @@ class FeatureContext extends MinkContext $this->fillField('password', 'mmosquera'); $this->pressButton('submitAuth'); } + /** * @Given /^I am a teacher in course "([^"]*)"$/ * @Todo implement @@ -61,6 +64,7 @@ class FeatureContext extends MinkContext //$result = ... //if ($result !== false) { ... } } + /** * @Given /^I am a student$/ */ @@ -68,10 +72,11 @@ class FeatureContext extends MinkContext { $this->visit('/index.php?logout=logout'); $this->iAmOnHomepage(); - $this->fillField('login', 'mbrandybuck'); - $this->fillField('password', 'mbrandybuck'); + $this->fillField('login', 'acostea'); + $this->fillField('password', 'acostea'); $this->pressButton('submitAuth'); } + /** * @Given /^I am an HR manager$/ */ @@ -83,6 +88,7 @@ class FeatureContext extends MinkContext $this->fillField('password', 'ptook'); $this->pressButton('submitAuth'); } + /** * @Given /^I am a student boss$/ */ @@ -94,6 +100,7 @@ class FeatureContext extends MinkContext $this->fillField('password', 'abaggins'); $this->pressButton('submitAuth'); } + /** * @Given /^I am an invitee$/ */ @@ -105,6 +112,7 @@ class FeatureContext extends MinkContext $this->fillField('password', 'bproudfoot'); $this->pressButton('submitAuth'); } + /** * @Given /^course "([^"]*)" exists$/ */ @@ -114,6 +122,7 @@ class FeatureContext extends MinkContext $this->visit('/main/admin/course_list.php?keyword=' . $argument); $this->assertPageContainsText($argument); } + /** * @Given /^course "([^"]*)" is deleted$/ */ @@ -123,6 +132,7 @@ class FeatureContext extends MinkContext $this->visit('/main/admin/course_list.php?keyword=' . $argument); $this->clickLink('Delete'); } + /** * @Given /^I am in course "([^"]*)"$/ * @Todo redefine function to be different from I am on course TEMP homepage @@ -132,6 +142,7 @@ class FeatureContext extends MinkContext $this->visit('/main/course_home/course_home.php?cDir=' . $argument); $this->assertElementNotOnPage('.alert-danger'); } + /** * @Given /^I am on course "([^"]*)" homepage$/ */ @@ -140,6 +151,7 @@ class FeatureContext extends MinkContext $this->visit('/main/course_home/course_home.php?cDir=' . $argument); $this->assertElementNotOnPage('.alert-danger'); } + /** * @Given /^I am a "([^"]*)" user$/ */ @@ -243,6 +255,7 @@ class FeatureContext extends MinkContext $this->selectOption('show_admin_toolbar', 'do_not_show'); $this->pressButton('submit'); } + /** * @Given /^Admin top bar is enabled$/ */ @@ -277,8 +290,8 @@ class FeatureContext extends MinkContext } /** - * @Then /^I fill in ckeditor field "([^"]*)" with "([^"]*)"$/ - */ + * @Then /^I fill in ckeditor field "([^"]*)" with "([^"]*)"$/ + */ public function iFillInWysiwygOnFieldWith($locator, $value) { // Just in case wait that ckeditor is loaded diff --git a/tests/behat/features/profile.feature b/tests/behat/features/profile.feature new file mode 100644 index 0000000000..18a16afe98 --- /dev/null +++ b/tests/behat/features/profile.feature @@ -0,0 +1,20 @@ +Feature: Profile page + A student should update his profile information. + + Background: + Given I am a student + + Scenario: Update profile with first name Andrew then restore Andrea + Given I am on "/main/auth/profile.php" + When I fill in the following: + | firstname | Andrew | + And I press "Save settings" + And wait for the page to be loaded + Then I should see "Your new profile has been saved" + And I should see "Andrew" + Then I fill in the following: + | firstname | Andrea | + And I press "Save settings" + Then I should see "Your new profile has been saved" + Then I am on "/main/social/home.php" + Then I should see "Andrea" \ No newline at end of file diff --git a/tests/behat/features/registration.feature b/tests/behat/features/registration.feature new file mode 100644 index 0000000000..8d01a9f100 --- /dev/null +++ b/tests/behat/features/registration.feature @@ -0,0 +1,20 @@ +Feature: User registration + In order to enter the system + I need to be able to create my account + + Scenario: Enter the registration form + Given I am on the homepage + Then I should see "Sign up" + Then I follow "Sign up!" + Then I should see "Registration" + And I fill in the following: + | firstname | user registration first name | + | lastname | user registration last name | + | email | user-registration@example.com | + | official_code | user registration | + | username | user_registration | + | pass1 | user-registration | + | pass2 | user-registration | + And I press "Register" + And wait for the page to be loaded + Then I should see "Your personal settings have been registered"