Gradebook: fix percentage that where always set for categories when using exercise score model - refs BT#22011

main/gradebook/lib/gradebook_data_generator.class.php

@@ -356,6 +356,10 @@ class GradebookDataGenerator
                     $row[] = $result['display'];
                     $row['result_score'] = $result['score'];
                     $row['result_score_weight'] = $result['score'];
+                    $showPercentage = true;
+                    if ($this->hidePercentage) {
+                        $showPercentage = false;
+                    }
 
                     if (empty($model)) {
                         // Best
@@ -363,7 +367,7 @@ class GradebookDataGenerator
                             $best = $defaultData[$item->get_id()]['best'];
                             if ($useExerciseScoreInTotal) {
                                 $bestScore = $best['score'];
-                                $best['display'] = ExerciseLib::show_score($bestScore[0], $bestScore[1], true);
+                                $best['display'] = ExerciseLib::show_score($bestScore[0], $bestScore[1], $showPercentage);
                             } else {
                                 $best = $defaultData[$item->get_id()]['best'];
                             }
@@ -380,7 +384,7 @@ class GradebookDataGenerator
                             $average = $defaultData[$item->get_id()]['average'];
                             if ($useExerciseScoreInTotal) {
                                 $averageScore = $average['score'];
-                                $average['display'] = ExerciseLib::show_score($averageScore[0], $averageScore[1], true);
+                                $average['display'] = ExerciseLib::show_score($averageScore[0], $averageScore[1], $showPercentage);
                             }
                         } else {
                             $average = $this->buildAverageResultColumn($item, $useExerciseScoreInTotal);