From ba0e253e24eb526e2eadc263b66f1e951745c19e Mon Sep 17 00:00:00 2001
From: Yannick Warnier <ywarnier@beeznest.org>
Date: Tue, 10 Jul 2018 17:51:37 -0500
Subject: [PATCH] Add JS confirmation popup on course description delete icon -
 refs #2583

---
 .../course_description_controller.php            | 16 +++++++++++++++-
 .../default/course_description/index.tpl         | 11 +++++------
 2 files changed, 20 insertions(+), 7 deletions(-)

diff --git a/main/course_description/course_description_controller.php b/main/course_description/course_description_controller.php
index e56d007d1d..942b1f2fb8 100644
--- a/main/course_description/course_description_controller.php
+++ b/main/course_description/course_description_controller.php
@@ -52,13 +52,27 @@ class CourseDescriptionController
             $data['descriptions'] = [$data['descriptions']];
         }
 
-        foreach ($data['descriptions'] as $description) {
+        // Prepare confirmation code for item deletion
+        global $htmlHeadXtra;
+        $htmlHeadXtra[] = "<script>
+        function confirmation(name) {
+            if (confirm(\" ".trim(get_lang('AreYouSureToDeleteJS'))." \"+name+\"?\")) {
+                return true;
+            } else {
+                return false;
+            }
+        }
+        </script>";
+
+        foreach ($data['descriptions'] as $id => $description) {
             if (!empty($description['content'])
                 && strpos($description['content'], '<iframe') !== false
                 && $browser['name'] == 'Chrome'
             ) {
                 header("X-XSS-Protection: 0");
             }
+            // Add an escape version for the JS code of delete confirmation
+            $data['descriptions'][$id]['title_js'] = addslashes($description['title']);
         }
         $actions = null;
         $actionLeft = null;
diff --git a/main/template/default/course_description/index.tpl b/main/template/default/course_description/index.tpl
index 87fc67b1ad..22b092298a 100755
--- a/main/template/default/course_description/index.tpl
+++ b/main/template/default/course_description/index.tpl
@@ -9,16 +9,15 @@
                 {% if is_allowed_to_edit %}
                     <div class="pull-right">
                         {% if session_id == description.session_id %}
-                            <a href="{{ _p.web_self }}?action=delete&amp;id={{ description.id }}&amp;{{ _p.web_cid_query }}"
-                               onclick="delete_entry('description_{{ description.id }}', this); return false;"
-                               title="{{ 'Delete'|get_lang }}">
-                                <img src="{{ 'delete.png'|icon(22) }}"/>
-                            </a>
-
                             <a href="{{ _p.web_self }}?action=edit&amp;id={{ description.id }}&amp;{{ _p.web_cid_query }}"
                                title="{{ 'Edit'|get_lang }}">
                                 <img src="{{ 'edit.png'|icon(22) }}"/>
                             </a>
+                            <a href="{{ _p.web_self }}?action=delete&amp;id={{ description.id }}&amp;{{ _p.web_cid_query }}"
+                               onclick="javascript:return confirmation('{{ description.title_js }}');"
+                               title="{{ 'Delete'|get_lang }}">
+                                <img src="{{ 'delete.png'|icon(22) }}"/>
+                            </a>
                         {% else %}
                             <img title="{{ 'EditionNotAvailableFromSession'|get_lang }}"
                                  alt="{{ 'EditionNotAvailableFromSession'|get_lang }}"