diff --git a/main/inc/lib/course.lib.php b/main/inc/lib/course.lib.php index eca6ec5c69..58bd70a013 100644 --- a/main/inc/lib/course.lib.php +++ b/main/inc/lib/course.lib.php @@ -1,27 +1,8 @@ - 0) { return false; // the user is already subscribed to the course } else { @@ -434,10 +416,10 @@ class CourseManager } else { $course_sort = CourseManager :: userCourseSort($user_id,$course_code); $add_course_user_entry_sql = "INSERT INTO ".$course_user_table." - SET `course_code` = '$course_code', - `user_id` = '$user_id', - `status` = '".$status."', - `sort` = '". ($course_sort)."'"; + SET course_code = '$course_code', + user_id = '$user_id', + status = '".$status."', + sort = '". ($course_sort)."'"; $result = @api_sql_query($add_course_user_entry_sql, __FILE__, __LINE__); } if ($result) { @@ -467,59 +449,45 @@ class CourseManager $user_table = Database :: get_main_table(TABLE_MAIN_USER); $course_table = Database :: get_main_table(TABLE_MAIN_COURSE); $course_user_table = Database :: get_main_table(TABLE_MAIN_COURSE_USER); - $status = ($status == STUDENT || $status == COURSEMANAGER) ? $status : STUDENT; - if (empty($user_id) || empty ($course_code)) - { + + if (empty($user_id) || empty ($course_code) || ($user_id != strval(intval($user_id)))) { return false; - } - else - { + } else { + $course_code = Database::escape_string($course_code); // previously check if the user are already registered on the platform $handle = api_sql_query("SELECT status FROM ".$user_table." - WHERE `user_id` = '$user_id' ", __FILE__, __LINE__); - if (Database::num_rows($handle) == 0) - { + WHERE user_id = '$user_id' ", __FILE__, __LINE__); + if (Database::num_rows($handle) == 0) { return false; // the user isn't registered to the platform - } - else - { + } else { //check if user isn't already subscribed to the course $handle = api_sql_query("SELECT * FROM ".$course_user_table." - WHERE `user_id` = '$user_id' - AND `course_code` ='$course_code'", __FILE__, __LINE__); - if (Database::num_rows($handle) > 0) - { + WHERE user_id = '$user_id' + AND course_code ='$course_code'", __FILE__, __LINE__); + if (Database::num_rows($handle) > 0) { return false; // the user is already subscribed to the course - } - else - { + } else { // previously check if subscription is allowed for this course $handle = api_sql_query("SELECT code, visibility FROM ".$course_table." - WHERE `code` = '$course_code' - AND `subscribe` = '".SUBSCRIBE_NOT_ALLOWED."'", __FILE__, __LINE__); + WHERE code = '$course_code' + AND subscribe = '".SUBSCRIBE_NOT_ALLOWED."'", __FILE__, __LINE__); - if (Database::num_rows($handle) > 0) - { + if (Database::num_rows($handle) > 0) { return false; // subscription not allowed for this course - } - else - { + } else { $max_sort = api_max_sort_value('0', $user_id); $add_course_user_entry_sql = "INSERT INTO ".$course_user_table." - SET `course_code` = '$course_code', - `user_id` = '$user_id', - `status` = '".$status."', - `sort` = '". ($max_sort +1)."'"; + SET course_code = '$course_code', + user_id = '$user_id', + status = '".$status."', + sort = '". ($max_sort +1)."'"; $result=api_sql_query($add_course_user_entry_sql, __FILE__, __LINE__); - if ($result) - { + if ($result) { return true; - } - else - { + } else { return false; } } @@ -546,26 +514,19 @@ class CourseManager */ function get_real_course_code_select_html($element_name, $has_size = true, $only_current_user_courses = true, $user_id) { - if ($only_current_user_courses == true) - { + if ($only_current_user_courses == true) { $real_course_list = CourseManager :: get_real_course_list_of_user_as_course_admin($user_id); - } - else - { + } else { $real_course_list = CourseManager :: get_real_course_list(); } - if ($has_size == true) - { + if ($has_size == true) { $size_element = "size=\"".SELECT_BOX_SIZE."\""; - } - else - { + } else { $size_element = ""; } $html_code = "