From c85ea87e92197146f2a8df5a42ea0fb2cf914f25 Mon Sep 17 00:00:00 2001 From: jmontoyaa Date: Tue, 8 Aug 2017 11:57:44 +0200 Subject: [PATCH] Minor - format code, fix PHP warning --- plugin/courseblock/CourseBlockPlugin.php | 2 +- plugin/customfooter/plugin.php | 13 +++++++------ plugin/grading_electronic/generate.php | 3 ++- plugin/grading_electronic/lang/english.php | 2 +- 4 files changed, 11 insertions(+), 9 deletions(-) diff --git a/plugin/courseblock/CourseBlockPlugin.php b/plugin/courseblock/CourseBlockPlugin.php index 2f34bde359..c62a476052 100644 --- a/plugin/courseblock/CourseBlockPlugin.php +++ b/plugin/courseblock/CourseBlockPlugin.php @@ -66,7 +66,7 @@ class CourseBlockPlugin extends Plugin $this->uninstall_course_fields_in_all_courses(); } - /** + /** * @param string $region * @return string */ diff --git a/plugin/customfooter/plugin.php b/plugin/customfooter/plugin.php index b59bb517fe..1a839c3cf9 100644 --- a/plugin/customfooter/plugin.php +++ b/plugin/customfooter/plugin.php @@ -1,18 +1,19 @@ Plugins) * @package chamilo.plugin * @author Julio Montoya */ -require_once __DIR__.'/lib/customfooter_plugin.class.php'; /** * Plugin details (must be present) */ /* Plugin config */ +$plugin_info = CustomFooterPlugin::create()->get_info(); //the plugin title $plugin_info['title'] = 'Custom Footer'; @@ -35,7 +36,9 @@ $form = new FormValidator('customfooter_form'); $plugininstance = CustomFooterPlugin::create(); -$config = api_get_settings_params(array('subkey = ? ' => 'customfooter', ' AND category = ? ' => 'Plugins')); +$config = api_get_settings_params( + array('subkey = ? ' => 'customfooter', ' AND category = ? ' => 'Plugins') +); $form_settings = []; foreach ($config as $fooid => $configrecord) { @@ -48,9 +51,7 @@ foreach ($config as $fooid => $configrecord) { // A simple select. $form->addElement('text', 'footer_left', $plugininstance->get_lang('footerleft')); $form->addElement('text', 'footer_right', $plugininstance->get_lang('footerright')); - $form->addButtonSave($plugininstance->get_lang('Save')); - $form->setDefaults($form_settings); -$plugin_info['settings_form'] = $form; \ No newline at end of file +$plugin_info['settings_form'] = $form; diff --git a/plugin/grading_electronic/generate.php b/plugin/grading_electronic/generate.php index 142835b4b3..7b1141face 100644 --- a/plugin/grading_electronic/generate.php +++ b/plugin/grading_electronic/generate.php @@ -65,13 +65,14 @@ try { GradingElectronicPlugin::EXTRAFIELD_COURSE_HOURS ); + $students = []; + if ($session) { $criteria = Criteria::create()->where( Criteria::expr()->eq('relationType', Session::STUDENT) ); $subscriptions = $session->getUsers()->matching($criteria); - $students = []; /** @var SessionRelUser $subscription */ foreach ($subscriptions as $subscription) { diff --git a/plugin/grading_electronic/lang/english.php b/plugin/grading_electronic/lang/english.php index b155f098e0..b2891b6106 100644 --- a/plugin/grading_electronic/lang/english.php +++ b/plugin/grading_electronic/lang/english.php @@ -7,7 +7,7 @@ $strings['plugin_comment'] = 'This plugin create a text file with information ab $strings['tool_enable'] = 'Enable tool'; $strings['tool_enable_help'] = ' Allow add the Generate File button in the Assessments page. - You nee assign the content_top region. + You need assign the content_top region. '; $strings['PluginDisabled'] = 'Grading Electronic is disabed';