Fix Model::get_all implementations

public/main/inc/lib/ScheduledAnnouncement.php

@@ -26,12 +26,7 @@ class ScheduledAnnouncement extends Model
         $this->table = 'scheduled_announcements';
     }
 
-    /**
-     * @param array $options
-     *
-     * @return array
-     */
-    public function get_all($options = [])
+    public function get_all(array $options = []): array
     {
         return Database::select(
             '*',

public/main/inc/lib/career.lib.php

@@ -39,12 +39,7 @@ class Career extends Model
         return $row['count'];
     }
 
-    /**
-     * @param array $options
-     *
-     * @return array
-     */
-    public function get_all($options = [])
+    public function get_all(array $options = []): array
     {
         return Database::select(
             '*',

public/main/inc/lib/extra_field.lib.php

@@ -882,14 +882,15 @@ class ExtraField extends Model
     /**
      * Get an array of all the values from the extra_field and extra_field_options tables
      * based on the current object's type.
-     *
-     * @param array $options
-     * @param null  $order_field_options_by
-     *
-     * @return array
      */
-    public function get_all($options = [], $order_field_options_by = null)
+    public function get_all(array $options = []): array
     {
+        $order_field_options_by = null;
+
+        if (func_num_args() > 1) {
+            $order_field_options_by = func_get_arg(1);
+        }
+
         $options = Database::parse_conditions(['where' => $options]);
 
         if (empty($options)) {

public/main/inc/lib/extra_field_option.lib.php

@@ -867,12 +867,7 @@ class ExtraFieldOption extends Model
         return $info;
     }
 
-    /**
-     * @param null $options
-     *
-     * @return array
-     */
-    public function get_all($options = null)
+    public function get_all(array $options = []): array
     {
         $result = parent::get_all($options);
 

public/main/inc/lib/grade_model.lib.php

@@ -18,12 +18,7 @@ class GradeModel extends Model
         $this->table = Database::get_main_table(TABLE_GRADE_MODEL);
     }
 
-    /**
-     * @param array $options
-     *
-     * @return array
-     */
-    public function get_all($options = [])
+    public function get_all(array $options = []): array
     {
         return Database::select(
             '*',

public/main/inc/lib/gradebook.lib.php

@@ -71,12 +71,7 @@ class Gradebook extends Model
         return '1' == $item['visibility'];
     }
 
-    /**
-     * @param array $options
-     *
-     * @return array
-     */
-    public function get_all($options = [])
+    public function get_all(array $options = []): array
     {
         $gradebooks = parent::get_all($options);
         foreach ($gradebooks as &$gradebook) {

public/main/inc/lib/model.lib.php

@@ -100,12 +100,7 @@ class Model
         );
     }
 
-    /**
-     * @param array $options
-     *
-     * @return array
-     */
-    public function get_all($options = null)
+    public function get_all(array $options = []): array
     {
         return Database::select('*', $this->table, $options);
     }