From d4db223f9fb0dbddd9e9f5f9f4d46ee725fc5d7a Mon Sep 17 00:00:00 2001 From: Angel Fernando Quiroz Campos Date: Thu, 28 Oct 2021 11:00:34 -0500 Subject: [PATCH] Minor: Flint fixes --- main/cron/import_csv.php | 2 +- main/inc/lib/exercise.lib.php | 2 -- main/lp/learnpath.class.php | 4 +--- main/webservices/api/v2.php | 2 +- .../CourseBundle/Component/CourseCopy/CourseBuilder.php | 1 - 5 files changed, 3 insertions(+), 8 deletions(-) diff --git a/main/cron/import_csv.php b/main/cron/import_csv.php index 01c23e72e2..7e2a9367c0 100755 --- a/main/cron/import_csv.php +++ b/main/cron/import_csv.php @@ -1867,7 +1867,7 @@ class ImportCsv 'value' => $row['SkillsetID'], ]; $extraFieldValues->save($params);*/ - $skillSetList[$row['SkillsetID']][] = $skill->getId(); + $skillSetList[$row['SkillsetID']][] = $skill->getId(); } //$courseRelSkills = []; diff --git a/main/inc/lib/exercise.lib.php b/main/inc/lib/exercise.lib.php index 99a9aefc0a..1351fb39fa 100644 --- a/main/inc/lib/exercise.lib.php +++ b/main/inc/lib/exercise.lib.php @@ -2254,7 +2254,6 @@ HOTSPOT; $status ); - if (!empty($result)) { foreach ($result as $attempt) { $data = [ @@ -2412,7 +2411,6 @@ HOTSPOT; } $session_id_and = " AND te.session_id IN(".implode(',', $sessionIds).")"; $sessionCondition = " AND ttte.session_id IN(".implode(',', $sessionIds).")"; - } else { return false; } diff --git a/main/lp/learnpath.class.php b/main/lp/learnpath.class.php index b03e7b6b2f..5fe05e9d55 100755 --- a/main/lp/learnpath.class.php +++ b/main/lp/learnpath.class.php @@ -4982,8 +4982,7 @@ class learnpath } /** - * Update the last progress only in case - * + * Update the last progress only in case. */ public function updateLpProgress() { @@ -5023,7 +5022,6 @@ class learnpath ->hookLearningPathEnd(); } } - } /** diff --git a/main/webservices/api/v2.php b/main/webservices/api/v2.php index 5d882e9a06..98f42ebcc0 100644 --- a/main/webservices/api/v2.php +++ b/main/webservices/api/v2.php @@ -487,7 +487,7 @@ try { $userId = isset($_POST['user_id']) ? (int) $_POST['user_id'] : 0; $currentApiKey = $_POST['current_api_key'] ?? ''; - if (empty($userId) || empty($currentApiKey)) { + if (empty($userId) || empty($currentApiKey)) { throw new Exception(get_lang('NotAllowed')); } diff --git a/src/Chamilo/CourseBundle/Component/CourseCopy/CourseBuilder.php b/src/Chamilo/CourseBundle/Component/CourseCopy/CourseBuilder.php index 7da0cb9a2c..93f24f97fe 100644 --- a/src/Chamilo/CourseBundle/Component/CourseCopy/CourseBuilder.php +++ b/src/Chamilo/CourseBundle/Component/CourseCopy/CourseBuilder.php @@ -1572,7 +1572,6 @@ class CourseBuilder */ public function exportToCourseBuildFormat() { - if (empty($this->itemListToAdd)) { return false; }