Fixing PHP Warnings

main/coursecopy/classes/CourseArchiver.class.php

@@ -89,7 +89,7 @@ class CourseArchiver
         }
 
         // Copy all scorm documents to the temp-dir
-        if (is_array($course->resources[RESOURCE_SCORM])) {
+        if (isset($course->resources[RESOURCE_SCORM]) && is_array($course->resources[RESOURCE_SCORM])) {
             foreach ($course->resources[RESOURCE_SCORM] as $id => $document) {
                 $doc_dir = dirname($backup_dir . $document->path);
                 @mkdir($doc_dir, $perm_dirs, true);
@@ -97,16 +97,16 @@ class CourseArchiver
             }
         }
 
-        //Copy calendar attachments
+        // Copy calendar attachments
 
-        if (is_array($course->resources[RESOURCE_EVENT])) {
+        if (isset($course->resources[RESOURCE_EVENT]) && is_array($course->resources[RESOURCE_EVENT])) {
             $doc_dir = dirname($backup_dir . '/upload/calendar/');
             @mkdir($doc_dir, $perm_dirs, true);
             FileManager::copyDirTo($course->path . 'upload/calendar/', $doc_dir, false);
         }
 
         //Copy learningpath author image
-        if (is_array($course->resources[RESOURCE_LEARNPATH])) {
+        if (isset($course->resources[RESOURCE_LEARNPATH]) && is_array($course->resources[RESOURCE_LEARNPATH])) {
             $doc_dir = dirname($backup_dir . '/upload/learning_path/');
             @mkdir($doc_dir, $perm_dirs, true);
             FileManager::copyDirTo($course->path . 'upload/learning_path/', $doc_dir, false);
@@ -114,7 +114,7 @@ class CourseArchiver
 
         //Copy announcements attachments
 
-        if (is_array($course->resources[RESOURCE_ANNOUNCEMENT])) {
+        if (isset($course->resources[RESOURCE_ANNOUNCEMENT]) && is_array($course->resources[RESOURCE_ANNOUNCEMENT])) {
             $doc_dir = dirname($backup_dir . '/upload/announcements/');
             @mkdir($doc_dir, $perm_dirs, true);
             FileManager::copyDirTo($course->path . 'upload/announcements/', $doc_dir, false);

main/coursecopy/create_backup.php

@@ -76,7 +76,7 @@ if ((isset($_POST['action']) && $_POST['action'] == 'course_select_form') || (is
         echo get_lang('NoResourcesToBackup');
     } else {
 
-        $form = new FormValidator('create_backup_form', 'post');
+        $form = new FormValidator('create_backup_form', 'post', api_get_self().'?'.api_get_cidreq());
         $form->addElement('header', get_lang('SelectOptionForBackup'));
 
         $form->addElement('radio', 'backup_option', '', get_lang('CreateFullBackup'), 'full_backup');

main/newscorm/lp_add.php

@@ -29,6 +29,10 @@ $language_file = 'learnpath';
 /* Header and action code */
 
 $currentstyle = api_get_setting('stylesheets');
+
+$showImg = Display::return_icon('div_show.gif');
+$hideImg = Display::return_icon('div_hide.gif');
+
 $htmlHeadXtra[] = '<script>
 function setFocus(){
     $("#learnpath_title").focus();
@@ -41,10 +45,10 @@ $(document).ready(function () {
 function advanced_parameters() {
     if(document.getElementById(\'options\').style.display == \'none\') {
         document.getElementById(\'options\').style.display = \'block\';
-        document.getElementById(\'img_plus_and_minus\').innerHTML=\'&nbsp;<img style="vertical-align:middle;" src="../img/div_hide.gif" alt="" />&nbsp;'.get_lang('AdvancedParameters').'\';
+        document.getElementById(\'img_plus_and_minus\').innerHTML=\'&nbsp;'.$hideImg.'&nbsp;'.get_lang('AdvancedParameters').'\';
     } else {
         document.getElementById(\'options\').style.display = \'none\';
-        document.getElementById(\'img_plus_and_minus\').innerHTML=\'&nbsp;<img style="vertical-align:middle;" src="../img/div_show.gif" alt="" />&nbsp;'.get_lang('AdvancedParameters').'\';
+        document.getElementById(\'img_plus_and_minus\').innerHTML=\'&nbsp;'.$showImg.'&nbsp;'.get_lang('AdvancedParameters').'\';
     }
 }
 
@@ -127,7 +131,7 @@ $form->addRule('lp_name', get_lang('ThisFieldIsRequired'), 'required');
 $form->addElement('hidden', 'post_time', time());
 $form->addElement('hidden', 'action', 'add_lp');
 
-$advanced = '<a href="javascript://" onclick=" return advanced_parameters()"><span id="img_plus_and_minus"><div style="vertical-align:top;" ><img style="vertical-align:middle;" src="../img/div_show.gif" alt="" />&nbsp;'.get_lang('AdvancedParameters').'</div></span></a>';
+$advanced = '<a href="javascript://" onclick=" return advanced_parameters()"><span id="img_plus_and_minus"><div style="vertical-align:top;" >&nbsp;'.$showImg.'&nbsp;'.get_lang('AdvancedParameters').'</div></span></a>';
 $form -> addElement('advanced_settings',$advanced);
 $form -> addElement('html','<div id="options" style="display:none">');
 
@@ -163,4 +167,4 @@ $form->addElement('style_submit_button', 'Submit',get_lang('CreateLearningPath')
 
 $form->display();
 // Footer
-Display::display_footer();
+Display::display_footer();

src/ChamiloLMS/Controller/LegacyController.php

@@ -83,6 +83,8 @@ class LegacyController extends CommonController
             $charset = 'UTF-8';
             $debug = $app['debug'];
             $text_dir = api_get_text_direction();
+            $is_platformAdmin = api_is_platform_admin();
+            $_cid = api_get_course_id();
 
             // Loading file
             ob_start();