Fixing gradebook actions showed to students

main/gradebook/lib/fe/gradebooktable.class.php

@@ -176,7 +176,8 @@ class GradebookTable extends SortableTable {
 			if (api_is_allowed_to_edit(null, true)) {
                 //id
 				$row[] = $this->build_id_column($item);
-			}		
+			}
+            
             //Type
 			$row[] = $this->build_type_column($item);
 			
@@ -230,7 +231,7 @@ class GradebookTable extends SortableTable {
 			} else {
 				//students get the results and certificates columns                
 				if (count($this->evals_links) > 0 && $status_user != 1) {                    
-					$value_data = isset($data[4]) ? $data[4] : null;
+					$value_data = isset($data[4]) ? $data[4] : null;                    
 					if (!is_null($value_data)) {                        
 						$row[] = Display::tag('h4', $value_data);
 					} else {                        
@@ -315,7 +316,7 @@ class GradebookTable extends SortableTable {
                     
                     $row[] = $invisibility_span_open.$weight.$extra.$invisibility_span_close;
 					
-					if (api_is_allowed_to_edit(null, true)) {						
+					if (api_is_allowed_to_edit(null, true)) {					
 						//$weight_total_links += intval($data[3]);
 					} else {
 						$cattotal   = Category :: load($_GET['selectcat']);
@@ -577,7 +578,7 @@ class GradebookTable extends SortableTable {
 		}
 	}
 	
-	private function build_edit_column($item) {
+	private function build_edit_column($item) {        
 		switch ($item->get_item_type()) {
 			// category
 			case 'C' :

main/gradebook/lib/gradebook_functions.inc.php

@@ -292,15 +292,22 @@ function build_edit_icons_link($link, $selectcat) {
 	$cat = new Category();
 	$message_link = $cat->show_message_resource_delete($link->get_course_code());    
     $is_locked = $link->is_locked();
-        
-	if ($message_link===false) {
-		$visibility_icon= ($link->is_visible() == 0) ? 'invisible' : 'visible';
-		$visibility_command= ($link->is_visible() == 0) ? 'set_visible' : 'set_invisible';
+    
+    $modify_icons = null;
+            
+    if (!api_is_allowed_to_edit(null, true)) {
+        return null;
+    }
+    
+	if ($message_link === false) {
+		$visibility_icon    = ($link->is_visible() == 0) ? 'invisible' : 'visible';
+		$visibility_command = ($link->is_visible() == 0) ? 'set_visible' : 'set_invisible';
         
         if ($is_locked && !api_is_platform_admin()) {
             $modify_icons = Display::return_icon('edit_na.png', get_lang('Modify'),'',ICON_SIZE_SMALL);
-        } else {
-            $modify_icons = '<a href="gradebook_edit_link.php?editlink='.$link->get_id().'&amp;cidReq='.$link->get_course_code().'">'.Display::return_icon('edit.png', get_lang('Modify'),'',ICON_SIZE_SMALL).'</a>';
+        } else {            
+            $modify_icons = '<a href="gradebook_edit_link.php?editlink='.$link->get_id().'&amp;cidReq='.$link->get_course_code().'">'.
+                                 Display::return_icon('edit.png', get_lang('Modify'),'',ICON_SIZE_SMALL).'</a>';            
         }
 
 		//$modify_icons .= '&nbsp;<a href="' . api_get_self() . '?movelink=' . $link->get_id() . '&selectcat=' . $selectcat . '"><img src="../img/deplacer_fichier.gif" border="0" title="' . get_lang('Move') . '" alt="" /></a>';