Task #1297 - "Forums" tool: Removing prepare4display() calls from places where they should not be applied.

main/forum/forumfunction.inc.php

@@ -2020,8 +2020,8 @@ function show_add_post_form($action = '', $id = '', $form_values = '') {
     if (!empty($form_values)) {
         $defaults['post_title'] = prepare4display($form_values['post_title']);
         $defaults['post_text'] = prepare4display($form_values['post_text']);
-        $defaults['post_notification'] = prepare4display($form_values['post_notification']);
-        $defaults['thread_sticky'] = prepare4display($form_values['thread_sticky']);
+        $defaults['post_notification'] = strval(intval($form_values['post_notification']));
+        $defaults['thread_sticky'] = strval(intval($form_values['thread_sticky']));
     }
 
     // If we are quoting a message we have to retrieve the information of the post we are quoting so that

main/forum/index.php

@@ -362,7 +362,7 @@ if (is_array($forum_categories_list)) {
                         }
                         $forum['forum_of_group'] == 0 ? $groupid = '' : $groupid = $forum['forum_of_group'];
 
-                        echo '<td><a href="viewforum.php?'.api_get_cidreq().'&amp;gidReq='.intval($groupid).'&amp;forum='.intval($forum['forum_id']).'" '.class_visible_invisible(prepare4display($forum['visibility'])).'>';
+                        echo '<td><a href="viewforum.php?'.api_get_cidreq().'&amp;gidReq='.intval($groupid).'&amp;forum='.intval($forum['forum_id']).'" '.class_visible_invisible(strval(intval($forum['visibility']))).'>';
 
                         //Forum title
                         echo prepare4display($forum['forum_title']).$session_displayed.'</a>'.$forum_title_group_addition.'<br />';

main/forum/viewforumcategory.php

@@ -193,7 +193,7 @@ if ($action_forums!='add') {
     echo '<thead>';
     echo "<tr><th class=\"forum_head\" ".(api_is_allowed_to_edit(null,true)?"colspan='5'":"colspan='6'").">";
 
-    echo '<a href="viewforumcategory.php?'.api_get_cidreq().'&amp;forumcategory='.prepare4display($forum_category['cat_id']).'" '.class_visible_invisible(prepare4display($forum_category['visibility'])).'>'.prepare4display($forum_category['cat_title']).$session_displayed.'</a>'. $session_img .'<br />';
+    echo '<a href="viewforumcategory.php?'.api_get_cidreq().'&amp;forumcategory='.strval(intval($forum_category['cat_id'])).'" '.class_visible_invisible(strval(intval($forum_category['visibility']))).'>'.prepare4display($forum_category['cat_title']).$session_displayed.'</a>'. $session_img .'<br />';
 
     echo '<span class="forum_description">'.prepare4display($forum_category['cat_comment']).'</span>';