From e1e1da7937eaad8b4d1acf1efbb4d323508d4b01 Mon Sep 17 00:00:00 2001
From: jmontoyaa <gugli100@gmail.com>
Date: Fri, 7 Oct 2016 11:23:16 +0200
Subject: [PATCH] Add validation

---
 main/exercice/upload_exercise.php | 33 +++++++++++++++----------------
 1 file changed, 16 insertions(+), 17 deletions(-)

diff --git a/main/exercice/upload_exercise.php b/main/exercice/upload_exercise.php
index 630bc3dc52..b9375e9fd1 100755
--- a/main/exercice/upload_exercise.php
+++ b/main/exercice/upload_exercise.php
@@ -326,7 +326,6 @@ function lp_upload_quiz_action_handling() {
         );
 
         if ($quiz_id) {
-
             // insert into the item_property table
             api_item_property_update(
                 $_course,
@@ -499,24 +498,28 @@ function lp_upload_quiz_action_handling() {
                                 $courseId
                             );
 
-                            switch ($detectQuestionType) {
-                                case GLOBAL_MULTIPLE_ANSWER:
-                                    $questionObj->updateWeighting($globalScore);
-                                    break;
-                                case UNIQUE_ANSWER:
-                                case MULTIPLE_ANSWER:
-                                default:
-                                    $questionObj->updateWeighting($total);
-                                    break;
-                            }
+                            if ($questionObj) {
+                                switch ($detectQuestionType) {
+                                    case GLOBAL_MULTIPLE_ANSWER:
+                                        $questionObj->updateWeighting(
+                                            $globalScore
+                                        );
+                                        break;
+                                    case UNIQUE_ANSWER:
+                                    case MULTIPLE_ANSWER:
+                                    default:
+                                        $questionObj->updateWeighting($total);
+                                        break;
+                                }
 
-                            $questionObj->save();
+                                $questionObj->save();
+                            }
                         }
                         break;
                     case FREE_ANSWER:
                         $questionObj = Question::read($question_id, $courseId);
+                        $globalScore = $score_list[$i][3];
                         if ($questionObj) {
-                            $globalScore = $score_list[$i][3];
                             $questionObj->updateWeighting($globalScore);
                             $questionObj->save();
                         }
@@ -557,9 +560,7 @@ function lp_upload_quiz_action_handling() {
                         break;
                     case MATCHING:
                         $globalScore = $score_list[$i][3];
-
                         $position = 1;
-
                         $objAnswer = new Answer($question_id, $courseId);
                         foreach ($answerList as $data) {
                             $option = isset($data[3]) ? $data[3] : '';
@@ -571,7 +572,6 @@ function lp_upload_quiz_action_handling() {
                         foreach ($answerList as $data) {
                             $value = isset($data[2]) ? $data[2] : '';
                             $position++;
-
                             $objAnswer->createAnswer(
                                 $value,
                                 $counter,
@@ -589,7 +589,6 @@ function lp_upload_quiz_action_handling() {
                             $questionObj->updateWeighting($globalScore);
                             $questionObj->save();
                         }
-
                         break;
                 }
             }