Fix multiple URL when sending messages see BT#12901

main/cron/scheduled_announcement.php

@@ -5,13 +5,8 @@ require_once __DIR__.'/../inc/global.inc.php';
 
 $urlList = UrlManager::get_url_data();
 foreach ($urlList as $url) {
-    echo "Portal: ".$url['url'].PHP_EOL;
+    echo "Portal: # ".$url['id']." - ".$url['url'].PHP_EOL;
     $object = new ScheduledAnnouncement();
     $messagesSent = $object->sendPendingMessages($url['id']);
     echo "Messages sent $messagesSent".PHP_EOL;
 }
-
-
-
-
-

main/inc/lib/ScheduledAnnouncement.php

@@ -270,13 +270,22 @@ class ScheduledAnnouncement extends Model
                 if (!empty($result['date']) && $result['date'] < $now) {
                     $sessionId = $result['session_id'];
                     $sessionInfo = api_get_session_info($sessionId);
-                    self::update(['id' => $result['id'], 'sent' => 1]);
+                    if (empty($sessionInfo)) {
+                        continue;
+                    }
                     $users = SessionManager::get_users_by_session(
                         $sessionId,
                         '0',
                         false,
                         $urlId
                     );
+
+                    if (empty($users)) {
+                        continue;
+                    }
+
+                    self::update(['id' => $result['id'], 'sent' => 1]);
+
                     $subject = $result['subject'];
                     $message = $result['message'];