From e543f7b17cfad1b04c9f98c141ab496d589bf502 Mon Sep 17 00:00:00 2001 From: Julio Date: Wed, 15 Sep 2021 11:41:06 +0200 Subject: [PATCH] Minor - fix php errors --- public/main/forum/forumfunction.inc.php | 8 +++++--- src/CoreBundle/Migrations/Schema/V200/Version20.php | 1 - 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/public/main/forum/forumfunction.inc.php b/public/main/forum/forumfunction.inc.php index 9f23048ed3..bf88f69101 100644 --- a/public/main/forum/forumfunction.inc.php +++ b/public/main/forum/forumfunction.inc.php @@ -2999,9 +2999,11 @@ function newThread(CForum $forum, $form_values = '', $showPreview = true) $newThread = saveThread($forum, $values); if ($newThread) { SkillModel::saveSkills($form, ITEM_TYPE_FORUM_THREAD, $newThread->getIid()); - $postId = $newThread->getThreadLastPost(); + $post = $newThread->getThreadLastPost(); + + if ($post) { + $postId = $post->getIid(); - if ($postId) { if (isset($values['give_revision']) && 1 == $values['give_revision']) { $extraFieldValues = new ExtraFieldValue('forum_post'); $revisionLanguage = isset($values['extra_revision_language']) ? $values['extra_revision_language'] : ''; @@ -3021,7 +3023,7 @@ function newThread(CForum $forum, $form_values = '', $showPreview = true) $extraFieldValues = new ExtraFieldValue('forum_post'); $params = [ 'item_id' => $postId, - 'extra_ask_for_revision' => isset($values['extra_ask_for_revision']) ? $values['extra_ask_for_revision'] : '', + 'extra_ask_for_revision' => $values['extra_ask_for_revision'] ?? '', ]; $extraFieldValues->saveFieldValues( $params, diff --git a/src/CoreBundle/Migrations/Schema/V200/Version20.php b/src/CoreBundle/Migrations/Schema/V200/Version20.php index 94782b395a..8f809db0a8 100644 --- a/src/CoreBundle/Migrations/Schema/V200/Version20.php +++ b/src/CoreBundle/Migrations/Schema/V200/Version20.php @@ -467,7 +467,6 @@ class Version20 extends AbstractMigrationChamilo // core tables 'message' => ['user_receiver_id'], - ]; foreach ($tables as $tableName => $fields) {