From 7a56f3fbb3e5ed9b78e3341b956eef5809b4b05b Mon Sep 17 00:00:00 2001 From: Scrutinizer Auto-Fixer Date: Tue, 18 Apr 2017 08:12:22 +0000 Subject: [PATCH] Scrutinizer Auto-Fixes This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com --- custompages/first_login-dist.php | 18 +- custompages/index-unlogged-dist.php | 6 +- custompages/loggedout-dist.php | 2 +- custompages/lostpassword-dist.php | 4 +- custompages/registration-dist.php | 2 +- custompages/registration-feedback-dist.php | 4 +- main/admin/cli.php | 2 +- main/admin/extra_fields.php | 38 ++-- main/admin/ldap_users_synchro.php | 48 ++--- main/admin/promotions.php | 14 +- main/admin/usergroup_user_import.php | 18 +- main/auth/external_login/ldap.inc.php | 2 +- main/auth/sso/sso.Drupal.class.php | 22 +-- main/auth/sso/sso_server_test.php | 8 +- main/cron/course_finished.php | 14 +- main/cron/create_course_sessions.php | 15 +- main/cron/document/finddoc.php | 4 +- main/cron/fix_fill_blank.php | 2 +- main/cron/fix_online_time.php | 10 +- main/cron/hosting_total_size_limit.php | 4 +- main/cron/lang/check_parse_lang.php | 8 +- main/cron/lang/langstats_file_builder.php | 26 +-- main/cron/lang/list_undefined_langvars.php | 28 +-- main/cron/lang/list_unused_langvars.php | 18 +- .../resend_email_with_new_password.php | 10 +- main/inc/lib/array.lib.php | 6 +- main/inc/lib/baker.lib.php | 36 ++-- main/inc/lib/custom_pages.class.php | 14 +- main/inc/lib/events_email.class.php | 28 +-- main/inc/lib/export.lib.inc.php | 10 +- .../formvalidator/Element/DateRangePicker.php | 2 +- .../formvalidator/Rule/MultipleRequired.php | 6 +- main/inc/lib/hook/HookManagement.php | 28 +-- main/inc/lib/login_redirection.class.php | 12 +- main/inc/lib/portfolio.class.php | 12 +- main/inc/lib/redirect.class.php | 12 +- main/inc/lib/rights.lib.php | 4 +- main/inc/lib/search/ChamiloQuery.php | 12 +- main/inc/lib/system/web/request.class.php | 2 +- main/inc/lib/table_sort.class.php | 4 +- main/permissions/roles.php | 96 +++++----- main/session/session_category_add.php | 102 +++++------ main/session/session_import.php | 16 +- main/survey/fillsurvey.php | 12 +- main/survey/survey_list.php | 6 +- main/webservices/access_url.php | 102 +++++------ main/webservices/client_soap.php | 14 +- main/webservices/cm_soap.php | 2 +- .../cm_webservice_announcements.php | 20 +- main/webservices/cm_webservice_courses.php | 6 +- main/webservices/cm_webservice_inbox.php | 30 +-- .../webservices/example_fill_users_fields.php | 2 +- main/webservices/http-auth.php | 10 +- main/webservices/soap.php | 4 +- main/webservices/testip.php | 2 +- main/webservices/user_import/service.php | 2 +- main/webservices/user_info.soap.php | 50 ++--- main/webservices/webservice.php | 14 +- main/webservices/webservice_report.php | 36 ++-- main/work/download_comment_file.php | 2 +- plugin/buycourses/src/paypalfunctions.php | 88 ++++----- .../block_course/block_course.class.php | 28 +-- .../block_evaluation_graph.class.php | 38 ++-- .../plugin.php | 8 +- plugin/jcapture/plugin_applet.php | 2 +- plugin/kannelsms/config.php | 2 +- plugin/kannelsms/lib/kannelsms.lib.php | 7 +- .../openmeetings/lib/openmeetings_gateway.php | 172 +++++++++--------- plugin/resubscription/install.php | 2 +- 69 files changed, 694 insertions(+), 696 deletions(-) diff --git a/custompages/first_login-dist.php b/custompages/first_login-dist.php index 436069ae71..79d37e0fa7 100644 --- a/custompages/first_login-dist.php +++ b/custompages/first_login-dist.php @@ -11,17 +11,17 @@ require_once __DIR__.'/language.php'; /** * Security checks */ -if (! isset($_SESSION['conditional_login']['uid'])) +if (!isset($_SESSION['conditional_login']['uid'])) die("Not Authorised"); if (isset($_POST['password'])) { $u = api_get_user_info($_SESSION['conditional_login']['uid']); if ($_POST['password'] != $_POST['password2']) { - header('Location: '. api_get_self().'?invalid=2'); + header('Location: '.api_get_self().'?invalid=2'); exit(); } - if (empty($_POST['password'])){ //|| !api_check_password($password)) { //Pass must be at least 5 char long with 2 digits and 3 letters - header('Location: '. api_get_self().'?invalid=1'); + if (empty($_POST['password'])) { //|| !api_check_password($password)) { //Pass must be at least 5 char long with 2 digits and 3 letters + header('Location: '.api_get_self().'?invalid=1'); exit(); } $password = $_POST['password']; @@ -97,23 +97,23 @@ $www = api_get_path('WEB_PATH'); -

+

-
+
'.$error_message.'
'; }?>
- +
- +
- +
- Go to your portal + Go to your portal diff --git a/custompages/lostpassword-dist.php b/custompages/lostpassword-dist.php index fb4fd1605b..ed441b3d1b 100644 --- a/custompages/lostpassword-dist.php +++ b/custompages/lostpassword-dist.php @@ -12,7 +12,7 @@ $rootWeb = api_get_path('WEB_PATH'); ?> - <?php echo custompages_get_lang('LostPassword');?> + <?php echo custompages_get_lang('LostPassword'); ?> @@ -44,7 +44,7 @@ $rootWeb = api_get_path('WEB_PATH');
'; + echo '
'; } echo isset($content['form']) ? $content['form'] : '' diff --git a/custompages/registration-dist.php b/custompages/registration-dist.php index 54effdd461..e547c67e4a 100644 --- a/custompages/registration-dist.php +++ b/custompages/registration-dist.php @@ -81,7 +81,7 @@ EOT; ?> - <?php echo custompages_get_lang('Registration');?> + <?php echo custompages_get_lang('Registration'); ?> diff --git a/custompages/registration-feedback-dist.php b/custompages/registration-feedback-dist.php index d2945918c2..fe35095e73 100644 --- a/custompages/registration-feedback-dist.php +++ b/custompages/registration-feedback-dist.php @@ -14,7 +14,7 @@ $rootWeb = api_get_path('WEB_PATH'); ?> - <?php echo custompages_get_lang('Registration');?> + <?php echo custompages_get_lang('Registration'); ?> @@ -40,7 +40,7 @@ $rootWeb = api_get_path('WEB_PATH');