From eb892b534d501d16fcdaaf3d41c96fdb034aa909 Mon Sep 17 00:00:00 2001 From: Julio Montoya Date: Thu, 10 Jun 2021 21:04:44 +0200 Subject: [PATCH] Minor - format code + fix lang variables --- public/main/inc/lib/exercise.lib.php | 17 ++++++----------- src/LtiBundle/Controller/CourseController.php | 5 ----- 2 files changed, 6 insertions(+), 16 deletions(-) diff --git a/public/main/inc/lib/exercise.lib.php b/public/main/inc/lib/exercise.lib.php index 4e36483cf7..95a3af31c8 100644 --- a/public/main/inc/lib/exercise.lib.php +++ b/public/main/inc/lib/exercise.lib.php @@ -5225,19 +5225,14 @@ EOT; ); } - /** - * @return array - */ - public static function getNotificationSettings() + public static function getNotificationSettings(): array { - $emailAlerts = [ - 2 => get_lang('SendEmailToTrainerWhenStudentStartQuiz'), - 1 => get_lang('SendEmailToTrainerWhenStudentEndQuiz'), // default - 3 => get_lang('SendEmailToTrainerWhenStudentEndQuizOnlyIfOpenQuestion'), - 4 => get_lang('SendEmailToTrainerWhenStudentEndQuizOnlyIfOralQuestion'), + return [ + 2 => get_lang('Paranoid: E-mail teacher when a student starts an exercise'), + 1 => get_lang('Aware: E-mail teacher when a student ends an exercise'), // default + 3 => get_lang('Relaxed open: E-mail teacher when a student ends an exercise, only if an open question is answered'), + 4 => get_lang('Relaxed audio: E-mail teacher when a student ends an exercise, only if an oral question is answered'), ]; - - return $emailAlerts; } /** diff --git a/src/LtiBundle/Controller/CourseController.php b/src/LtiBundle/Controller/CourseController.php index 2061a664d1..7f6201e5f1 100644 --- a/src/LtiBundle/Controller/CourseController.php +++ b/src/LtiBundle/Controller/CourseController.php @@ -126,11 +126,6 @@ class CourseController extends ToolBaseController /** * @Route("/launch/{id}", name="chamilo_lti_launch", requirements={"id"="\d+"}) - * - * @param int $id - * @param Utils $ltiUtil - * - * @return Response */ public function launchAction(int $id, Utils $ltiUtil): Response {