Plugin: BuyCourses: Move code to function

plugin/buycourses/src/buy_course_plugin.class.php

@@ -1504,15 +1504,43 @@ class BuyCoursesPlugin extends Plugin
      *
      * @return array
      */
-    public function getPaymentTypes()
+    public function getPaymentTypes(bool $onlyActive = false): array
     {
-        return [
+        $types = [
             self::PAYMENT_TYPE_PAYPAL => 'PayPal',
             self::PAYMENT_TYPE_TRANSFER => $this->get_lang('BankTransfer'),
             self::PAYMENT_TYPE_CULQI => 'Culqi',
             self::PAYMENT_TYPE_TPV_REDSYS => $this->get_lang('TpvPayment'),
             self::PAYMENT_TYPE_STRIPE => 'Stripe',
         ];
+
+        if (!$onlyActive) {
+            return $types;
+        }
+
+        if ($this->get('paypal_enable') !== 'true') {
+            unset($types[BuyCoursesPlugin::PAYMENT_TYPE_PAYPAL]);
+        }
+
+        if ($this->get('transfer_enable') !== 'true') {
+            unset($types[BuyCoursesPlugin::PAYMENT_TYPE_TRANSFER]);
+        }
+
+        if ($this->get('culqi_enable') !== 'true') {
+            unset($types[BuyCoursesPlugin::PAYMENT_TYPE_CULQI]);
+        }
+
+        if ($this->get('tpv_redsys_enable') !== 'true'
+            || !file_exists(api_get_path(SYS_PLUGIN_PATH).'buycourses/resources/apiRedsys.php')
+        ) {
+            unset($types[BuyCoursesPlugin::PAYMENT_TYPE_TPV_REDSYS]);
+        }
+
+        if ($this->get('stripe_enable') !== 'true') {
+            unset($types[BuyCoursesPlugin::PAYMENT_TYPE_STRIPE]);
+        }
+
+        return $types;
     }
 
     /**

plugin/buycourses/src/process.php

@@ -89,27 +89,7 @@ if ($form->validate()) {
     exit;
 }
 
-$paymentTypesOptions = $plugin->getPaymentTypes();
-
-if (!$paypalEnabled) {
-    unset($paymentTypesOptions[BuyCoursesPlugin::PAYMENT_TYPE_PAYPAL]);
-}
-
-if (!$transferEnabled) {
-    unset($paymentTypesOptions[BuyCoursesPlugin::PAYMENT_TYPE_TRANSFER]);
-}
-
-if (!$culqiEnabled) {
-    unset($paymentTypesOptions[BuyCoursesPlugin::PAYMENT_TYPE_CULQI]);
-}
-
-if (!$tpvRedsysEnable || !file_exists(api_get_path(SYS_PLUGIN_PATH).'buycourses/resources/apiRedsys.php')) {
-    unset($paymentTypesOptions[BuyCoursesPlugin::PAYMENT_TYPE_TPV_REDSYS]);
-}
-
-if (!$stripeEnable) {
-    unset($paymentTypesOptions[BuyCoursesPlugin::PAYMENT_TYPE_STRIPE]);
-}
+$paymentTypesOptions = $plugin->getPaymentTypes(true);
 
 $count = count($paymentTypesOptions);
 if ($count === 0) {

plugin/buycourses/src/service_process.php

@@ -32,11 +32,6 @@ $htmlHeadXtra[] = '<link rel="stylesheet" type="text/css" href="'.api_get_path(
 $em = Database::getManager();
 $plugin = BuyCoursesPlugin::create();
 $includeServices = $plugin->get('include_services');
-$paypalEnabled = $plugin->get('paypal_enable') === 'true';
-$transferEnabled = $plugin->get('transfer_enable') === 'true';
-$culqiEnabled = $plugin->get('culqi_enable') === 'true';
-$tpvRedsysEnable = $plugin->get('tpv_redsys_enable') === 'true';
-$stripeEnable = $plugin->get('stripe_enable') === 'true';
 $additionalQueryString = '';
 if ($includeServices !== 'true') {
     api_not_allowed(true);
@@ -57,26 +52,8 @@ $serviceInfo = $plugin->getService($serviceId, $coupon);
 $userInfo = api_get_user_info($currentUserId);
 
 $form = new FormValidator('confirm_sale');
-$paymentTypesOptions = $plugin->getPaymentTypes();
+$paymentTypesOptions = $plugin->getPaymentTypes(true);
 
-if (!$paypalEnabled) {
-    unset($paymentTypesOptions[BuyCoursesPlugin::PAYMENT_TYPE_PAYPAL]);
-}
-
-if (!$transferEnabled) {
-    unset($paymentTypesOptions[BuyCoursesPlugin::PAYMENT_TYPE_TRANSFER]);
-}
-
-if (!$culqiEnabled) {
-    unset($paymentTypesOptions[BuyCoursesPlugin::PAYMENT_TYPE_CULQI]);
-}
-if (!$tpvRedsysEnable || !file_exists(api_get_path(SYS_PLUGIN_PATH).'buycourses/resources/apiRedsys.php')) {
-    unset($paymentTypesOptions[BuyCoursesPlugin::PAYMENT_TYPE_TPV_REDSYS]);
-}
-
-if (!$stripeEnable) {
-    unset($paymentTypesOptions[BuyCoursesPlugin::PAYMENT_TYPE_STRIPE]);
-}
 $form->addHtml(
     Display::return_message(
         $plugin->get_lang('PleaseSelectThePaymentMethodBeforeConfirmYourOrder'),