diff --git a/main/attendance/attendance_controller.php b/main/attendance/attendance_controller.php index 6d4d026fb3..f256ab7f4f 100755 --- a/main/attendance/attendance_controller.php +++ b/main/attendance/attendance_controller.php @@ -303,7 +303,7 @@ class AttendanceController $isDrhOfCourse = CourseManager::isUserSubscribedInCourseAsDrh( api_get_user_id(), api_get_course_info() - ); + ) || api_is_drh(); if ($edit == true) { if (api_is_allowed_to_edit(null, true) || $isDrhOfCourse) { diff --git a/main/attendance/attendance_sheet.php b/main/attendance/attendance_sheet.php index 7c6fdb4907..d0fe07f7de 100755 --- a/main/attendance/attendance_sheet.php +++ b/main/attendance/attendance_sheet.php @@ -16,7 +16,7 @@ api_protect_course_script(true); $isDrhOfCourse = CourseManager::isUserSubscribedInCourseAsDrh( api_get_user_id(), api_get_course_info() -); +) || api_is_drh(); if (api_is_allowed_to_edit(null, true) || api_is_coach(api_get_session_id(), api_get_course_int_id()) || diff --git a/main/gradebook/index.php b/main/gradebook/index.php index 04feeeb673..58a8b91914 100755 --- a/main/gradebook/index.php +++ b/main/gradebook/index.php @@ -786,7 +786,6 @@ if (isset($first_time) && $first_time == 1 && api_is_allowed_to_edit(null, true) } if (api_is_allowed_to_edit(null, true)) { - if (((empty($selectCat)) || (isset($_GET['cidReq']) && $_GET['cidReq'] !== '')) || (isset($_GET['isStudentView']) && $_GET['isStudentView'] == 'false') ) { diff --git a/main/inc/lib/attendance.lib.php b/main/inc/lib/attendance.lib.php index aaa437c451..719e9d8143 100755 --- a/main/inc/lib/attendance.lib.php +++ b/main/inc/lib/attendance.lib.php @@ -154,8 +154,9 @@ class Attendance while ($attendance = Database::fetch_row($res)) { $student_param = ''; - if (api_is_drh() && $_GET['student_id']) { - $student_param = '&student_id='.intval($_GET['student_id']); + $studentRequestId = isset($_GET['student_id']) ? (int) $_GET['student_id'] : 0; + if (api_is_drh() && !empty($studentRequestId)) { + $student_param = '&student_id='.$studentRequestId; } $session_star = ''; @@ -166,8 +167,7 @@ class Attendance $isDrhOfCourse = CourseManager::isUserSubscribedInCourseAsDrh( api_get_user_id(), api_get_course_info() - ); - + ) || api_is_drh(); if (api_is_allowed_to_edit(null, true) || $isDrhOfCourse) { // Link to edit $attendance[1] = ''.$attendance[1].''.$session_star; diff --git a/main/inc/lib/lp_item.lib.php b/main/inc/lib/lp_item.lib.php index d02ac2cf4f..90be7df51c 100755 --- a/main/inc/lib/lp_item.lib.php +++ b/main/inc/lib/lp_item.lib.php @@ -43,10 +43,10 @@ class LpItem { if ($in_c_id > 0 && $in_id > 0) { $item_view_table = Database::get_course_table(TABLE_LP_ITEM); - $sql = "SELECT * FROM $item_view_table - WHERE - c_id=".intval($in_c_id)." AND - id=".intval($in_id); + $sql = "SELECT * FROM $item_view_table + WHERE + c_id=".intval($in_c_id)." AND + iid=".intval($in_id); $res = Database::query($sql); $data = Database::fetch_array($res); @@ -84,27 +84,27 @@ class LpItem { $table = Database::get_course_table(TABLE_LP_ITEM); if ($this->c_id > 0 && $this->id > 0) { - $sql = "UPDATE $table SET - lp_id = '".intval($this->lp_id)."' , - item_type = '".Database::escape_string($this->item_type)."' , - ref = '".Database::escape_string($this->ref)."' , - title = '".Database::escape_string($this->title)."' , - description = '".Database::escape_string($this->description)."' , - path = '".Database::escape_string($this->path)."' , - min_score = '".Database::escape_string($this->min_score)."' , - max_score = '".Database::escape_string($this->max_score)."' , - mastery_score = '".Database::escape_string($this->mastery_score)."' , - parent_item_id = '".Database::escape_string($this->parent_item_id)."' , - previous_item_id = '".Database::escape_string($this->previous_item_id)."' , - next_item_id = '".Database::escape_string($this->next_item_id)."' , - display_order = '".Database::escape_string($this->display_order)."' , - prerequisite = '".Database::escape_string($this->prerequisite)."' , - parameters = '".Database::escape_string($this->parameters)."' , - launch_data = '".Database::escape_string($this->launch_data)."' , - max_time_allowed = '".Database::escape_string($this->max_time_allowed)."' , - terms = '".Database::escape_string($this->terms)."' , - search_did = '".Database::escape_string($this->search_did)."' , - audio = '".Database::escape_string($this->audio)."' + $sql = "UPDATE $table SET + lp_id = '".intval($this->lp_id)."' , + item_type = '".Database::escape_string($this->item_type)."' , + ref = '".Database::escape_string($this->ref)."' , + title = '".Database::escape_string($this->title)."' , + description = '".Database::escape_string($this->description)."' , + path = '".Database::escape_string($this->path)."' , + min_score = '".Database::escape_string($this->min_score)."' , + max_score = '".Database::escape_string($this->max_score)."' , + mastery_score = '".Database::escape_string($this->mastery_score)."' , + parent_item_id = '".Database::escape_string($this->parent_item_id)."' , + previous_item_id = '".Database::escape_string($this->previous_item_id)."' , + next_item_id = '".Database::escape_string($this->next_item_id)."' , + display_order = '".Database::escape_string($this->display_order)."' , + prerequisite = '".Database::escape_string($this->prerequisite)."' , + parameters = '".Database::escape_string($this->parameters)."' , + launch_data = '".Database::escape_string($this->launch_data)."' , + max_time_allowed = '".Database::escape_string($this->max_time_allowed)."' , + terms = '".Database::escape_string($this->terms)."' , + search_did = '".Database::escape_string($this->search_did)."' , + audio = '".Database::escape_string($this->audio)."' WHERE c_id=".$this->c_id." AND id=".$this->id; Database::query($sql); } diff --git a/main/inc/lib/template.lib.php b/main/inc/lib/template.lib.php index d2a87662b7..df822a4c77 100755 --- a/main/inc/lib/template.lib.php +++ b/main/inc/lib/template.lib.php @@ -1916,7 +1916,9 @@ class Template /** * Get platform meta image tag (check meta_image_path setting, then use the logo). + * * @param string $imageAlt The alt attribute for the image + * * @return string The meta image HTML tag, or empty */ private function getMetaPortalImagePath($imageAlt = '') diff --git a/main/inc/lib/tracking.lib.php b/main/inc/lib/tracking.lib.php index f0a788489a..dcac72ab05 100755 --- a/main/inc/lib/tracking.lib.php +++ b/main/inc/lib/tracking.lib.php @@ -7448,8 +7448,9 @@ class TrackingCourseLog $direction, $includeInvitedUsers = false ) { - global $user_ids, $course_code, $export_csv, $csv_content, $session_id; + global $user_ids, $course_code, $export_csv, $session_id; + $csv_content = []; $course_code = Database::escape_string($course_code); $tbl_user = Database::get_main_table(TABLE_MAIN_USER); $tbl_url_rel_user = Database::get_main_table(TABLE_MAIN_ACCESS_URL_REL_USER); @@ -7696,6 +7697,10 @@ class TrackingCourseLog $users[] = array_values($user_row); } + if ($export_csv) { + Session::write('csv_content', $csv_content); + } + Session::erase('additional_user_profile_info'); Session::erase('extra_field_info'); diff --git a/main/lp/learnpath.class.php b/main/lp/learnpath.class.php index 2bd320c80d..3a03bf6f7b 100755 --- a/main/lp/learnpath.class.php +++ b/main/lp/learnpath.class.php @@ -10332,13 +10332,13 @@ class learnpath $selectedMinScore = []; $selectedMaxScore = []; $masteryScore = []; - while ($row = Database::fetch_array($result)) { - if ($row['id'] == $item_id) { + if ($row['iid'] == $item_id) { $selectedMinScore[$row['prerequisite']] = $row['prerequisite_min_score']; $selectedMaxScore[$row['prerequisite']] = $row['prerequisite_max_score']; - $masteryScore[$row['prerequisite']] = $row['mastery_score']; } + $masteryScore[$row['iid']] = $row['mastery_score']; + $arrLP[] = [ 'id' => $row['iid'], 'item_type' => $row['item_type'], diff --git a/main/survey/reporting.php b/main/survey/reporting.php index 8ce4b1fac0..b9eea6ca35 100755 --- a/main/survey/reporting.php +++ b/main/survey/reporting.php @@ -62,21 +62,13 @@ if (!empty($exportReport) && !empty($format)) { switch ($format) { case 'xls': $filename = 'survey_results_'.$survey_id.'.xlsx'; - $data = SurveyUtil::export_complete_report_xls( - $survey_data, - $filename, - $userId - ); + $data = SurveyUtil::export_complete_report_xls($survey_data, $filename, $userId); exit; break; case 'csv': default: - $data = SurveyUtil::export_complete_report( - $survey_data, - $userId - ); + $data = SurveyUtil::export_complete_report($survey_data, $userId); $filename = 'survey_results_'.$survey_id.'.csv'; - header('Content-type: application/octet-stream'); header('Content-Type: application/force-download'); diff --git a/main/survey/surveyUtil.class.php b/main/survey/surveyUtil.class.php index 7f340a2d88..4536cf02e7 100755 --- a/main/survey/surveyUtil.class.php +++ b/main/survey/surveyUtil.class.php @@ -225,7 +225,7 @@ class SurveyUtil */ public static function handle_reporting_actions($survey_data, $people_filled) { - $action = isset($_GET['action']) ? $_GET['action'] : null; + $action = isset($_GET['action']) ? $_GET['action'] : ''; // Getting the number of question $temp_questions_data = SurveyManager::get_questions($_GET['survey_id']); @@ -243,20 +243,22 @@ class SurveyUtil // Counting the number of questions that are relevant for the reporting $survey_data['number_of_questions'] = count($questions_data); - if ($action == 'questionreport') { - self::display_question_report($survey_data); - } - if ($action == 'userreport') { - self::display_user_report($people_filled, $survey_data); - } - if ($action == 'comparativereport') { - self::display_comparative_report(); - } - if ($action == 'completereport') { - self::display_complete_report($survey_data); - } - if ($action == 'deleteuserreport') { - self::delete_user_report($_GET['survey_id'], $_GET['user']); + switch ($action) { + case 'questionreport': + self::display_question_report($survey_data); + break; + case 'userreport': + self::display_user_report($people_filled, $survey_data); + break; + case 'comparativereport': + self::display_comparative_report(); + break; + case 'completereport': + self::display_complete_report($survey_data); + break; + case 'deleteuserreport': + self::delete_user_report($_GET['survey_id'], $_GET['user']); + break; } } @@ -373,7 +375,7 @@ class SurveyUtil echo '