From f46eb1c74d1dac32c6595cdf659aff90c04d2134 Mon Sep 17 00:00:00 2001 From: jmontoyaa Date: Tue, 16 Aug 2016 09:20:20 +0200 Subject: [PATCH] Add ticket_allow_category_edition validations --- main/inc/lib/TicketManager.php | 3 +++ main/ticket/categories.php | 25 +++++++++++++++++-------- 2 files changed, 20 insertions(+), 8 deletions(-) diff --git a/main/inc/lib/TicketManager.php b/main/inc/lib/TicketManager.php index a62ea33e65..33313c0b20 100644 --- a/main/inc/lib/TicketManager.php +++ b/main/inc/lib/TicketManager.php @@ -2295,6 +2295,9 @@ class TicketManager return $form; } + /** + * @return string + */ public static function getSettingsMenu() { $items = [ diff --git a/main/ticket/categories.php b/main/ticket/categories.php index 26a9a9ca02..9f7d86bde2 100644 --- a/main/ticket/categories.php +++ b/main/ticket/categories.php @@ -88,6 +88,10 @@ switch ($action) { } break; case 'edit': + if (api_get_setting('ticket_allow_category_edition') !== 'true') { + api_not_allowed(); + } + $toolName = get_lang('Edit'); $interbreadcrumb[] = array( 'url' => api_get_path(WEB_CODE_PATH).'ticket/categories.php?project_id='.$projectId, @@ -128,20 +132,25 @@ switch ($action) { function modify_filter($id, $params, $row) { $projectId = Session::read('project_id'); - $result = Display::url( - Display::return_icon('edit.png', get_lang('Edit')), - "categories.php?action=edit&id={$row['id']}&project_id=".$projectId - ); + + if (api_get_setting('ticket_allow_category_edition') === 'true') { + $result = Display::url( + Display::return_icon('edit.png', get_lang('Edit')), + "categories.php?action=edit&id={$row['id']}&project_id=".$projectId + ); + } $result .= Display::url( Display::return_icon('user.png', get_lang('AssignUser')), "categories_add_user.php?id={$row['id']}&project_id=".$projectId ); - $result .= Display::url( - Display::return_icon('delete.png', get_lang('Delete')), - "categories.php?action=delete&id={$row['id']}&project_id=".$projectId - ); + if (api_get_setting('ticket_allow_category_edition') === 'true') { + $result .= Display::url( + Display::return_icon('delete.png', get_lang('Delete')), + "categories.php?action=delete&id={$row['id']}&project_id=".$projectId + ); + } return $result; }