Update migrate-db (user_id to id query was sub-optimal) and add commented-out drop user_id

main/install/migrate-db-1.9.0-1.10.0-post.sql

@@ -25,6 +25,9 @@ ALTER TABLE track_e_course_access DROP COLUMN course_code;
 ALTER TABLE track_e_online DROP COLUMN course;
 ALTER TABLE track_e_attempt DROP COLUMN course_code;
 
+-- not yet ready, uncomment when all user_id have been replaced by id
+-- ALTER TABLE user DROP COLUMN user_id;
+
 -- xxCOURSExx
 
 

main/install/update-db-1.9.0-1.10.0.inc.php

@@ -123,14 +123,8 @@ if (defined('SYSTEM_INSTALLATION')) {
             }
 
             // Updating user.id field
-            $res = iDatabase::query("SELECT user_id FROM $dbNameForm.user");
-            $result = iDatabase::query($sql);
-            $users = Database::store_result($result);
-            foreach ($users as $user) {
-                $userId = $user['user_id'];
-                $sql = "UPDATE $dbNameForm.user SET id = $userId WHERE user_id = $userId";
-                iDatabase::query($sql);
-            }
+            $sql = "UPDATE $dbNameForm.user SET id = $userId WHERE user_id = $userId";
+            iDatabase::query($sql);
 
             // Set null registration_date = 0000-00-00 00:00:00
             $sql = "UPDATE $dbNameForm.user SET registration_date = NULL WHERE registration_date = '0000-00-00 00:00:00'";