Minor - Remove unused code

4 years ago · f65e0f2ec2
parent eba065a171
commit f65e0f2ec2
3 changed files with 5 additions and 13 deletions
--- a/src/CoreBundle/Controller/ResourceController.php
+++ b/src/CoreBundle/Controller/ResourceController.php
@ -22,7 +22,6 @@ use Chamilo\CourseBundle\Controller\CourseControllerInterface;
 use Doctrine\Common\Collections\ArrayCollection;
 use Doctrine\Common\Collections\Criteria;
 use Symfony\Component\Filesystem\Exception\FileNotFoundException;
-use Symfony\Component\HttpFoundation\File\UploadedFile;
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
--- a/src/CoreBundle/Resources/views/Layout/base-layout.html.twig
+++ b/src/CoreBundle/Resources/views/Layout/base-layout.html.twig
@ -14,9 +14,6 @@
 </head>
 {% endblock %}
 <body class="font-sans antialiased {{ section_name }}">
-{#    data-course-id="{{ course ? course.id : 0 }}"#}
-{#    data-course-code="{{ course ? course.code : '' }}"#}
-{#    data-session-id="{{ session ? session.id : 0 }}"#}
 <noscript>{{ "Your browser does not support Javascript" | trans }}</noscript>
 {%- block chamilo_wrap -%}
    {%- block page_content %}
--- a/src/CoreBundle/Settings/SettingsManager.php
+++ b/src/CoreBundle/Settings/SettingsManager.php
@ -45,11 +45,12 @@ class SettingsManager implements SettingsManagerInterface
     * @var Settings[]
     */
    protected array $resolvedSettings = [];
-    //protected $settings;
+
    /**
     * @var null|array<string, Settings>|mixed[]
     */
    protected ?array $schemaList;
+
    protected RequestStack $request;

    public function __construct(
@ -100,10 +101,7 @@ class SettingsManager implements SettingsManagerInterface
        }
    }

-    /**
-     * @return array
-     */
-    public function getSchemas()
+    public function getSchemas(): array
    {
        return $this->schemaRegistry->all();
    }
@ -119,13 +117,11 @@ class SettingsManager implements SettingsManagerInterface
    }

    /**
-     * @param string $name
-     *
     * @throws InvalidArgumentException
     */
-    public function getSetting($name)
+    public function getSetting(string $name)
    {
-        if (false === strpos($name, '.')) {
+        if (!str_contains($name, '.')) {
            //throw new \InvalidArgumentException(sprintf('Parameter must be in format "namespace.name", "%s" given.', $name));

            // This code allows the possibility of calling