ClamAV is an open source (GPLv2) anti-virus toolkit.
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
clamav/libclamav/sis.c

1258 lines
47 KiB

/*
* Copyright (C) 2013-2025 Cisco Systems, Inc. and/or its affiliates. All rights reserved.
* Copyright (C) 2007-2013 Sourcefire, Inc.
*
* Authors: Alberto Wu
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 as
* published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
* MA 02110-1301, USA.
*/
#if HAVE_CONFIG_H
#include "clamav-config.h"
#endif
#include <stdio.h>
#if HAVE_STDLIB_H
#include <stdlib.h>
#endif
#if HAVE_STRING_H
#include <string.h>
#endif
#if HAVE_SYS_TYPES_H
#include <sys/types.h>
#endif
#if HAVE_SYS_STAT_H
#include <sys/stat.h>
#endif
#include <fcntl.h>
#include <zlib.h>
#include "others.h"
#include "clamav.h"
#include "scanners.h"
#include "sis.h"
#define EC32(x) cli_readint32(&(x))
#define EC16(x) cli_readint16(&(x))
/*
* The SIS header begins with four 4-byte UIDs.
*
* SIS format reference: https://web.archive.org/web/20021017223232/http://homepage.ntlworld.com/thouky/software/psifs/sis.html
*
* SIS v9.x format reference: https://web.archive.org/web/20101011053920/http://developer.symbian.org/wiki/images/b/b7/SymbianOSv9.x_SIS_File_Format_Specification.pdf
* See Section 3 (page 8)
*/
#define SIZEOF_HEADER_UUIDS 16
static cl_error_t real_scansis(cli_ctx *, const char *);
static cl_error_t real_scansis9x(cli_ctx *, const char *);
/*************************************************
This is the wrapper to the old and new
format handlers - see below.
*************************************************/
cl_error_t cli_scansis(cli_ctx *ctx)
{
char *tmpd;
unsigned int i;
uint32_t uid[4];
libclamav: Fix scan recursion tracking Scan recursion is the process of identifying files embedded in other files and then scanning them, recursively. Internally this process is more complex than it may sound because a file may have multiple layers of types before finding a new "file". At present we treat the recursion count in the scanning context as an index into both our fmap list AND our container list. These two lists are conceptually a part of the same thing and should be unified. But what's concerning is that the "recursion level" isn't actually incremented or decremented at the same time that we add a layer to the fmap or container lists but instead is more touchy-feely, increasing when we find a new "file". To account for this shadiness, the size of the fmap and container lists has always been a little longer than our "max scan recursion" limit so we don't accidentally overflow the fmap or container arrays (!). I've implemented a single recursion-stack as an array, similar to before, which includes a pointer to each fmap at each layer, along with the size and type. Push and pop functions add and remove layers whenever a new fmap is added. A boolean argument when pushing indicates if the new layer represents a new buffer or new file (descriptor). A new buffer will reset the "nested fmap level" (described below). This commit also provides a solution for an issue where we detect embedded files more than once during scan recursion. For illustration, imagine a tarball named foo.tar.gz with this structure: | description | type | rec level | nested fmap level | | ------------------------- | ----- | --------- | ----------------- | | foo.tar.gz | GZ | 0 | 0 | | └── foo.tar | TAR | 1 | 0 | | ├── bar.zip | ZIP | 2 | 1 | | │   └── hola.txt | ASCII | 3 | 0 | | └── baz.exe | PE | 2 | 1 | But suppose baz.exe embeds a ZIP archive and a 7Z archive, like this: | description | type | rec level | nested fmap level | | ------------------------- | ----- | --------- | ----------------- | | baz.exe | PE | 0 | 0 | | ├── sfx.zip | ZIP | 1 | 1 | | │   └── hello.txt | ASCII | 2 | 0 | | └── sfx.7z | 7Z | 1 | 1 | |    └── world.txt | ASCII | 2 | 0 | (A) If we scan for embedded files at any layer, we may detect: | description | type | rec level | nested fmap level | | ------------------------- | ----- | --------- | ----------------- | | foo.tar.gz | GZ | 0 | 0 | | ├── foo.tar | TAR | 1 | 0 | | │ ├── bar.zip | ZIP | 2 | 1 | | │ │   └── hola.txt | ASCII | 3 | 0 | | │ ├── baz.exe | PE | 2 | 1 | | │ │ ├── sfx.zip | ZIP | 3 | 1 | | │ │ │   └── hello.txt | ASCII | 4 | 0 | | │ │ └── sfx.7z | 7Z | 3 | 1 | | │ │    └── world.txt | ASCII | 4 | 0 | | │ ├── sfx.zip | ZIP | 2 | 1 | | │ │   └── hello.txt | ASCII | 3 | 0 | | │ └── sfx.7z | 7Z | 2 | 1 | | │   └── world.txt | ASCII | 3 | 0 | | ├── sfx.zip | ZIP | 1 | 1 | | └── sfx.7z | 7Z | 1 | 1 | (A) is bad because it scans content more than once. Note that for the GZ layer, it may detect the ZIP and 7Z if the signature hits on the compressed data, which it might, though extracting the ZIP and 7Z will likely fail. The reason the above doesn't happen now is that we restrict embedded type scans for a bunch of archive formats to include GZ and TAR. (B) If we scan for embedded files at the foo.tar layer, we may detect: | description | type | rec level | nested fmap level | | ------------------------- | ----- | --------- | ----------------- | | foo.tar.gz | GZ | 0 | 0 | | └── foo.tar | TAR | 1 | 0 | | ├── bar.zip | ZIP | 2 | 1 | | │   └── hola.txt | ASCII | 3 | 0 | | ├── baz.exe | PE | 2 | 1 | | ├── sfx.zip | ZIP | 2 | 1 | | │   └── hello.txt | ASCII | 3 | 0 | | └── sfx.7z | 7Z | 2 | 1 | |    └── world.txt | ASCII | 3 | 0 | (B) is almost right. But we can achieve it easily enough only scanning for embedded content in the current fmap when the "nested fmap level" is 0. The upside is that it should safely detect all embedded content, even if it may think the sfz.zip and sfx.7z are in foo.tar instead of in baz.exe. The biggest risk I can think of affects ZIPs. SFXZIP detection is identical to ZIP detection, which is why we don't allow SFXZIP to be detected if insize of a ZIP. If we only allow embedded type scanning at fmap-layer 0 in each buffer, this will fail to detect the embedded ZIP if the bar.exe was not compressed in foo.zip and if non-compressed files extracted from ZIPs aren't extracted as new buffers: | description | type | rec level | nested fmap level | | ------------------------- | ----- | --------- | ----------------- | | foo.zip | ZIP | 0 | 0 | | └── bar.exe | PE | 1 | 1 | | └── sfx.zip | ZIP | 2 | 2 | Provided that we ensure all files extracted from zips are scanned in new buffers, option (B) should be safe. (C) If we scan for embedded files at the baz.exe layer, we may detect: | description | type | rec level | nested fmap level | | ------------------------- | ----- | --------- | ----------------- | | foo.tar.gz | GZ | 0 | 0 | | └── foo.tar | TAR | 1 | 0 | | ├── bar.zip | ZIP | 2 | 1 | | │   └── hola.txt | ASCII | 3 | 0 | | └── baz.exe | PE | 2 | 1 | | ├── sfx.zip | ZIP | 3 | 1 | | │   └── hello.txt | ASCII | 4 | 0 | | └── sfx.7z | 7Z | 3 | 1 | |    └── world.txt | ASCII | 4 | 0 | (C) is right. But it's harder to achieve. For this example we can get it by restricting 7ZSFX and ZIPSFX detection only when scanning an executable. But that may mean losing detection of archives embedded elsewhere. And we'd have to identify allowable container types for each possible embedded type, which would be very difficult. So this commit aims to solve the issue the (B)-way. Note that in all situations, we still have to scan with file typing enabled to determine if we need to reassign the current file type, such as re-identifying a Bzip2 archive as a DMG that happens to be Bzip2- compressed. Detection of DMG and a handful of other types rely on finding data partway through or near the ned of a file before reassigning the entire file as the new type. Other fixes and considerations in this commit: - The utf16 HTML parser has weak error handling, particularly with respect to creating a nested fmap for scanning the ascii decoded file. This commit cleans up the error handling and wraps the nested scan with the recursion-stack push()/pop() for correct recursion tracking. Before this commit, each container layer had a flag to indicate if the container layer is valid. We need something similar so that the cli_recursion_stack_get_*() functions ignore normalized layers. Details... Imagine an LDB signature for HTML content that specifies a ZIP container. If the signature actually alerts on the normalized HTML and you don't ignore normalized layers for the container check, it will appear as though the alert is in an HTML container rather than a ZIP container. This commit accomplishes this with a boolean you set in the scan context before scanning a new layer. Then when the new fmap is created, it will use that flag to set similar flag for the layer. The context flag is reset those that anything after this doesn't have that flag. The flag allows the new recursion_stack_get() function to ignore normalized layers when iterating the stack to return a layer at a requested index, negative or positive. Scanning normalized extracted/normalized javascript and VBA should also use the 'layer is normalized' flag. - This commit also fixes Heuristic.Broken.Executable alert for ELF files to make sure that: A) these only alert if cli_append_virus() returns CL_VIRUS (aka it respects the FP check). B) all broken-executable alerts for ELF only happen if the SCAN_HEURISTIC_BROKEN option is enabled. - This commit also cleans up the error handling in cli_magic_scan_dir(). This was needed so we could correctly apply the layer-is-normalized-flag to all VBA macros extracted to a directory when scanning the directory. - Also fix an issue where exceeding scan maximums wouldn't cause embedded file detection scans to abort. Granted we don't actually want to abort if max filesize or max recursion depth are exceeded... only if max scansize, max files, and max scantime are exceeded. Add 'abort_scan' flag to scan context, to protect against depending on correct error propagation for fatal conditions. Instead, setting this flag in the scan context should guarantee that a fatal condition deep in scan recursion isn't lost which result in more stuff being scanned instead of aborting. This shouldn't be necessary, but some status codes like CL_ETIMEOUT never used to be fatal and it's easier to do this than to verify every parser only returns CL_ETIMEOUT and other "fatal status codes" in fatal conditions. - Remove duplicate is_tar() prototype from filestypes.c and include is_tar.h instead. - Presently we create the fmap hash when creating the fmap. This wastes a bit of CPU if the hash is never needed. Now that we're creating fmap's for all embedded files discovered with file type recognition scans, this is a much more frequent occurence and really slows things down. This commit fixes the issue by only creating fmap hashes as needed. This should not only resolve the perfomance impact of creating fmap's for all embedded files, but also should improve performance in general. - Add allmatch check to the zip parser after the central-header meta match. That way we don't multiple alerts with the same match except in allmatch mode. Clean up error handling in the zip parser a tiny bit. - Fixes to ensure that the scan limits such as scansize, filesize, recursion depth, # of embedded files, and scantime are always reported if AlertExceedsMax (--alert-exceeds-max) is enabled. - Fixed an issue where non-fatal alerts for exceeding scan maximums may mask signature matches later on. I changed it so these alerts use the "possibly unwanted" alert-type and thus only alert if no other alerts were found or if all-match or heuristic-precedence are enabled. - Added the "Heuristics.Limits.Exceeded.*" events to the JSON metadata when the --gen-json feature is enabled. These will show up once under "ParseErrors" the first time a limit is exceeded. In the present implementation, only one limits-exceeded events will be added, so as to prevent a malicious or malformed sample from filling the JSON buffer with millions of events and using a tonne of RAM.
4 years ago
fmap_t *map = ctx->fmap;
cli_dbgmsg("in scansis()\n");
Improve tmp sub-directory names At present many parsers create tmp subdirectories to store extracted files. For parsers like the vba parser, this is required as the directory is later scanned. For other parsers, these subdirectories are probably not helpful now that we provide recursive sub-dirs when --leave-temps is enabled. It's not quite as simple as removing the extra subdirectories, however. Certain parsers, like autoit, don't create very unique filenames and would result in file name collisions when --leave-temps is not enabled. The best thing to do would be to make sure each parser uses unique filenames and doesn't rely on cli_magic_scan_dir() to scan extracted content before removing the extra subdirectory. In the meantime, this commit gives the extra subdirectories meaningful names to improve readability. This commit also: - Provides the 'bmp' prefix for extracted PE icons. - Removes empty tmp subdirs when extracting rtf files, to eliminate clutter. - The PDF parser sometimes creates tmp files when decompressing streams before it knows if there is actually any content to decompress. This resulted in a large number of empty files. While it would be best to avoid creating empty files in the first place, that's not quite as as it sounds. This commit does the next best thing and deletes the tmp files if nothing was actually extracted, even if --leave-temps is enabled. - Removes the "scantemp" prefix for unnamed fmaps scanned with cli_magic_scan(). The 5-character hashes given to tmp files with prefixes resulted in occasional file name collisions when extracting certain file types with thousands of embedded files. - The VBA and TAR parsers mistakenly used NAME_MAX instead of PATH_MAX, resulting in truncated file paths and failed extraction when --leave-temps is enabled and a lot of recursion is in play. This commit switches them from NAME_MAX to PATH_MAX.
5 years ago
if (!(tmpd = cli_gentemp_with_prefix(ctx->sub_tmpdir, "sis-tmp")))
return CL_ETMPDIR;
if (mkdir(tmpd, 0700)) {
cli_dbgmsg("SIS: Can't create temporary directory %s\n", tmpd);
free(tmpd);
return CL_ETMPDIR;
}
if (ctx->engine->keeptmp)
cli_dbgmsg("SIS: Extracting files to %s\n", tmpd);
if (fmap_readn(map, &uid, 0, SIZEOF_HEADER_UUIDS) != SIZEOF_HEADER_UUIDS) {
cli_dbgmsg("SIS: unable to read UIDs\n");
cli_rmdirs(tmpd);
free(tmpd);
return CL_EREAD;
}
cli_dbgmsg("SIS: UIDS %x %x %x - %x\n", EC32(uid[0]), EC32(uid[1]), EC32(uid[2]), EC32(uid[3]));
if (uid[2] == le32_to_host(0x10000419)) {
i = real_scansis(ctx, tmpd);
} else if (uid[0] == le32_to_host(0x10201a7a)) {
i = real_scansis9x(ctx, tmpd);
} else {
cli_dbgmsg("SIS: UIDs failed to match\n");
i = CL_EFORMAT;
}
if (!ctx->engine->keeptmp)
cli_rmdirs(tmpd);
free(tmpd);
return i;
}
/*************************************************
This is the handler for the old (pre 0.9)
SIS file format.
*************************************************/
enum {
PKGfile, /* I'm a real file */
PKGlangfile, /* Ich bin auch eine Datei */
PKGoption, /* options */
PKGif, /* #IF */
PKGelsif, /* #ELSIF */
PKGelse, /* #ELSE */
PKGendif /* #ENDIF */
};
enum {
FTsimple = 0,
FTtext,
FTcomponent,
FTrun,
FTnull,
FTmime,
FTsubsis,
FTcontsis,
FTtextuninst,
FTnotinst = 99
};
#define GETD2(VAR) \
{ \
/* cli_dbgmsg("GETD2 smax: %d sleft: %d\n", smax, sleft); */ \
if (sleft < 4) { \
memcpy(buff, buff + smax - sleft, sleft); \
size_t tmp = fmap_readn(map, buff + sleft, pos, BUFSIZ - sleft); \
smax = tmp; \
if (((size_t)-1) == tmp) { \
cli_dbgmsg("SIS: Read failed during GETD2\n"); \
status = CL_CLEAN; \
goto done; \
} else if ((smax += sleft) < 4) { \
cli_dbgmsg("SIS: EOF\n"); \
status = CL_CLEAN; \
goto done; \
} \
pos += smax - sleft; \
sleft = smax; \
} \
VAR = cli_readint32(&buff[smax - sleft]); \
sleft -= 4; \
}
#define SKIP(N) \
/* cli_dbgmsg("SKIP smax: %d sleft: %d\n", smax, sleft); */ \
if (sleft >= (N)) \
sleft -= (N); \
else { \
if ((N) < sleft) { \
cli_dbgmsg("SIS: Refusing to seek back\n"); \
free((void *)alangs); \
return CL_CLEAN; \
} \
pos += (N)-sleft; \
size_t tmp = fmap_readn(map, buff, pos, BUFSIZ); \
if (((size_t)-1) == tmp) { \
cli_dbgmsg("SIS: Read failed during SKIP\n"); \
free((void *)alangs); \
return CL_CLEAN; \
} \
sleft = smax = tmp; \
pos += smax; \
}
const char *sislangs[] = {"UNKNOWN", "UK English", "French", "German", "Spanish", "Italian", "Swedish", "Danish", "Norwegian", "Finnish", "American", "Swiss French", "Swiss German", "Portuguese", "Turkish", "Icelandic", "Russian", "Hungarian", "Dutch", "Belgian Flemish", "Australian English", "Belgian French", "Austrian German", "New Zealand English", "International French", "Czech", "Slovak", "Polish", "Slovenian", "Taiwanese Chinese", "Hong Kong Chinese", "PRC Chinese", "Japanese", "Thai", "Afrikaans", "Albanian", "Amharic", "Arabic", "Armenian", "Tagalog", "Belarussian", "Bengali", "Bulgarian", "Burmese", "Catalan", "Croation", "Canadian English", "International English", "South African English", "Estonian", "Farsi", "Canadian French", "Gaelic", "Georgian", "Greek", "Cyprus Greek", "Gujarati", "Hebrew", "Hindi", "Indonesian", "Irish", "Swiss Italian", "Kannada", "Kazakh", "Kmer", "Korean", "Lao", "Latvian", "Lithuanian", "Macedonian", "Malay", "Malayalam", "Marathi", "Moldovian", "Mongolian", "Norwegian Nynorsk", "Brazilian Portuguese", "Punjabi", "Romanian", "Serbian", "Sinhalese", "Somali", "International Spanish", "American Spanish", "Swahili", "Finland Swedish", "Reserved", "Tamil", "Telugu", "Tibetan", "Tigrinya", "Cyprus Turkish", "Turkmen", "Ukrainian", "Urdu", "Reserved", "Vietnamese", "Welsh", "Zulu", "Other"};
#define MAXLANG (sizeof(sislangs) / sizeof(sislangs[0]))
static char *getsistring(fmap_t *map, uint32_t ptr, uint32_t len)
{
char *name;
uint32_t i;
if (!len) return NULL;
if (len > 400) len = 400;
name = cli_max_malloc(len + 1);
if (!name) {
cli_dbgmsg("SIS: OOM\n");
return NULL;
}
if ((uint32_t)fmap_readn(map, name, ptr, len) != len) {
cli_dbgmsg("SIS: Unable to read string\n");
free(name);
return NULL;
}
for (i = 0; i < len; i += 2) name[i / 2] = name[i];
name[i / 2] = '\0';
return name;
}
static int spamsisnames(fmap_t *map, size_t pos, uint16_t langs, const char **alangs)
{
const uint32_t *ptrs;
const uint32_t *lens;
unsigned int j;
const uint32_t len = sizeof(uint32_t) * langs * 2;
14 years ago
if (!(lens = fmap_need_off(map, pos, len))) {
cli_dbgmsg("SIS: Unable to read lengths and pointers\n");
return 1;
}
ptrs = &lens[langs];
for (j = 0; j < langs; j++) {
char *name = getsistring(map, EC32(ptrs[j]), EC32(lens[j]));
if (name) {
cli_dbgmsg("\t%s (%s - @%x, len %d)\n", name, alangs[j], EC32(ptrs[j]), EC32(lens[j]));
free(name);
}
}
fmap_unneed_off(map, pos, len);
return 1;
}
static cl_error_t real_scansis(cli_ctx *ctx, const char *tmpd)
{
cl_error_t status = CL_CLEAN;
struct {
uint16_t filesum;
uint16_t langs;
uint16_t files;
uint16_t deps;
uint16_t ulangs;
uint16_t instfiles;
uint16_t drive;
uint16_t caps;
uint32_t version;
uint16_t flags;
uint16_t type;
uint16_t verhi;
uint16_t verlo;
uint32_t versub;
uint32_t plangs;
uint32_t pfiles;
uint32_t pdeps;
uint32_t pcerts;
uint32_t pnames;
uint32_t psig;
uint32_t pcaps;
uint32_t uspace;
uint32_t nspace;
} sis;
const char **alangs = NULL;
const uint16_t *llangs;
unsigned int i, umped = 0;
uint32_t sleft = 0, smax = 0;
uint8_t compd, buff[BUFSIZ];
size_t pos;
libclamav: Fix scan recursion tracking Scan recursion is the process of identifying files embedded in other files and then scanning them, recursively. Internally this process is more complex than it may sound because a file may have multiple layers of types before finding a new "file". At present we treat the recursion count in the scanning context as an index into both our fmap list AND our container list. These two lists are conceptually a part of the same thing and should be unified. But what's concerning is that the "recursion level" isn't actually incremented or decremented at the same time that we add a layer to the fmap or container lists but instead is more touchy-feely, increasing when we find a new "file". To account for this shadiness, the size of the fmap and container lists has always been a little longer than our "max scan recursion" limit so we don't accidentally overflow the fmap or container arrays (!). I've implemented a single recursion-stack as an array, similar to before, which includes a pointer to each fmap at each layer, along with the size and type. Push and pop functions add and remove layers whenever a new fmap is added. A boolean argument when pushing indicates if the new layer represents a new buffer or new file (descriptor). A new buffer will reset the "nested fmap level" (described below). This commit also provides a solution for an issue where we detect embedded files more than once during scan recursion. For illustration, imagine a tarball named foo.tar.gz with this structure: | description | type | rec level | nested fmap level | | ------------------------- | ----- | --------- | ----------------- | | foo.tar.gz | GZ | 0 | 0 | | └── foo.tar | TAR | 1 | 0 | | ├── bar.zip | ZIP | 2 | 1 | | │   └── hola.txt | ASCII | 3 | 0 | | └── baz.exe | PE | 2 | 1 | But suppose baz.exe embeds a ZIP archive and a 7Z archive, like this: | description | type | rec level | nested fmap level | | ------------------------- | ----- | --------- | ----------------- | | baz.exe | PE | 0 | 0 | | ├── sfx.zip | ZIP | 1 | 1 | | │   └── hello.txt | ASCII | 2 | 0 | | └── sfx.7z | 7Z | 1 | 1 | |    └── world.txt | ASCII | 2 | 0 | (A) If we scan for embedded files at any layer, we may detect: | description | type | rec level | nested fmap level | | ------------------------- | ----- | --------- | ----------------- | | foo.tar.gz | GZ | 0 | 0 | | ├── foo.tar | TAR | 1 | 0 | | │ ├── bar.zip | ZIP | 2 | 1 | | │ │   └── hola.txt | ASCII | 3 | 0 | | │ ├── baz.exe | PE | 2 | 1 | | │ │ ├── sfx.zip | ZIP | 3 | 1 | | │ │ │   └── hello.txt | ASCII | 4 | 0 | | │ │ └── sfx.7z | 7Z | 3 | 1 | | │ │    └── world.txt | ASCII | 4 | 0 | | │ ├── sfx.zip | ZIP | 2 | 1 | | │ │   └── hello.txt | ASCII | 3 | 0 | | │ └── sfx.7z | 7Z | 2 | 1 | | │   └── world.txt | ASCII | 3 | 0 | | ├── sfx.zip | ZIP | 1 | 1 | | └── sfx.7z | 7Z | 1 | 1 | (A) is bad because it scans content more than once. Note that for the GZ layer, it may detect the ZIP and 7Z if the signature hits on the compressed data, which it might, though extracting the ZIP and 7Z will likely fail. The reason the above doesn't happen now is that we restrict embedded type scans for a bunch of archive formats to include GZ and TAR. (B) If we scan for embedded files at the foo.tar layer, we may detect: | description | type | rec level | nested fmap level | | ------------------------- | ----- | --------- | ----------------- | | foo.tar.gz | GZ | 0 | 0 | | └── foo.tar | TAR | 1 | 0 | | ├── bar.zip | ZIP | 2 | 1 | | │   └── hola.txt | ASCII | 3 | 0 | | ├── baz.exe | PE | 2 | 1 | | ├── sfx.zip | ZIP | 2 | 1 | | │   └── hello.txt | ASCII | 3 | 0 | | └── sfx.7z | 7Z | 2 | 1 | |    └── world.txt | ASCII | 3 | 0 | (B) is almost right. But we can achieve it easily enough only scanning for embedded content in the current fmap when the "nested fmap level" is 0. The upside is that it should safely detect all embedded content, even if it may think the sfz.zip and sfx.7z are in foo.tar instead of in baz.exe. The biggest risk I can think of affects ZIPs. SFXZIP detection is identical to ZIP detection, which is why we don't allow SFXZIP to be detected if insize of a ZIP. If we only allow embedded type scanning at fmap-layer 0 in each buffer, this will fail to detect the embedded ZIP if the bar.exe was not compressed in foo.zip and if non-compressed files extracted from ZIPs aren't extracted as new buffers: | description | type | rec level | nested fmap level | | ------------------------- | ----- | --------- | ----------------- | | foo.zip | ZIP | 0 | 0 | | └── bar.exe | PE | 1 | 1 | | └── sfx.zip | ZIP | 2 | 2 | Provided that we ensure all files extracted from zips are scanned in new buffers, option (B) should be safe. (C) If we scan for embedded files at the baz.exe layer, we may detect: | description | type | rec level | nested fmap level | | ------------------------- | ----- | --------- | ----------------- | | foo.tar.gz | GZ | 0 | 0 | | └── foo.tar | TAR | 1 | 0 | | ├── bar.zip | ZIP | 2 | 1 | | │   └── hola.txt | ASCII | 3 | 0 | | └── baz.exe | PE | 2 | 1 | | ├── sfx.zip | ZIP | 3 | 1 | | │   └── hello.txt | ASCII | 4 | 0 | | └── sfx.7z | 7Z | 3 | 1 | |    └── world.txt | ASCII | 4 | 0 | (C) is right. But it's harder to achieve. For this example we can get it by restricting 7ZSFX and ZIPSFX detection only when scanning an executable. But that may mean losing detection of archives embedded elsewhere. And we'd have to identify allowable container types for each possible embedded type, which would be very difficult. So this commit aims to solve the issue the (B)-way. Note that in all situations, we still have to scan with file typing enabled to determine if we need to reassign the current file type, such as re-identifying a Bzip2 archive as a DMG that happens to be Bzip2- compressed. Detection of DMG and a handful of other types rely on finding data partway through or near the ned of a file before reassigning the entire file as the new type. Other fixes and considerations in this commit: - The utf16 HTML parser has weak error handling, particularly with respect to creating a nested fmap for scanning the ascii decoded file. This commit cleans up the error handling and wraps the nested scan with the recursion-stack push()/pop() for correct recursion tracking. Before this commit, each container layer had a flag to indicate if the container layer is valid. We need something similar so that the cli_recursion_stack_get_*() functions ignore normalized layers. Details... Imagine an LDB signature for HTML content that specifies a ZIP container. If the signature actually alerts on the normalized HTML and you don't ignore normalized layers for the container check, it will appear as though the alert is in an HTML container rather than a ZIP container. This commit accomplishes this with a boolean you set in the scan context before scanning a new layer. Then when the new fmap is created, it will use that flag to set similar flag for the layer. The context flag is reset those that anything after this doesn't have that flag. The flag allows the new recursion_stack_get() function to ignore normalized layers when iterating the stack to return a layer at a requested index, negative or positive. Scanning normalized extracted/normalized javascript and VBA should also use the 'layer is normalized' flag. - This commit also fixes Heuristic.Broken.Executable alert for ELF files to make sure that: A) these only alert if cli_append_virus() returns CL_VIRUS (aka it respects the FP check). B) all broken-executable alerts for ELF only happen if the SCAN_HEURISTIC_BROKEN option is enabled. - This commit also cleans up the error handling in cli_magic_scan_dir(). This was needed so we could correctly apply the layer-is-normalized-flag to all VBA macros extracted to a directory when scanning the directory. - Also fix an issue where exceeding scan maximums wouldn't cause embedded file detection scans to abort. Granted we don't actually want to abort if max filesize or max recursion depth are exceeded... only if max scansize, max files, and max scantime are exceeded. Add 'abort_scan' flag to scan context, to protect against depending on correct error propagation for fatal conditions. Instead, setting this flag in the scan context should guarantee that a fatal condition deep in scan recursion isn't lost which result in more stuff being scanned instead of aborting. This shouldn't be necessary, but some status codes like CL_ETIMEOUT never used to be fatal and it's easier to do this than to verify every parser only returns CL_ETIMEOUT and other "fatal status codes" in fatal conditions. - Remove duplicate is_tar() prototype from filestypes.c and include is_tar.h instead. - Presently we create the fmap hash when creating the fmap. This wastes a bit of CPU if the hash is never needed. Now that we're creating fmap's for all embedded files discovered with file type recognition scans, this is a much more frequent occurence and really slows things down. This commit fixes the issue by only creating fmap hashes as needed. This should not only resolve the perfomance impact of creating fmap's for all embedded files, but also should improve performance in general. - Add allmatch check to the zip parser after the central-header meta match. That way we don't multiple alerts with the same match except in allmatch mode. Clean up error handling in the zip parser a tiny bit. - Fixes to ensure that the scan limits such as scansize, filesize, recursion depth, # of embedded files, and scantime are always reported if AlertExceedsMax (--alert-exceeds-max) is enabled. - Fixed an issue where non-fatal alerts for exceeding scan maximums may mask signature matches later on. I changed it so these alerts use the "possibly unwanted" alert-type and thus only alert if no other alerts were found or if all-match or heuristic-precedence are enabled. - Added the "Heuristics.Limits.Exceeded.*" events to the JSON metadata when the --gen-json feature is enabled. These will show up once under "ParseErrors" the first time a limit is exceeded. In the present implementation, only one limits-exceeded events will be added, so as to prevent a malicious or malformed sample from filling the JSON buffer with millions of events and using a tonne of RAM.
4 years ago
fmap_t *map = ctx->fmap;
uint32_t *ptrs = NULL;
void *decomp = NULL;
int fd = -1;
char *original_filepath = NULL;
char *install_filepath = NULL;
if (fmap_readn(map, &sis, SIZEOF_HEADER_UUIDS, sizeof(sis)) != sizeof(sis)) {
cli_dbgmsg("SIS: Unable to read header\n");
goto done;
}
/* cli_dbgmsg("SIS HEADER INFO: \nFile checksum: %x\nLangs: %d\nFiles: %d\nDeps: %d\nUsed langs: %d\nInstalled files: %d\nDest drive: %d\nCapabilities: %d\nSIS Version: %d\nFlags: %x\nType: %d\nVersion: %d.%d.%d\nLangs@: %x\nFiles@: %x\nDeps@: %x\nCerts@: %x\nName@: %x\nSig@: %x\nCaps@: %x\nUspace: %d\nNspace: %d\n\n", sis.filesum, sis.langs, sis.files, sis.deps, sis.ulangs, sis.instfiles, sis.drive, sis.caps, sis.version, sis.flags, sis.type, sis.verhi, sis.verlo, sis.versub, sis.plangs, sis.pfiles, sis.pdeps, sis.pcerts, sis.pnames, sis.psig, sis.pcaps, sis.uspace, sis.nspace);
*/
#if WORDS_BIGENDIAN != 0
sis.langs = EC16(sis.langs);
sis.files = EC16(sis.files);
sis.deps = EC16(sis.deps);
sis.flags = EC16(sis.flags);
sis.plangs = EC32(sis.plangs);
sis.pfiles = EC32(sis.pfiles);
sis.pdeps = EC32(sis.pdeps);
sis.pnames = EC32(sis.pnames);
sis.pcaps = EC32(sis.pcaps);
#endif
if (!sis.langs || sis.langs >= MAXLANG) {
cli_dbgmsg("SIS: Too many or too few languages found\n");
goto done;
}
14 years ago
pos = sis.plangs;
14 years ago
if (!(llangs = fmap_need_off_once(map, pos, sis.langs * sizeof(uint16_t)))) {
cli_dbgmsg("SIS: Unable to read languages\n");
goto done;
}
pos += sis.langs * sizeof(uint16_t);
if (!(alangs = cli_max_malloc(sis.langs * sizeof(char *)))) {
cli_dbgmsg("SIS: OOM\n");
goto done;
}
for (i = 0; i < sis.langs; i++)
alangs[i] = (size_t)EC16(llangs[i]) < MAXLANG ? sislangs[EC16(llangs[i])] : sislangs[0];
if (!sis.pnames) {
cli_dbgmsg("SIS: Application without a name?\n");
} else {
cli_dbgmsg("SIS: Application name:\n");
if (!spamsisnames(map, sis.pnames, sis.langs, alangs)) {
status = CL_EMEM;
goto done;
}
}
if (!sis.pcaps) {
cli_dbgmsg("SIS: Application without capabilities?\n");
} else {
cli_dbgmsg("SIS: Provides:\n");
if (!spamsisnames(map, sis.pcaps, sis.langs, alangs)) {
status = CL_EMEM;
goto done;
}
}
if (!sis.pdeps) {
cli_dbgmsg("SIS: No dependencies set for this application\n");
} else {
cli_dbgmsg("SIS: Depends on:\n");
for (i = 0; i < sis.deps; i++) {
struct {
uint32_t uid;
uint16_t verhi;
uint16_t verlo;
uint32_t versub;
} dep;
pos = sis.pdeps + i * (sizeof(dep) + sis.langs * 2 * sizeof(uint32_t));
if (fmap_readn(map, &dep, pos, sizeof(dep)) != sizeof(dep)) {
cli_dbgmsg("SIS: Unable to read dependencies\n");
} else {
pos += sizeof(dep);
cli_dbgmsg("\tUID: %x v. %d.%d.%d\n\taka:\n", EC32(dep.uid), EC16(dep.verhi), EC16(dep.verlo), EC32(dep.versub));
if (!spamsisnames(map, pos, sis.langs, alangs)) {
status = CL_EMEM;
goto done;
}
}
}
}
compd = !(sis.flags & 0x0008);
cli_dbgmsg("SIS: Package is%s compressed\n", (compd) ? "" : " not");
if (SIZEOF_HEADER_UUIDS + sizeof(sis) > sis.pfiles) {
cli_dbgmsg("SIS: Invalid SIS format or not an SIS file. The pointer to the file records must not point to within the SIS header: %u\n", sis.pfiles);
goto done;
}
pos = sis.pfiles;
for (i = 0; i < sis.files; i++) {
uint32_t pkgtype, fcount = 1;
uint32_t j;
GETD2(pkgtype);
cli_dbgmsg("SIS: Pkgtype: %d\n", pkgtype);
switch (pkgtype) {
case PKGlangfile:
fcount = sis.langs;
break;
case PKGfile: {
uint32_t ftype, options, ssname, psname, sdname, pdname;
const char *sftype;
uint32_t *lens, *olens;
fcount = sis.langs;
GETD2(ftype);
GETD2(options);
GETD2(ssname);
GETD2(psname);
GETD2(sdname);
GETD2(pdname);
switch (ftype) {
case FTsimple:
sftype = "simple";
break;
case FTtext:
sftype = "text";
break;
case FTcomponent:
sftype = "component";
break;
case FTrun:
sftype = "run";
break;
case FTnull:
sftype = "null";
break;
case FTmime:
sftype = "mime";
break;
case FTsubsis:
sftype = "sub sis";
break;
case FTcontsis:
sftype = "container sis";
break;
case FTtextuninst:
sftype = "uninstall text";
break;
case FTnotinst:
sftype = "not to be installed";
break;
default:
sftype = "unknown";
}
cli_dbgmsg("SIS: File details:\n\tOptions: %d\n\tType: %s\n", options, sftype);
if ((original_filepath = getsistring(map, psname, ssname))) {
cli_dbgmsg("\tOriginal filename: %s\n", original_filepath);
/* We'll keep the original filepath around to pass to the scan function */
}
if ((install_filepath = getsistring(map, pdname, sdname))) {
cli_dbgmsg("\tInstalled to: %s\n", install_filepath);
CLI_FREE_AND_SET_NULL(install_filepath);
}
if (!(ptrs = cli_max_malloc(fcount * sizeof(uint32_t) * 3))) {
cli_dbgmsg("\tOOM\n");
status = CL_EMEM;
goto done;
}
lens = &ptrs[fcount];
olens = &ptrs[fcount * 2];
for (j = 0; j < fcount; j++)
GETD2(lens[j]);
for (j = 0; j < fcount; j++)
GETD2(ptrs[j]);
for (j = 0; j < fcount; j++)
GETD2(olens[j]);
if (ftype != FTnull) {
char ofn[1024];
/*
* There should be 1 version of the file for each language.
*/
for (j = 0; j < fcount; j++) {
const void *comp;
const void *decompp = NULL;
uLongf olen;
if (!lens[j]) {
cli_dbgmsg("\tSkipping empty file\n");
continue;
}
if (SIZEOF_HEADER_UUIDS + sizeof(sis) > ptrs[j]) {
cli_dbgmsg("\tThe pointer (offset) of the file in the archive cannot be within the SIS header: %u\n", ptrs[j]);
continue;
}
if (cli_checklimits("sis", ctx, lens[j], 0, 0) != CL_CLEAN) continue;
cli_dbgmsg("\tUnpacking lang#%d - ptr:%x compressed size:%x original (decompressed) size:%x\n", j, ptrs[j], lens[j], olens[j]);
if (!(comp = fmap_need_off_once(map, ptrs[j], lens[j]))) {
cli_dbgmsg("\tSkipping ghost or otherwise out of archive file\n");
continue;
}
if (compd) {
/*
* The compressed flag was set. Try to decompress it.
*/
if (olens[j] <= lens[j] * 3 && cli_checklimits("sis", ctx, lens[j] * 3, 0, 0) == CL_CLEAN)
olen = lens[j] * 3;
else if (cli_checklimits("sis", ctx, olens[j], 0, 0) == CL_CLEAN)
olen = olens[j];
else {
continue;
}
if (!(decomp = cli_max_malloc(olen))) {
cli_dbgmsg("\tOOM\n");
goto done;
}
if (uncompress(decomp, &olen, comp, lens[j]) != Z_OK) {
cli_dbgmsg("\tUnpacking failure\n");
CLI_FREE_AND_SET_NULL(decomp);
continue;
}
decompp = decomp;
} else {
/*
* File not compressed, scan it as-is.
*/
olen = lens[j];
decompp = comp;
}
snprintf(ofn, 1024, "%s" PATHSEP "sis%02d", tmpd, umped);
ofn[1023] = '\0';
if ((fd = open(ofn, O_RDWR | O_CREAT | O_TRUNC | O_BINARY, 0600)) == -1) {
cli_errmsg("SIS: unable to create output file %s - aborting.", ofn);
status = CL_ECREAT;
goto done;
}
if (cli_writen(fd, decompp, olen) != olen) {
status = CL_EWRITE;
goto done;
}
CLI_FREE_AND_SET_NULL(decomp);
status = cli_magic_scan_desc(fd, ofn, ctx, original_filepath, LAYER_ATTRIBUTES_NONE);
if (CL_SUCCESS != status) {
goto done;
}
close(fd);
fd = -1;
umped++;
}
}
CLI_FREE_AND_SET_NULL(original_filepath);
CLI_FREE_AND_SET_NULL(ptrs);
fcount = 2 * sizeof(uint32_t);
break;
}
case PKGoption:
cli_dbgmsg("SIS: I'm an option\n");
GETD2(fcount);
fcount *= sis.langs * 2 * sizeof(uint32_t);
break;
case PKGif:
cli_dbgmsg("SIS: #if\n");
GETD2(fcount);
break;
case PKGelsif:
cli_dbgmsg("SIS: #elsif\n");
GETD2(fcount);
break;
case PKGelse:
cli_dbgmsg("SIS: #else\n");
fcount = 0;
break;
case PKGendif:
cli_dbgmsg("SIS: #endif\n");
fcount = 0;
break;
default:
cli_dbgmsg("SIS: Unknown PKGtype, expect troubles\n");
fcount = 0;
}
SKIP(fcount);
}
status = CL_CLEAN;
done:
if (-1 != fd) {
close(fd);
}
CLI_FREE_AND_SET_NULL(original_filepath);
CLI_FREE_AND_SET_NULL(decomp);
CLI_FREE_AND_SET_NULL(ptrs);
CLI_FREE_AND_SET_NULL(alangs);
return status;
}
/*************************************************
This is the handler for the new (post 9.x)
SIS file format.
*************************************************/
enum { T_INVALID,
T_STRING,
T_ARRAY,
T_COMPRESSED,
T_VERSION,
T_VERSIONRANGE,
T_DATE,
T_TIME,
T_DATETIME,
T_UID,
T_UNUSED,
T_LANGUAGE,
T_CONTENTS,
T_CONTROLLER,
T_INFO,
T_SUPPORTEDLANGUAGES,
T_SUPPORTEDOPTIONS,
T_PREREQUISITES,
T_DEPENDENCY,
T_PROPERTIES,
T_PROPERTY,
T_SIGNATURES,
T_CERTIFICATECHAIN,
T_LOGO,
T_FILEDESCRIPTION,
T_HASH,
T_IF,
T_ELSEIF,
T_INSTALLBLOCK,
T_EXPRESSION,
T_DATA,
T_DATAUNIT,
T_FILEDATA,
T_SUPPORTEDOPTION,
T_CONTROLLERCHECKSUM,
T_DATACHECKSUM,
T_SIGNATURE,
T_BLOB,
T_SIGNATUREALGORITHM,
T_SIGNATURECERTIFICATECHAIN,
T_DATAINDEX,
T_CAPABILITIES,
T_MAXVALUE };
const char *sisfields[] = {"Invalid", "String", "Array", "Compressed", "Version", "VersionRange", "Date", "Time", "DateTime", "Uid", "Unused", "Language", "Contents", "Controller", "Info", "SupportedLanguages", "SupportedOptions", "Prerequisites", "Dependency", "Properties", "Property", "Signatures", "CertificateChain", "Logo", "FileDescription", "Hash", "If", "ElseIf", "InstallBlock", "Expression", "Data", "DataUnit", "FileData", "SupportedOption", "ControllerChecksum", "DataChecksum", "Signature", "Blob", "SignatureAlgorithm", "SignatureCertificateChain", "DataIndex", "Capabilities"};
#define ALIGN4(x) (((x) & ~3) + ((((x)&1) | (((x) >> 1) & 1)) << 2))
#define HERE printf("here\n"), abort();
struct SISTREAM {
fmap_t *map;
size_t pos;
uint8_t buff[BUFSIZ];
uint32_t smax;
uint32_t sleft;
long fnext[7];
uint32_t fsize[7];
unsigned int level;
};
static inline int getd(struct SISTREAM *s, uint32_t *v)
{
if (s->sleft < 4) {
size_t nread;
memcpy(s->buff, s->buff + s->smax - s->sleft, s->sleft);
nread = fmap_readn(s->map, &s->buff[s->sleft], s->pos, BUFSIZ - s->sleft);
if ((nread == (size_t)-1) || ((s->sleft = s->smax = nread + s->sleft) < 4)) {
return 1;
}
s->pos += nread;
}
*v = cli_readint32(&s->buff[s->smax - s->sleft]);
s->sleft -= 4;
return 0;
}
static inline int getsize(struct SISTREAM *s)
{
uint32_t *fsize = &s->fsize[s->level];
if (getd(s, fsize) || !*fsize || (*fsize) >> 31 || (s->level && *fsize > s->fsize[s->level - 1] * 2)) return 1;
/* To handle crafted archives we allow the content to overflow the container but only up to 2 times the container size */
s->fnext[s->level] = s->pos - s->sleft + *fsize;
return 0;
}
static inline int getfield(struct SISTREAM *s, uint32_t *field)
{
int ret;
if (!(ret = getd(s, field)))
ret = getsize(s);
if (!ret) {
if (*field < T_MAXVALUE)
cli_dbgmsg("SIS: %d:Got %s(%x) field with size %x\n", s->level, sisfields[*field], *field, s->fsize[s->level]);
else
cli_dbgmsg("SIS: %d:Got invalid(%x) field with size %x\n", s->level, *field, s->fsize[s->level]);
}
return ret;
}
static inline int skip(struct SISTREAM *s, uint32_t size)
{
long seekto;
cli_dbgmsg("SIS: skipping %x\n", size);
if (s->sleft >= size)
s->sleft -= size;
else {
seekto = size - s->sleft;
if (seekto < 0) /* in case sizeof(long)==sizeof(uint32_t) */
return 1;
s->pos += seekto;
/* s->sleft = s->smax = fread(s->buff,1,BUFSIZ,s->f); */
s->sleft = s->smax = 0;
}
return 0;
}
static inline int skipthis(struct SISTREAM *s)
{
return skip(s, ALIGN4(s->fsize[s->level]));
}
static inline void seeknext(struct SISTREAM *s)
{
s->pos = s->fnext[s->level];
/* s->sleft = s->smax = fread(s->buff,1,BUFSIZ,s->f); */
s->sleft = s->smax = 0;
}
static cl_error_t real_scansis9x(cli_ctx *ctx, const char *tmpd)
{
cl_error_t ret;
struct SISTREAM stream;
struct SISTREAM *s = &stream;
uint32_t field, optst[] = {T_CONTROLLERCHECKSUM, T_DATACHECKSUM, T_COMPRESSED};
unsigned int i;
libclamav: Fix scan recursion tracking Scan recursion is the process of identifying files embedded in other files and then scanning them, recursively. Internally this process is more complex than it may sound because a file may have multiple layers of types before finding a new "file". At present we treat the recursion count in the scanning context as an index into both our fmap list AND our container list. These two lists are conceptually a part of the same thing and should be unified. But what's concerning is that the "recursion level" isn't actually incremented or decremented at the same time that we add a layer to the fmap or container lists but instead is more touchy-feely, increasing when we find a new "file". To account for this shadiness, the size of the fmap and container lists has always been a little longer than our "max scan recursion" limit so we don't accidentally overflow the fmap or container arrays (!). I've implemented a single recursion-stack as an array, similar to before, which includes a pointer to each fmap at each layer, along with the size and type. Push and pop functions add and remove layers whenever a new fmap is added. A boolean argument when pushing indicates if the new layer represents a new buffer or new file (descriptor). A new buffer will reset the "nested fmap level" (described below). This commit also provides a solution for an issue where we detect embedded files more than once during scan recursion. For illustration, imagine a tarball named foo.tar.gz with this structure: | description | type | rec level | nested fmap level | | ------------------------- | ----- | --------- | ----------------- | | foo.tar.gz | GZ | 0 | 0 | | └── foo.tar | TAR | 1 | 0 | | ├── bar.zip | ZIP | 2 | 1 | | │   └── hola.txt | ASCII | 3 | 0 | | └── baz.exe | PE | 2 | 1 | But suppose baz.exe embeds a ZIP archive and a 7Z archive, like this: | description | type | rec level | nested fmap level | | ------------------------- | ----- | --------- | ----------------- | | baz.exe | PE | 0 | 0 | | ├── sfx.zip | ZIP | 1 | 1 | | │   └── hello.txt | ASCII | 2 | 0 | | └── sfx.7z | 7Z | 1 | 1 | |    └── world.txt | ASCII | 2 | 0 | (A) If we scan for embedded files at any layer, we may detect: | description | type | rec level | nested fmap level | | ------------------------- | ----- | --------- | ----------------- | | foo.tar.gz | GZ | 0 | 0 | | ├── foo.tar | TAR | 1 | 0 | | │ ├── bar.zip | ZIP | 2 | 1 | | │ │   └── hola.txt | ASCII | 3 | 0 | | │ ├── baz.exe | PE | 2 | 1 | | │ │ ├── sfx.zip | ZIP | 3 | 1 | | │ │ │   └── hello.txt | ASCII | 4 | 0 | | │ │ └── sfx.7z | 7Z | 3 | 1 | | │ │    └── world.txt | ASCII | 4 | 0 | | │ ├── sfx.zip | ZIP | 2 | 1 | | │ │   └── hello.txt | ASCII | 3 | 0 | | │ └── sfx.7z | 7Z | 2 | 1 | | │   └── world.txt | ASCII | 3 | 0 | | ├── sfx.zip | ZIP | 1 | 1 | | └── sfx.7z | 7Z | 1 | 1 | (A) is bad because it scans content more than once. Note that for the GZ layer, it may detect the ZIP and 7Z if the signature hits on the compressed data, which it might, though extracting the ZIP and 7Z will likely fail. The reason the above doesn't happen now is that we restrict embedded type scans for a bunch of archive formats to include GZ and TAR. (B) If we scan for embedded files at the foo.tar layer, we may detect: | description | type | rec level | nested fmap level | | ------------------------- | ----- | --------- | ----------------- | | foo.tar.gz | GZ | 0 | 0 | | └── foo.tar | TAR | 1 | 0 | | ├── bar.zip | ZIP | 2 | 1 | | │   └── hola.txt | ASCII | 3 | 0 | | ├── baz.exe | PE | 2 | 1 | | ├── sfx.zip | ZIP | 2 | 1 | | │   └── hello.txt | ASCII | 3 | 0 | | └── sfx.7z | 7Z | 2 | 1 | |    └── world.txt | ASCII | 3 | 0 | (B) is almost right. But we can achieve it easily enough only scanning for embedded content in the current fmap when the "nested fmap level" is 0. The upside is that it should safely detect all embedded content, even if it may think the sfz.zip and sfx.7z are in foo.tar instead of in baz.exe. The biggest risk I can think of affects ZIPs. SFXZIP detection is identical to ZIP detection, which is why we don't allow SFXZIP to be detected if insize of a ZIP. If we only allow embedded type scanning at fmap-layer 0 in each buffer, this will fail to detect the embedded ZIP if the bar.exe was not compressed in foo.zip and if non-compressed files extracted from ZIPs aren't extracted as new buffers: | description | type | rec level | nested fmap level | | ------------------------- | ----- | --------- | ----------------- | | foo.zip | ZIP | 0 | 0 | | └── bar.exe | PE | 1 | 1 | | └── sfx.zip | ZIP | 2 | 2 | Provided that we ensure all files extracted from zips are scanned in new buffers, option (B) should be safe. (C) If we scan for embedded files at the baz.exe layer, we may detect: | description | type | rec level | nested fmap level | | ------------------------- | ----- | --------- | ----------------- | | foo.tar.gz | GZ | 0 | 0 | | └── foo.tar | TAR | 1 | 0 | | ├── bar.zip | ZIP | 2 | 1 | | │   └── hola.txt | ASCII | 3 | 0 | | └── baz.exe | PE | 2 | 1 | | ├── sfx.zip | ZIP | 3 | 1 | | │   └── hello.txt | ASCII | 4 | 0 | | └── sfx.7z | 7Z | 3 | 1 | |    └── world.txt | ASCII | 4 | 0 | (C) is right. But it's harder to achieve. For this example we can get it by restricting 7ZSFX and ZIPSFX detection only when scanning an executable. But that may mean losing detection of archives embedded elsewhere. And we'd have to identify allowable container types for each possible embedded type, which would be very difficult. So this commit aims to solve the issue the (B)-way. Note that in all situations, we still have to scan with file typing enabled to determine if we need to reassign the current file type, such as re-identifying a Bzip2 archive as a DMG that happens to be Bzip2- compressed. Detection of DMG and a handful of other types rely on finding data partway through or near the ned of a file before reassigning the entire file as the new type. Other fixes and considerations in this commit: - The utf16 HTML parser has weak error handling, particularly with respect to creating a nested fmap for scanning the ascii decoded file. This commit cleans up the error handling and wraps the nested scan with the recursion-stack push()/pop() for correct recursion tracking. Before this commit, each container layer had a flag to indicate if the container layer is valid. We need something similar so that the cli_recursion_stack_get_*() functions ignore normalized layers. Details... Imagine an LDB signature for HTML content that specifies a ZIP container. If the signature actually alerts on the normalized HTML and you don't ignore normalized layers for the container check, it will appear as though the alert is in an HTML container rather than a ZIP container. This commit accomplishes this with a boolean you set in the scan context before scanning a new layer. Then when the new fmap is created, it will use that flag to set similar flag for the layer. The context flag is reset those that anything after this doesn't have that flag. The flag allows the new recursion_stack_get() function to ignore normalized layers when iterating the stack to return a layer at a requested index, negative or positive. Scanning normalized extracted/normalized javascript and VBA should also use the 'layer is normalized' flag. - This commit also fixes Heuristic.Broken.Executable alert for ELF files to make sure that: A) these only alert if cli_append_virus() returns CL_VIRUS (aka it respects the FP check). B) all broken-executable alerts for ELF only happen if the SCAN_HEURISTIC_BROKEN option is enabled. - This commit also cleans up the error handling in cli_magic_scan_dir(). This was needed so we could correctly apply the layer-is-normalized-flag to all VBA macros extracted to a directory when scanning the directory. - Also fix an issue where exceeding scan maximums wouldn't cause embedded file detection scans to abort. Granted we don't actually want to abort if max filesize or max recursion depth are exceeded... only if max scansize, max files, and max scantime are exceeded. Add 'abort_scan' flag to scan context, to protect against depending on correct error propagation for fatal conditions. Instead, setting this flag in the scan context should guarantee that a fatal condition deep in scan recursion isn't lost which result in more stuff being scanned instead of aborting. This shouldn't be necessary, but some status codes like CL_ETIMEOUT never used to be fatal and it's easier to do this than to verify every parser only returns CL_ETIMEOUT and other "fatal status codes" in fatal conditions. - Remove duplicate is_tar() prototype from filestypes.c and include is_tar.h instead. - Presently we create the fmap hash when creating the fmap. This wastes a bit of CPU if the hash is never needed. Now that we're creating fmap's for all embedded files discovered with file type recognition scans, this is a much more frequent occurence and really slows things down. This commit fixes the issue by only creating fmap hashes as needed. This should not only resolve the perfomance impact of creating fmap's for all embedded files, but also should improve performance in general. - Add allmatch check to the zip parser after the central-header meta match. That way we don't multiple alerts with the same match except in allmatch mode. Clean up error handling in the zip parser a tiny bit. - Fixes to ensure that the scan limits such as scansize, filesize, recursion depth, # of embedded files, and scantime are always reported if AlertExceedsMax (--alert-exceeds-max) is enabled. - Fixed an issue where non-fatal alerts for exceeding scan maximums may mask signature matches later on. I changed it so these alerts use the "possibly unwanted" alert-type and thus only alert if no other alerts were found or if all-match or heuristic-precedence are enabled. - Added the "Heuristics.Limits.Exceeded.*" events to the JSON metadata when the --gen-json feature is enabled. These will show up once under "ParseErrors" the first time a limit is exceeded. In the present implementation, only one limits-exceeded events will be added, so as to prevent a malicious or malformed sample from filling the JSON buffer with millions of events and using a tonne of RAM.
4 years ago
s->map = ctx->fmap;
s->pos = 0;
s->smax = 0;
s->sleft = 0;
s->level = 0;
if (getfield(s, &field) || field != T_CONTENTS)
return CL_CLEAN;
s->level++;
for (i = 0; i < 3;) {
if (getfield(s, &field)) return CL_CLEAN;
for (; i < 3; i++) {
if (field == optst[i]) {
if (skipthis(s)) return CL_CLEAN;
i++;
break;
}
}
}
if (field != T_COMPRESSED) return CL_CLEAN;
i = 0;
while (1) { /* 1DATA */
if (getfield(s, &field) || field != T_DATA) break;
s->level++;
while (1) { /* DATA::ARRAY */
uint32_t atype;
if (getfield(s, &field) || field != T_ARRAY || getd(s, &atype) || atype != T_DATAUNIT || s->fsize[s->level] < 4) break;
s->fsize[s->level] -= 4;
s->level++;
while (s->fsize[s->level - 1] && !getsize(s)) { /* FOREACH DATA::ARRAY::DATAUNITs */
cli_dbgmsg("SIS: %d:Got dataunit element with size %x\n", s->level, s->fsize[s->level]);
if (ALIGN4(s->fsize[s->level]) < s->fsize[s->level - 1])
s->fsize[s->level - 1] -= ALIGN4(s->fsize[s->level]);
else
s->fsize[s->level - 1] = 0;
s->level++;
while (1) { /* DATA::ARRAY::DATAUNIT[x]::ARRAY */
if (getfield(s, &field) || field != T_ARRAY || getd(s, &atype) || atype != T_FILEDATA || s->fsize[s->level] < 4) break;
s->fsize[s->level] -= 4;
s->level++;
while (s->fsize[s->level - 1] && !getsize(s)) { /* FOREACH DATA::ARRAY::DATAUNIT[x]::ARRAY::FILEDATA */
uint32_t usize, usizeh, len;
void *src, *dst;
char tempf[1024];
uLongf uusize;
int fd;
cli_dbgmsg("SIS: %d:Got filedata element with size %x\n", s->level, s->fsize[s->level]);
if (ALIGN4(s->fsize[s->level]) < s->fsize[s->level - 1])
s->fsize[s->level - 1] -= ALIGN4(s->fsize[s->level]);
else
s->fsize[s->level - 1] = 0;
s->level++;
while (1) { /* DATA::ARRAY::DATAUNIT[x]::ARRAY::FILEDATA[x]::COMPRESSED */
if (getfield(s, &field) || field != T_COMPRESSED || getd(s, &field) || getd(s, &usize) || getd(s, &usizeh) || usizeh) break;
s->fsize[s->level] -= 12;
cli_dbgmsg("SIS: File is%s compressed - size %x -> %x\n", (field) ? "" : " not", s->fsize[s->level], usize);
snprintf(tempf, 1024, "%s" PATHSEP "sis9x%02d", tmpd, i++);
tempf[1023] = '\0';
s->pos -= (long)s->sleft;
s->sleft = s->smax = 0;
if (cli_checklimits("sis", ctx, ALIGN4(s->fsize[s->level]), 0, 0) != CL_CLEAN) break;
if (!(src = cli_max_malloc(ALIGN4(s->fsize[s->level])))) break;
len = ALIGN4(s->fsize[s->level]);
if ((uint32_t)fmap_readn(s->map, src, s->pos, len) != len) {
free(src);
break;
}
s->pos += len;
if (field) { /* compressed */
int zresult;
if (usize <= s->fsize[s->level] * 3 && cli_checklimits("sis", ctx, s->fsize[s->level] * 3, 0, 0) == CL_CLEAN)
uusize = s->fsize[s->level] * 3;
else if (cli_checklimits("sis", ctx, usize, 0, 0) == CL_CLEAN)
uusize = usize;
else {
free(src);
break;
}
if (!(dst = cli_max_malloc(uusize))) {
cli_dbgmsg("SIS: OOM\n");
free(src);
break;
}
zresult = uncompress(dst, &uusize, src, s->fsize[s->level]);
free(src);
if (zresult != Z_OK) {
cli_dbgmsg("SIS: Inflate failure (%d)\n", zresult);
free(dst);
break;
}
if ((uLongf)usize != uusize)
cli_dbgmsg("SIS: Warning: expected size %lx but got %lx\n", (uLongf)usize, uusize);
else
cli_dbgmsg("SIS: File successfully inflated\n");
} else { /* not compressed */
dst = src;
uusize = s->fsize[s->level];
}
if ((fd = open(tempf, O_RDWR | O_CREAT | O_TRUNC | O_BINARY, 0600)) == -1) {
cli_errmsg("SIS: unable to create output file %s - aborting.", tempf);
free(dst);
break;
}
if (cli_writen(fd, dst, uusize) != uusize) {
free(dst);
close(fd);
break;
}
free(dst);
ret = cli_magic_scan_desc(fd, tempf, ctx, NULL, LAYER_ATTRIBUTES_NONE);
if (CL_SUCCESS != ret) {
close(fd);
return ret;
}
close(fd);
break;
} /* DATA::ARRAY::DATAUNIT[x]::ARRAY::FILEDATA[x]::COMPRESSED */
s->level--;
seeknext(s);
} /* FOREACH DATA::ARRAY::DATAUNIT[x]::ARRAY::FILEDATAs */
s->level--;
break;
} /* DATA::ARRAY::DATAUNIT[x]::ARRAY */
s->level--;
seeknext(s);
} /* FOREACH DATA::ARRAY::DATAUNITs */
s->level--;
break;
} /* DATA::ARRAY */
s->level--;
seeknext(s);
}
return CL_CLEAN;
}
/*************************************************
An (incomplete) FSM approach to sis9x unpacking
maybe needed if sisdataindex gets exploited
*************************************************/
/* #include <stdio.h> */
/* #include <stdint.h> */
/* #include <stdlib.h> */
/* #include <string.h> */
/* #include <zlib.h> */
/* /\* FIXME: RESEEK before spamming strings if not compressed *\/ */
/* #define SPAMSARRAY(WHO) \ */
/* GETD(field); \ */
/* fsz-=4; \ */
/* if(field!=T_STRING) { \ */
/* printf(WHO" - Unexpected array type, skipping\n"); \ */
/* break; \ */
/* } \ */
/* while(fsz>4) { \ */
/* GETD(field); \ */
/* fsz-=4; \ */
/* if(field && fsz<=sleft && field<=fsz) { \ */
/* stringifycbuff(&cbuff[smax-sleft], field); \ */
/* printf(WHO" - \"%s\"\n", &cbuff[smax-sleft]); \ */
/* } else { \ */
/* printf(WHO" - Name not decoded\n"); \ */
/* break; \ */
/* } \ */
/* SKIP(ALIGN4(field)); \ */
/* fsz-=(ALIGN4(field)); \ */
/* if((int32_t)fsz<0) fsz=0; \ */
/* } */
/* enum { T_INVALID, T_STRING, T_ARRAY, T_COMPRESSED, T_VERSION, T_VERSIONRANGE, T_DATE, T_TIME, T_DATETIME, T_UID, T_UNUSED, T_LANGUAGE, T_CONTENTS, T_CONTROLLER, T_INFO, T_SUPPORTEDLANGUAGES, T_SUPPORTEDOPTIONS, T_PREREQUISITES, T_DEPENDENCY, T_PROPERTIES, T_PROPERTY, T_SIGNATURES, T_CERTIFICATECHAIN, T_LOGO, T_FILEDESCRIPTION, T_HASH, T_IF, T_ELSEIF, T_INSTALLBLOCK, T_EXPRESSION, T_DATA, T_DATAUNIT, T_FILEDATA, T_SUPPORTEDOPTION, T_CONTROLLERCHECKSUM, T_DATACHECKSUM, T_SIGNATURE, T_BLOB, T_SIGNATUREALGORITHM, T_SIGNATURECERTIFICATECHAIN, T_DATAINDEX, T_CAPABILITIES, T_MAXVALUE, CUST_SKIP }; */
/* #define GETD(VAR) \ */
/* if (cbuff) { \ */
/* if (sleft<4) { \ */
Spelling Adjustments (#30) * spelling: accessed * spelling: alignment * spelling: amalgamated * spelling: answers * spelling: another * spelling: acquisition * spelling: apitid * spelling: ascii * spelling: appending * spelling: appropriate * spelling: arbitrary * spelling: architecture * spelling: asynchronous * spelling: attachments * spelling: argument * spelling: authenticode * spelling: because * spelling: boundary * spelling: brackets * spelling: bytecode * spelling: calculation * spelling: cannot * spelling: changes * spelling: check * spelling: children * spelling: codegen * spelling: commands * spelling: container * spelling: concatenated * spelling: conditions * spelling: continuous * spelling: conversions * spelling: corresponding * spelling: corrupted * spelling: coverity * spelling: crafting * spelling: daemon * spelling: definition * spelling: delivered * spelling: delivery * spelling: delimit * spelling: dependencies * spelling: dependency * spelling: detection * spelling: determine * spelling: disconnects * spelling: distributed * spelling: documentation * spelling: downgraded * spelling: downloading * spelling: endianness * spelling: entities * spelling: especially * spelling: empty * spelling: expected * spelling: explicitly * spelling: existent * spelling: finished * spelling: flexibility * spelling: flexible * spelling: freshclam * spelling: functions * spelling: guarantee * spelling: hardened * spelling: headaches * spelling: heighten * spelling: improper * spelling: increment * spelling: indefinitely * spelling: independent * spelling: inaccessible * spelling: infrastructure Conflicts: docs/html/node68.html * spelling: initializing * spelling: inited * spelling: instream * spelling: installed * spelling: initialization * spelling: initialize * spelling: interface * spelling: intrinsics * spelling: interpreter * spelling: introduced * spelling: invalid * spelling: latency * spelling: lawyers * spelling: libclamav * spelling: likelihood * spelling: loop * spelling: maximum * spelling: million * spelling: milliseconds * spelling: minimum * spelling: minzhuan * spelling: multipart * spelling: misled * spelling: modifiers * spelling: notifying * spelling: objects * spelling: occurred * spelling: occurs * spelling: occurrences * spelling: optimization * spelling: original * spelling: originated * spelling: output * spelling: overridden * spelling: parenthesis * spelling: partition * spelling: performance * spelling: permission * spelling: phishing * spelling: portions * spelling: positives * spelling: preceded * spelling: properties * spelling: protocol * spelling: protos * spelling: quarantine * spelling: recursive * spelling: referring * spelling: reorder * spelling: reset * spelling: resources * spelling: resume * spelling: retrieval * spelling: rewrite * spelling: sanity * spelling: scheduled * spelling: search * spelling: section * spelling: separator * spelling: separated * spelling: specify * spelling: special * spelling: statement * spelling: streams * spelling: succession * spelling: suggests * spelling: superfluous * spelling: suspicious * spelling: synonym * spelling: temporarily * spelling: testfiles * spelling: transverse * spelling: turkish * spelling: typos * spelling: unable * spelling: unexpected * spelling: unexpectedly * spelling: unfinished * spelling: unfortunately * spelling: uninitialized * spelling: unlocking * spelling: unnecessary * spelling: unpack * spelling: unrecognized * spelling: unsupported * spelling: usable * spelling: wherever * spelling: wishlist * spelling: white * spelling: infrastructure * spelling: directories * spelling: overridden * spelling: permission * spelling: yesterday * spelling: initialization * spelling: intrinsics * space adjustment for spelling changes * minor modifications by klin
7 years ago
/* printf("Unexpectedly reached end of compressed buffer\n"); \ */
/* free(cbuff); \ */
/* cbuff=NULL; \ */
/* smax=sleft=0; \ */
/* } else { \ */
/* VAR = cli_readint32(&cbuff[smax-sleft]); \ */
/* sleft-=4; \ */
/* } \ */
/* } else { \ */
/* if (sleft<4) { \ */
/* memcpy(buff, buff+smax-sleft, sleft); \ */
/* if ((smax=fread(buff+sleft,1,BUFSIZ-sleft,f)+sleft)<4) { \ */
/* printf("EOF\n"); \ */
/* return -1; \ */
/* } \ */
/* sleft=smax; \ */
/* } \ */
/* VAR = cli_readint32(&buff[smax-sleft]); \ */
/* sleft-=4; \ */
/* } */
/* #define SKIP(N) \ */
/* if (cbuff && sleft<=(N)) { \ */
/* free(cbuff); \ */
/* cbuff=NULL; \ */
/* smax=sleft=0; \ */
/* } \ */
/* if (sleft>=(N)) sleft-=(N); \ */
/* else { \ */
/* if ((ssize_t)((N)-sleft)<0) { \ */
/* printf("Refusing to seek back\n"); \ */
/* return -1; \ */
/* } \ */
/* fseek(f, (N)-sleft, SEEK_CUR); \ */
/* sleft=smax=fread(buff,1,BUFSIZ,f); \ */
/* } */
/* #define RESEEK() \ */
/* if (!cbuff) { \ */
/* fseek(f, -(long)sleft, SEEK_CUR); \ */
/* sleft=smax=fread(buff,1,BUFSIZ,f); \ */
/* } */
/* #define GETSZ \ */
/* GETD(fsz); \ */
/* if(fsz>>31) { \ */
/* printf("Size too big\n"); \ */
/* return -1; \ */
/* } */
/* #define GETSIZE(TREE) \ */
/* GETD(fsz); \ */
/* if(!fsz || (fsz>>31)) { \ */
/* printf(TREE" - Wrong field size\n"); \ */
/* goto SIS_ERROR; \ */
/* } */
/* static void stringifycbuff(uint8_t *ptr, uint32_t len) { */
/* uint32_t i; */
/* if (len>400) len=400; */
/* for(i = 0 ; i < len; i+=2) ptr[i/2] = ptr[i]; */
/* ptr[i/2]='\0'; */
/* return; */
/* } */
/* const char *sisfields[] = {"Invalid", "String", "Array", "Compressed", "Version", "VersionRange", "Date", "Time", "DateTime", "Uid", "Unused", "Language", "Contents", "Controller", "Info", "SupportedLanguages", "SupportedOptions", "Prerequisites", "Dependency", "Properties", "Property", "Signatures", "CertificateChain", "Logo", "FileDescription", "Hash", "If", "ElseIf", "InstallBlock", "Expression", "Data", "DataUnit", "FileData", "SupportedOption", "ControllerChecksum", "DataChecksum", "Signature", "Blob", "SignatureAlgorithm", "SignatureCertificateChain", "DataIndex", "Capabilities", "PLACEHOLDER"}; */
/* const char *sislangs[] = {"UNKNOWN", "UK English","French", "German", "Spanish", "Italian", "Swedish", "Danish", "Norwegian", "Finnish", "American", "Swiss French", "Swiss German", "Portuguese", "Turkish", "Icelandic", "Russian", "Hungarian", "Dutch", "Belgian Flemish", "Australian English", "Belgian French", "Austrian German", "New Zealand English", "International French", "Czech", "Slovak", "Polish", "Slovenian", "Taiwanese Chinese", "Hong Kong Chinese", "PRC Chinese", "Japanese", "Thai", "Afrikaans", "Albanian", "Amharic", "Arabic", "Armenian", "Tagalog", "Belarussian", "Bengali", "Bulgarian", "Burmese", "Catalan", "Croation", "Canadian English", "International English", "South African English", "Estonian", "Farsi", "Canadian French", "Gaelic", "Georgian", "Greek", "Cyprus Greek", "Gujarati", "Hebrew", "Hindi", "Indonesian", "Irish", "Swiss Italian", "Kannada", "Kazakh", "Kmer", "Korean", "Lao", "Latvian", "Lithuanian", "Macedonian", "Malay", "Malayalam", "Marathi", "Moldovian", "Mongolian", "Norwegian Nynorsk", "Brazilian Portuguese", "Punjabi", "Romanian", "Serbian", "Sinhalese", "Somali", "International Spanish", "American Spanish", "Swahili", "Finland Swedish", "Reserved", "Tamil", "Telugu", "Tibetan", "Tigrinya", "Cyprus Turkish", "Turkmen", "Ukrainian", "Urdu", "Reserved", "Vietnamese", "Welsh", "Zulu", "Other"}; */
/* #define MAXLANG (sizeof(sislangs)/sizeof(sislangs[0])) */
/* int main(int argc, char **argv) { */
/* FILE *f = fopen(argv[1], "r"); */
/* uint32_t uid[4]; */
/* unsigned int i, sleft=0, smax=0, level=0; */
/* uint8_t buff[BUFSIZ], *cbuff=NULL; */
/* uint32_t field, fsz; */
/* int ret = 0; */
/* struct { */
/* char tree[200]; */
/* unsigned int next[200]; */
/* unsigned int count; */
/* } sstack; */
/* const struct PIPPO { */
/* uint32_t expect; */
/* uint8_t optional; */
/* uint8_t dir; */
/* struct PIPPO *next; */
/* char *what; */
/* } s[] = { */
/* { T_CONTENTS, 0, 1, &s[1], ""}, */
/* { T_CONTROLLERCHECKSUM, 1, 0, &s[2], ""}, */
/* { T_DATACHECKSUM, 1, 0, &s[3], ""}, */
/* { T_COMPRESSED, 0, 1, &s[4], ""}, */
/* { T_CONTROLLER, 0, 1, &s[5], ""}, */
/* { T_INFO, 0, 1, &s[6], ""}, */
/* { T_UID, 0, 0, &s[7], "App UID"}, */
/* { T_STRING, 0, 0, &s[8], "Vendor name"}, */
/* { T_ARRAY, 0, 0, &s[9], "App names"}, */
/* { T_ARRAY, 0, 0, &s[10], "Vendor names"}, */
/* { T_VERSION, 0, 0, &s[11], "App Version"}, */
/* { T_DATETIME, 0, 0, &s[12], ""}, */
/* { T_DATE, 0, 0, &s[13], "Creation Date"}, */
/* { T_TIME, 0, 0, &s[14], "Creation Time"}, */
/* { CUST_SKIP, 4, 0, &s[15], ""}, */
/* { T_SUPPORTEDOPTIONS, 0, 2, &s[16], ""}, */
/* { T_SUPPORTEDLANGUAGES, 0, 1, &s[17], ""}, */
/* { T_ARRAY, 0, 0, &s[18], "Supported Languages"}, */
/* { T_PREREQUISITES, 0, 2, &s[19], ""}, */
/* { T_PROPERTIES, 0, 0, &s[20], ""}, */
/* { T_LOGO, 1, 0, &s[21], ""}, */
/* { T_INSTALLBLOCK, 0, 0, &s[22], ""}, */
/* { T_SIGNATURECERTIFICATECHAIN, 1, 0, &s[23], ""}, */
/* { T_DATAINDEX, 0, 0, &s[24], ""}, */
/* { T_DATA, 0, 3, NULL, NULL} */
/* }; */
/* struct PIPPO *this; */
/* struct { */
/* struct PIPPO s; */
/* uint32_t totalsize; */
/* struct PIPPO *next; */
/* } t_array; */
/* GETD(uid[0]); */
/* GETD(uid[1]); */
/* GETD(uid[2]); */
/* GETD(uid[3]); */
/* printf("UIDS: %x %x %x - %x\n",uid[0],uid[1],uid[2],uid[3]); */
/* sstack.next[0]=0; */
/* sstack.count=0; */
/* for (this=&s[0]; this; this=this->next) { */
/* if(this->expect==CUST_SKIP) { */
/* SKIP(this->optional); */
/* continue; */
/* } */
/* if (this!=&t_array) { */
/* GETD(field); */
/* GETSIZE("FIXME"); */
/* } else { */
/* GETSIZE("FIXME"); */
/* if (t_array.totalsize<=(ALIGN4(fsz)+4)) */
/* this->next = t_array.next; */
/* t_array.totalsize-=ALIGN4(fsz)+4; */
/* field = this->expect; */
/* } */
/* if(field>=T_MAXVALUE) { */
/* printf("Bogus field found\n"); */
/* ret=-1; */
/* break; */
/* } */
/* for( ; this && this->optional && this->expect!=field; this=this->next) */
/* printf("Skipping optional state %s\n", sisfields[this->expect]); */
/* if(!this) { */
/* printf("Broken SIS file\n"); */
/* break; */
/* } */
/* if(!this->optional && this->expect!=field) { */
Spelling Adjustments (#30) * spelling: accessed * spelling: alignment * spelling: amalgamated * spelling: answers * spelling: another * spelling: acquisition * spelling: apitid * spelling: ascii * spelling: appending * spelling: appropriate * spelling: arbitrary * spelling: architecture * spelling: asynchronous * spelling: attachments * spelling: argument * spelling: authenticode * spelling: because * spelling: boundary * spelling: brackets * spelling: bytecode * spelling: calculation * spelling: cannot * spelling: changes * spelling: check * spelling: children * spelling: codegen * spelling: commands * spelling: container * spelling: concatenated * spelling: conditions * spelling: continuous * spelling: conversions * spelling: corresponding * spelling: corrupted * spelling: coverity * spelling: crafting * spelling: daemon * spelling: definition * spelling: delivered * spelling: delivery * spelling: delimit * spelling: dependencies * spelling: dependency * spelling: detection * spelling: determine * spelling: disconnects * spelling: distributed * spelling: documentation * spelling: downgraded * spelling: downloading * spelling: endianness * spelling: entities * spelling: especially * spelling: empty * spelling: expected * spelling: explicitly * spelling: existent * spelling: finished * spelling: flexibility * spelling: flexible * spelling: freshclam * spelling: functions * spelling: guarantee * spelling: hardened * spelling: headaches * spelling: heighten * spelling: improper * spelling: increment * spelling: indefinitely * spelling: independent * spelling: inaccessible * spelling: infrastructure Conflicts: docs/html/node68.html * spelling: initializing * spelling: inited * spelling: instream * spelling: installed * spelling: initialization * spelling: initialize * spelling: interface * spelling: intrinsics * spelling: interpreter * spelling: introduced * spelling: invalid * spelling: latency * spelling: lawyers * spelling: libclamav * spelling: likelihood * spelling: loop * spelling: maximum * spelling: million * spelling: milliseconds * spelling: minimum * spelling: minzhuan * spelling: multipart * spelling: misled * spelling: modifiers * spelling: notifying * spelling: objects * spelling: occurred * spelling: occurs * spelling: occurrences * spelling: optimization * spelling: original * spelling: originated * spelling: output * spelling: overridden * spelling: parenthesis * spelling: partition * spelling: performance * spelling: permission * spelling: phishing * spelling: portions * spelling: positives * spelling: preceded * spelling: properties * spelling: protocol * spelling: protos * spelling: quarantine * spelling: recursive * spelling: referring * spelling: reorder * spelling: reset * spelling: resources * spelling: resume * spelling: retrieval * spelling: rewrite * spelling: sanity * spelling: scheduled * spelling: search * spelling: section * spelling: separator * spelling: separated * spelling: specify * spelling: special * spelling: statement * spelling: streams * spelling: succession * spelling: suggests * spelling: superfluous * spelling: suspicious * spelling: synonym * spelling: temporarily * spelling: testfiles * spelling: transverse * spelling: turkish * spelling: typos * spelling: unable * spelling: unexpected * spelling: unexpectedly * spelling: unfinished * spelling: unfortunately * spelling: uninitialized * spelling: unlocking * spelling: unnecessary * spelling: unpack * spelling: unrecognized * spelling: unsupported * spelling: usable * spelling: wherever * spelling: wishlist * spelling: white * spelling: infrastructure * spelling: directories * spelling: overridden * spelling: permission * spelling: yesterday * spelling: initialization * spelling: intrinsics * space adjustment for spelling changes * minor modifications by klin
7 years ago
/* printf("Error: expected %s but found %s\n", sisfields[this->expect], sisfields[field]); */
/* goto SIS_ERROR; */
/* } */
/* printf("Got %s field (%d) with size %x(%u)\n", sisfields[field], field, fsz, fsz); */
/* switch(this->dir) { */
/* case 1: /\* up *\/ */
/* strncpy(&sstack.tree[sstack.next[sstack.count]], sisfields[field], 200-sstack.next[sstack.count]); */
/* strncat(sstack.tree, ":", 200); */
/* sstack.count++; */
/* sstack.tree[199]='\0'; */
/* sstack.next[sstack.count]=strlen(sstack.tree); */
/* break; */
/* case 0: */
/* sstack.count--; */
/* default: */
/* sstack.count-=this->dir-1; */
/* strncpy(&sstack.tree[sstack.next[sstack.count]], sisfields[field], 200-sstack.next[sstack.count]); */
/* strncat(sstack.tree, ":", 200); */
/* sstack.tree[199]='\0'; */
/* } */
/* printf("%s\n", sstack.tree); */
/* switch(field) { */
/* case T_CONTENTS: */
/* continue; */
/* case T_CONTROLLERCHECKSUM: */
/* break; */
/* case T_DATACHECKSUM: */
/* break; */
/* case T_COMPRESSED: */
/* if(cbuff) { */
/* printf("Found nested compressed streams, aborting\n"); */
/* goto SIS_ERROR; */
/* } else { */
/* uint32_t method; */
/* uint32_t usize; */
/* uint32_t misc; */
/* int zresult; */
/* uint8_t *dbuff; */
/* uLongf uusize; */
/* GETD(method); */
/* GETD(usize); */
/* GETD(misc); */
/* fsz-=12; */
/* if (misc) { */
/* printf("%s filesize too big\n", sstack.tree); */
/* goto SIS_ERROR; */
/* } */
/* printf("%s compression %d, size %d, usize %d\n", sstack.tree, method, fsz, usize); */
/* if(method) { */
/* fseek(f, -(long)sleft, SEEK_CUR); */
/* sleft=smax=0; */
/* uusize=usize; */
/* if(!(dbuff=malloc(ALIGN4(fsz)))) { */
/* printf("%s Out of memory\n", sstack.tree); */
/* goto SIS_ERROR; */
/* } */
/* if(!(cbuff=malloc(usize))) { */
/* free(dbuff); */
/* printf("%s Out of memory\n", sstack.tree); */
/* goto SIS_ERROR; */
/* } */
/* if (fread(dbuff,ALIGN4(fsz),1,f) != 1) { */
/* printf("%s Failed to read compressed data\n", sstack.tree); */
/* free(dbuff); */
/* goto SIS_ERROR; */
/* } */
/* zresult=uncompress(cbuff, &uusize, dbuff, fsz); */
/* free(dbuff); */
/* if (zresult!=Z_OK) { */
/* printf("%s Unpacking failure, skipping block\n", sstack.tree); */
/* goto SIS_ERROR; */
/* } */
/* if ((uLongf)usize != uusize) { */
/* printf("%s Expected size %lx but got %lx\n", sstack.tree, (uLongf)usize, uusize); */
/* goto SIS_ERROR; */
/* } */
/* smax=sleft=uusize; */
/* fwrite(cbuff, uusize, 1, fopen("/tmp/gunz", "w")); */
/* } */
/* continue; */
/* } */
/* case T_CONTROLLER: */
/* continue; */
/* case T_INFO: */
/* continue; */
/* case T_UID: */
/* GETD(field); */
/* fsz-=4; */
/* printf("%s %s = %x\n", sstack.tree, this->what, field); */
/* break; */
/* case T_STRING: */
/* RESEEK(); */
/* if(fsz && fsz<=sleft) { */
/* char *t=(cbuff)?&cbuff[smax-sleft]:&buff[smax-sleft]; */
/* stringifycbuff(t, fsz); */
/* printf("%s %s = \"%s\"\n", sstack.tree, this->what, t); */
/* } else printf("%s %s not decoded\n", sstack.tree, this->what); */
/* break; */
/* case T_ARRAY: */
/* GETD(field); */
/* fsz-=4; */
/* t_array.s.expect = field; */
/* t_array.s.optional = 0; */
/* t_array.s.dir = 0; */
/* t_array.s.next = &t_array; */
/* t_array.s.what = this->what; */
/* t_array.next = this->next; */
/* t_array.totalsize = ALIGN4(fsz); */
/* this = &t_array; */
/* continue; */
/* case T_VERSION: { */
/* uint32_t maj,min,bld; */
/* GETD(maj); */
/* GETD(min); */
/* GETD(bld); */
/* printf("%s %s = %u.%u.%u\n", sstack.tree, this->what, maj, min, bld); */
/* fsz-=12; */
/* break; */
/* } */
/* case T_DATETIME: */
/* continue; */
/* case T_DATE: */
/* GETD(field); */
/* fsz-=4; */
/* printf("%s %s = %u-%u-%u\n", sstack.tree, this->what, field&0xffff, (field>>16)&0xff, (field>>24)&0xff); */
/* break; */
/* case T_TIME: */
/* GETD(field); */
/* fsz-=4; /\* -1 aligns to 0 *\/ */
/* printf("%s %s = %u:%u:%u\n", sstack.tree, this->what, field&0xff, (field>>8)&0xff, (field>>16)&0xff); */
/* break; */
/* case T_SUPPORTEDOPTIONS: */
/* /\* FIXME: ANYTHING USEFUL HERE? *\/ */
/* break; */
/* case T_SUPPORTEDLANGUAGES: */
/* continue; */
/* case T_LANGUAGE: */
/* GETD(field); */
/* fsz-=4; */
/* printf("%s %s = \"%s\"\n", sstack.tree, this->what, field>=MAXLANG ? "Bad Language" : sislangs[field]); */
/* break; */
/* case T_PREREQUISITES: */
/* break; */
/* case T_PROPERTIES: */
/* break; */
/* case T_LOGO: */
/* break; */
/* case T_INSTALLBLOCK: */
/* break; */
/* case T_SIGNATURECERTIFICATECHAIN: */
/* t_array.s.expect = field; */
/* t_array.s.optional = 1; */
/* t_array.s.dir = 0; */
/* t_array.s.next = this; */
/* this = &t_array; */
/* break; */
/* case T_DATAINDEX: */
/* GETD(field); */
/* fsz-=4; */
/* printf("%s %s = %x\n", sstack.tree, this->what, field); */
/* if(cbuff) { */
/* if(ALIGN4(fsz) || sleft) */
/* printf("Trailing garbage found in compressed controller\n"); */
/* fsz=sleft=smax=0; */
/* free(cbuff); */
/* cbuff=NULL; */
/* } */
/* break; */
/* default: */
/* printf("Error: unhandled field %d\n", field); */
/* goto SIS_ERROR; */
/* } */
/* SKIP(ALIGN4(fsz)); */
/* } */
/* return 0; */
/* SIS_ERROR: */
/* if(cbuff) free(cbuff); */
/* fclose(f); */
/* return 0; */
/* } */