34 Commits (2e55c901b1b0571a340602ee2681255876f63f1a)

Author	SHA1	Message	Date
micasnyd	140c88aa4e	Bump copyright for 2022 ... Includes minor format corrections.	4 years ago
Micah Snyder (micasnyd)	9910d2d426	PDF: Fix error Attempt to allocate 0 bytes ... The PDF parser currently prints verbose error messages when attempting to shrink a buffer down to actual data length after decoding if it turns out that the decoded stream was empty (0 bytes). With exception to the verbose error messages, there's no real behavior issue. This commit fixes the issue by checking if any bytes were decoded before attempting to shrink the buffer.	6 years ago
Andy Ragusa (aragusa)	ba6467a6a6	Fixed memory leak reported by oss-fuzz. ... Added checks to see if realloc succeeds before reassigning the pointers, and made this file build without warnings when compiled with -Wextra.	6 years ago
Micah Snyder	dd4967ed55	Adds fallthrough hints to alleviate warnings on gcc with -Wextra.	6 years ago
Micah Snyder (micasnyd)	8a97a905d1	bb12387 - PDF scan speed optimization ... Users have reported slow scan speeds of some PDF documents. The scan speed was very slow on Windows in particular. Investigation indicated significant time spent in cli_realloc. Performance is particularly bad with a relatively large data stream is decompressed using small chunk sizes and the final buffer is reallocated to a larger buffer size each time a chunk is added. This commit replaces BUFSIZ, which varies from 256B -> 8192B, with INFLATE_CHUNK_SIZE, set to 256kB, the chunk size recommended by the zlib documentation for efficient inflate performance. The output buffer is shrunk (reallocated) down to the final decoded buffer length so as not to waste memory when many small buffers must be decompressed. A followup fix should provide a standard way to do zlib decompression across libclamav where a linked list of decompressed chunks are assembled and then the final output buffer is allocated at the end.	6 years ago
Micah Snyder	97a0647e88	Additional variable type changes for correctness and to silence warnings. A handful of other minor changes to silence warnings. Corrected a number of function definitions so they return cl_error_t rather than int.	6 years ago
Micah Snyder	5f4f69102d	Correcting types from int to cl_error_t where appropriate. Eliminating unused variables and referencing unused parameters to remove warnings.	6 years ago
Micah Snyder	479a9a235a	Fixes for issues identified by coverity.	6 years ago
Micah Snyder	72fd33c8b2	clang-format'd using new .clang-format rules.	6 years ago
Micah Snyder	38fe8b69a0	Added .clang-format style rules, clam-format script to automate formatting of ClamAV code, and preparing select files so that clang-format does not alter carefully formatted sections.	6 years ago
Micah Snyder	d77b8ae0fb	Fixes to a handful of bugs identified during regression testing of PDF and UnRAR changes. ... Fix for minor memory leak in fmap_dump_to_file(). Fix to PDF object stream logic, accounting for a realloc() issue when the only pdf object stream fails to parse, and for when pdf objects in a stream appear to extend further than the size of the stream. Fix for memory leak cleaning up PDF object stream buffer in error condition. Fix to bug in pdf_decodestream wherein objects were found in an object stream, but the object stream could later be free'd if max scansize was exceeded, resulting in a NULL dereference. General cleanup of pdf_decodestream/pdf_decodestream_internal exit code logic.	7 years ago
Micah Snyder	d7979d4ff7	Restructured scan options flags from a single bitflag field to a structure containing multiple bitflag fields. This also required adding a new function to the bytecode API to get scan options a la carte, and modifying the existing function to hand back scan options in the old/deprecated uint32_t bitflag format. Re-generated bytecode iface header files. ... Updated libclamav documentation detailing new scan options structure. Renamed references to 'algorithmic' detection to 'heuristic' detection. Renaming references to 'properties' to 'collect metadata'. Renamed references to 'scan all' to 'scan all match'. Renamed a couple of 'Hueristic.*' signature names as 'Heuristics.*' signatures (plural) to match majority of other heuristics.	7 years ago
Micah Snyder (micasnyd)	89d5207b31	Added new pdf object stream parsing capability.	7 years ago
Micah Snyder	e09d884341	eliminated a large number of warnings, many of which had to do with mixing types. i switched some types to size_t and a couple to ptrdiff_t to make things more consistent, but there is a huge amount of work to be done to make types consistent. int, unsigned int, unsigned, off_t, and other types are ill-suited to storing buffer lengths or memory addresses.	8 years ago
Steven Morgan	9807521cf2	Change some warning messages to debug messages.	9 years ago
Kevin Lin	fdcf5109d6	pdfdecode: reduced stream dumping conditions to just leave-temps + fix warnings	10 years ago
Kevin Lin	567c73ec69	lzwdec: modify dictionary max code points and change state flags	10 years ago
Kevin Lin	bfd8ca3eda	pdfdecode: return raw stream if no non-forced filters succeed	10 years ago
Kevin Lin	a081b3e946	pdfdecode: do not apply forced decryption to /XRef streams	10 years ago
Kevin Lin	046d4cc91b	pdfdecode: reduce errmsg to dbgmsg for log reduction	10 years ago
Kevin Lin	5c2915120a	pdfdecode: add dictionary heuristic and all-match support	10 years ago
Kevin Lin	ce3cf4c64f	pdfdecode: lzw dconf	10 years ago
Kevin Lin	e8a23886d2	pdfdecode: integrate lzw decompression	10 years ago
Kevin Lin	02c120e8f2	pdfdecode: change various debug messages for clarity	10 years ago
Kevin Lin	0018a8e792	pdfdecode: memory fixes for ascii85, reorganize initial crypt	10 years ago
Kevin Lin	7aad5a3b96	pdf: pdfdecode integration	10 years ago
Kevin Lin	639615af8d	pdfdecode: change condition for dumping intermediate filter buffers	10 years ago
Kevin Lin	a042e6f068	pdfdecode: add error flags in asciihex and ascii85	10 years ago
Kevin Lin	1d0cdc67c1	pdf: open abi for pdfdecode usage	10 years ago
Kevin Lin	d593717b09	pdfdecode: fixes, error code handling, and limit checks	10 years ago
Kevin Lin	07a7200626	pdfdecode: add dumping intermediate filter buffers	10 years ago
Kevin Lin	eaf5221181	pdfdecode: implement crypt filter handler	10 years ago
Kevin Lin	739e5052cc	pdfdecode: implement rldecode filter handler	10 years ago
Kevin Lin	7ded9e2955	pdfdecode: add new source for stream decoding (ascii85, asciihex, flate)	10 years ago