clamav

Commit Graph

Author	SHA1	Message	Date
ℕicolas ℝ	3710689577	Avoid altering signature for .cargo/vendor files When using the content of the `clamav` tarball in a git repository to version a debian or RedHat package for example. We should never alter the files from cargo or this result in corrupted signature and thus we cannot install the files. As the repo provides its own `.gitattributes` we cannot easily overwrite it without manually updating `.git/info/attributes`. Alternatively we could remove the `.gitattributes` file from the tarball when generating it.	2 years ago
Micah Snyder	afbf0b6180	Fix Windows text file EOL conversion issues On Windows, files open()'ed without the O_BINARY flag will have new-line LF (aka \n) converted to CRLF (aka \r\n) automatically when read from or written to. This is undesirable for all scan targets AND temp files because it affects pattern matching and with hashing. This commit converts a handful of instances throughout the codebase where it appears that O_BINARY was mistakenly omitted and could result in unexpected behavior on Windows. Git on Windows also converts LF -> CRLF for "text" files, for editing purposes. This is problematic for scan files and test files that should match verbatim. We can prevent this issue by marking .ref test files as "binary" in the .gitattributes file and by always opening scan files and temp files as binary. In this commit I've also removed the `ChangeLog merge=cl-merge` line that was once used to reduce ChangeLog merge conflicts by using the gnulib git-merge-changlog tool. This project now categorizes changes in the NEWS.md. For finer detail, git commit history is fully accessible on github.com.	4 years ago
Török Edvin	001b408e25	Add .gitattributes to set ChangeLog merge driver.	16 years ago

Author

SHA1

Message

Date

ℕicolas ℝ

3710689577

Avoid altering signature for .cargo/vendor files

When using the content of the `clamav` tarball in a git repository to version a debian or RedHat package for example.
We should never alter the files from cargo or this result in corrupted signature and thus we cannot install the files.

As the repo provides its own `.gitattributes` we cannot easily overwrite it without manually updating `.git/info/attributes`.

Alternatively we could remove the `.gitattributes` file from the tarball when generating it.

2 years ago

Micah Snyder

afbf0b6180

Fix Windows text file EOL conversion issues

On Windows, files open()'ed without the O_BINARY flag will have new-line
LF (aka \n) converted to CRLF (aka \r\n) automatically when read from or
written to. This is undesirable for all scan targets AND temp files
because it affects pattern matching and with hashing.

This commit converts a handful of instances throughout the codebase
where it appears that O_BINARY was mistakenly omitted and could result
in unexpected behavior on Windows.

Git on Windows also converts LF -> CRLF for "text" files, for editing
purposes.
This is problematic for scan files and test files that should match
verbatim.
We can prevent this issue by marking .ref test files as "binary" in the
.gitattributes file and by always opening scan files and temp files as
binary.

In this commit I've also removed the `ChangeLog merge=cl-merge` line
that was once used to reduce ChangeLog merge conflicts by using the
gnulib git-merge-changlog tool. This project now categorizes changes in
the NEWS.md.
For finer detail, git commit history is fully accessible on github.com.

4 years ago

Török Edvin

001b408e25

Add .gitattributes to set ChangeLog merge driver.

16 years ago

3 Commits (4a7ac7cc69361c974075bc6b6c595e20cd473324)