ClamAV is an open source (GPLv2) anti-virus toolkit.

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Micah Snyder 0354482e16 Fix issues reading from uncompressed nested files ... The fmap module provides a mechanism for creating a mapping into an existing map at an offset and length that's used when a file is found with an uncompressed archive or when embedded files are found with embedded file type recognition in scanraw(). This is the "fmap_duplicate()" function. Duplicate fmaps just reference the original fmap's 'data' or file handle/descriptor while allowing the caller to treat it like a new map using offsets and lengths that don't account for the original/actual file dimensions. fmap's keep track of this with m->nested_offset & m->real_len, which admittedly have confusing names. I found incorrect uses of these in a handful of locations. Notably: - In cli_magic_scan_nested_fmap_type(). The force-to-disk feature would have been checking incorrect sizes and may have written incorrect offsets for duplicate fmaps. - In XDP parser. - A bunch of places from the previous commit when making dupe maps. This commit fixes those and adds lots of documentation to the fmap.h API to try to prevent confusion in the future. nested_offset should never be referenced outside of fmap.c/h. The fmap_* functions for accessing or reading map data have two implementations, mem_* or handle_*, depending the data source. I found issues with some of these so I made a unit test that covers each of the functions I'm concerned about for both types of data sources and for both original fmaps and nested/duplicate fmaps. With the tests, I found and fixed issues in these fmap functions: - handle_need_offstr(): must account for the nested_offset in dupe maps. - handle_gets(): must account for nested_offset and use len & real_len correctly. - mem_need_offstr(): must account for nested_offset in dupe maps. - mem_gets(): must account for nested_offset and use len & real_len correctly. Moved CDBRANGE() macro out of function definition so for better legibility. Fixed a few warnings.		4 years ago
..
input	CMake: Fix race condition with parallel builds	4 years ago
CMakeLists.txt	CMake: support Xcode builds	4 years ago
Run-GetLibs.ctest	Test: fix check_clamd failure on Windows	4 years ago
check_bytecode.c	libclamav: Fix scan recursion tracking	4 years ago
check_clamav.c	Fix issues reading from uncompressed nested files	4 years ago
check_clamav_skip.c	bb12596: Fix build issue when libcheck missing	5 years ago
check_clamd.c	tests: Fix clamd tests when path has symlink	4 years ago
check_disasm.c	XOR test files; clean up tests directory	4 years ago
check_fpu_endian.c	Update copyright dates for 2021	4 years ago
check_htmlnorm.c	XOR test files; clean up tests directory	4 years ago
check_jsnorm.c	Update copyright dates for 2021	4 years ago
check_matchers.c	libclamav: Fix scan recursion tracking	4 years ago
check_regex.c	XOR test files; clean up tests directory	4 years ago
check_str.c	Update copyright dates for 2021	4 years ago
check_uniq.c	Update copyright dates for 2021	4 years ago
checks.h	CMake: Add CTest support to match Autotools checks	4 years ago
clamd_test.py	tests: Fix clamd tests when path has symlink	4 years ago
clamscan_test.py	Test: Verify that pdf bytecode hooks execute	4 years ago
freshclam_test.py	test: freshclam cdiff test tuning	4 years ago
libclamav_test.py	XOR test files; clean up tests directory	4 years ago
sigtool_test.py	XOR test files; clean up tests directory	4 years ago
testcase.py	clamav.net URL update for new docs, github issues	4 years ago
valgrind.supp	Tests: tune valgrind suppression rule	4 years ago