From 0b6ff1706fec8da2a5d02a20b9e13c3882cedd05 Mon Sep 17 00:00:00 2001
From: Michael Letzgus <www@chronos.michael-letzgus.de>
Date: Sun, 19 Mar 2017 12:23:20 +0100
Subject: [PATCH] Fix duplicate id "apps-management"

Make duplicate id "apps-management" a class since IDs must be unique:

https://www.w3.org/TR/2011/WD-html5-20110525/elements.html#the-id-attribute
https://api.jquery.com/id-selector/

Signed-off-by: Michael Letzgus <michaelletzgus@users.noreply.github.com>
---
 core/templates/layout.user.php | 4 ++--
 settings/js/apps.js            | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/core/templates/layout.user.php b/core/templates/layout.user.php
index 3cfb88bf423..dad5ee1b826 100644
--- a/core/templates/layout.user.php
+++ b/core/templates/layout.user.php
@@ -81,7 +81,7 @@
 								</a>
 							</li>
 							<?php if(OC_User::isAdminUser(OC_User::getUser())):	?>
-								<li id="apps-management" <?php if(count($_['navigation'])>$headerIconCount-1): ?>class="hidden"<?php endif; ?>>
+								<li <?php if(count($_['navigation'])>$headerIconCount-1): ?> class="hidden apps-management"<?php else: ?> class="apps-management"  <?php endif; ?>>
 									<a href="<?php print_unescaped(\OC::$server->getURLGenerator()->linkToRoute('settings.AppSettings.viewApps')); ?>" tabindex="4"
 										<?php if( $_['appsmanagement_active'] ): ?> class="active"<?php endif; ?>>
 										<img src="<?php print_unescaped(image_path('settings', 'apps.svg') . '?v=' . $_['versionHash']); ?>" />
@@ -119,7 +119,7 @@
 								/* show "More apps" link to app administration directly in app navigation, as last entry */
 								if(OC_User::isAdminUser(OC_User::getUser())):
 									?>
-									<li id="apps-management">
+									<li class="apps-management">
 										<a href="<?php print_unescaped(\OC::$server->getURLGenerator()->linkToRoute('settings.AppSettings.viewApps')); ?>" tabindex="4"
 											<?php if( $_['appsmanagement_active'] ): ?> class="active"<?php endif; ?>>
 											<svg width="32" height="32" viewBox="0 0 32 32" class="app-icon">
diff --git a/settings/js/apps.js b/settings/js/apps.js
index 8be18c4e9c0..d2f26578a7c 100644
--- a/settings/js/apps.js
+++ b/settings/js/apps.js
@@ -541,10 +541,10 @@ OC.Settings.Apps = OC.Settings.Apps || {
 
 				if (navEntries.length > 7) {
 					$('#more-apps').show();
-					$('#apps-management').hide();
+					$('.apps-management').hide();
 				} else {
 					$('#more-apps').hide();
-					$('#apps-management').show();
+					$('.apps-management').show();
 				}
 			}
 		});