Add return type hint to credential store and make it strict

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
pull/18108/head
Christoph Wurst 7 years ago
parent 279c0cb2ed
commit 128a460d7b
No known key found for this signature in database
GPG Key ID: CC42AC2A7F0E56D8
  1. 7
      lib/private/Authentication/LoginCredentials/Store.php
  2. 9
      lib/public/Authentication/LoginCredentials/IStore.php

@ -1,4 +1,5 @@
<?php
<?php declare(strict_types=1);
/**
* @copyright 2016 Christoph Wurst <christoph@winzerhof-wurst.at>
*
@ -82,8 +83,8 @@ class Store implements IStore {
* @return ICredentials the login credentials of the current user
* @throws CredentialsUnavailableException
*/
public function getLoginCredentials() {
if (is_null($this->tokenProvider)) {
public function getLoginCredentials(): ICredentials {
if ($this->tokenProvider === null) {
throw new CredentialsUnavailableException();
}

@ -1,4 +1,5 @@
<?php
<?php declare(strict_types=1);
/**
* @copyright 2016 Christoph Wurst <christoph@winzerhof-wurst.at>
*
@ -29,7 +30,7 @@ use OCP\Authentication\Exceptions\CredentialsUnavailableException;
* @since 12
*/
interface IStore {
/**
* Get login credentials of the currently logged in user
*
@ -38,6 +39,6 @@ interface IStore {
* @throws CredentialsUnavailableException
* @return ICredentials the login credentials of the current user
*/
public function getLoginCredentials();
public function getLoginCredentials(): ICredentials;
}

Loading…
Cancel
Save