From 1ee4b680f63246c8ae5f3e647ba812ffe6ab57b3 Mon Sep 17 00:00:00 2001 From: Vincent Petry Date: Fri, 25 Oct 2013 16:23:29 +0200 Subject: [PATCH] Fixed user dir existence check when creating new user The check was done too later. It turns out that createUser() had already created the dir, which caused the warning message to be shown every time. --- settings/ajax/createuser.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/settings/ajax/createuser.php b/settings/ajax/createuser.php index 915fcaf2d42..94b56fa0349 100644 --- a/settings/ajax/createuser.php +++ b/settings/ajax/createuser.php @@ -28,6 +28,10 @@ $password = $_POST["password"]; // Return Success story try { + // check whether the user's files home exists + $userDirectory = OC_User::getHome($username) . '/files/'; + $homeExists = file_exists($userDirectory); + if (!OC_User::createUser($username, $password)) { OC_JSON::error(array('data' => array( 'message' => 'User creation failed for '.$username ))); exit(); @@ -39,10 +43,6 @@ try { OC_Group::addToGroup( $username, $i ); } - // check whether the user's files home exists - $userDirectory = OC_User::getHome($username) . '/files/'; - $homeExists = file_exists($userDirectory); - OC_JSON::success(array("data" => array( // returns whether the home already existed