From 297f12e7a10b20594d34b5bbfe862c050b53276b Mon Sep 17 00:00:00 2001 From: Joas Schilling Date: Wed, 9 Feb 2022 10:49:32 +0100 Subject: [PATCH] Don't provide favorite activity settings Since mails and notifications are only available for actions of other users it does not make sense to allow changing this. It also prevents the common misunderstanding with "file was changed inside a favorited folder" Signed-off-by: Joas Schilling --- apps/files/lib/Activity/Settings/FavoriteAction.php | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/apps/files/lib/Activity/Settings/FavoriteAction.php b/apps/files/lib/Activity/Settings/FavoriteAction.php index 8201a09d4db..735f9c75937 100644 --- a/apps/files/lib/Activity/Settings/FavoriteAction.php +++ b/apps/files/lib/Activity/Settings/FavoriteAction.php @@ -56,7 +56,7 @@ class FavoriteAction extends FileActivitySettings { * @since 11.0.0 */ public function canChangeStream() { - return true; + return false; } /** @@ -72,7 +72,7 @@ class FavoriteAction extends FileActivitySettings { * @since 11.0.0 */ public function canChangeMail() { - return true; + return false; } /** @@ -82,4 +82,12 @@ class FavoriteAction extends FileActivitySettings { public function isDefaultEnabledMail() { return false; } + + /** + * @return bool True when the option can be changed for the notification + * @since 20.0.0 + */ + public function canChangeNotification() { + return false; + } }