Check number of elements instead of if the jQuery object is defined

Tje jQuery object created through "$('#testArea .toastify')" will be
always defined even if no elements were found, so the check does not
really work; instead, it should be checked the number of elements found.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
pull/16573/head
Daniel Calviño Sánchez 6 years ago
parent 323f40a493
commit 2b1c80ea3f
  1. 8
      core/js/tests/specs/coreSpec.js

@ -935,7 +935,7 @@ describe('Core base tests', function() {
//expect(showSpy.firstCall.args[1]).toEqual({isHTML: false, timeout: 7});
var $row = $('#testArea .toastify');
expect($row).toBeDefined();
expect($row.length).toEqual(1);
expect(getNotificationText($row)).toEqual('My notification test');
});
it('shows a HTML notification with default timeout', function() {
@ -946,14 +946,14 @@ describe('Core base tests', function() {
expect(showSpy.firstCall.args[1].isHTML).toEqual(true)
var $row = $('#testArea .toastify');
expect($row).toBeDefined();
expect($row.length).toEqual(1);
expect(getNotificationText($row)).toEqual('<a>My notification test</a>');
});
it('hides itself after 7 seconds', function() {
OC.Notification.showTemporary('');
var $row = $('#testArea .toastify');
expect($row).toBeDefined();
expect($row.length).toEqual(1);
// travel in time +7000 milliseconds
clock.tick(7500);
@ -967,7 +967,7 @@ describe('Core base tests', function() {
OC.Notification.showTemporary('', {timeout: 10});
var $row = $('#testArea .toastify');
expect($row).toBeDefined();
expect($row.length).toEqual(1);
clock.tick(11500);

Loading…
Cancel
Save