Implement review feedback

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
pull/28728/head
Lukas Reschke 5 years ago
parent 358eaba7dd
commit 474a5b55d3
  1. 4
      core/Migrations/Version23000Date20210906132259.php
  2. 6
      lib/private/Security/RateLimiting/Backend/DatabaseBackend.php

@ -34,8 +34,8 @@ class Version23000Date20210906132259 extends SimpleMigrationStep {
$table->addColumn('delete_after', Types::DATETIME, [
'notnull' => true,
]);
$table->addIndex(['hash'], 'ratelimit_hash_idx');
$table->addIndex(['delete_after'], 'ratelimit_delete_after_idx');
$table->addIndex(['hash'], 'ratelimit_hash');
$table->addIndex(['delete_after'], 'ratelimit_delete_after');
return $schema;
}

@ -74,7 +74,7 @@ class DatabaseBackend implements IBackend {
$qb->delete(self::TABLE_NAME)
->where(
$qb->expr()->lte('delete_after', $qb->createNamedParameter($currentTime, IQueryBuilder::PARAM_DATE))
);
)
->executeStatement();
$qb = $this->dbConnection->getQueryBuilder();
@ -88,10 +88,10 @@ class DatabaseBackend implements IBackend {
);
$cursor = $qb->executeQuery();
$row = $cursor->fetch();
$row = $cursor->fetchOne();
$cursor->closeCursor();
return (int)$row['count'];
return (int)$row;
}
/**

Loading…
Cancel
Save