From 1d9b4aadbf65794f34c70ece5d3faa784191acf1 Mon Sep 17 00:00:00 2001 From: Bjoern Schiessle Date: Tue, 10 Jun 2014 14:46:47 +0200 Subject: [PATCH 1/3] no need to prepare a statement twice --- apps/files_sharing/tests/api.php | 1 - 1 file changed, 1 deletion(-) diff --git a/apps/files_sharing/tests/api.php b/apps/files_sharing/tests/api.php index 3c683afacb4..72dd5816ea0 100644 --- a/apps/files_sharing/tests/api.php +++ b/apps/files_sharing/tests/api.php @@ -1166,7 +1166,6 @@ class Test_Files_Sharing_Api extends Test_Files_Sharing_Base { $query = \OCP\DB::prepare($statement); $result = $query->execute(array($shareCreated, \OCP\Share::SHARE_TYPE_LINK)); $this->assertSame(1, $result); - $statement = "UPDATE `*PREFIX*share` SET `stime` = ? WHERE `share_type` = ?"; $query = \OCP\DB::prepare($statement); $result = $query->execute(array($shareCreated, \OCP\Share::SHARE_TYPE_USER)); $this->assertSame(1, $result); From f4a183e753c1c7b5397c866cf6627f7512a86382 Mon Sep 17 00:00:00 2001 From: Bjoern Schiessle Date: Tue, 10 Jun 2014 14:47:32 +0200 Subject: [PATCH 2/3] wwe no longer have a versions table --- apps/files_versions/appinfo/app.php | 2 -- apps/files_versions/lib/hooks.php | 15 --------------- apps/files_versions/lib/versions.php | 11 ----------- 3 files changed, 28 deletions(-) diff --git a/apps/files_versions/appinfo/app.php b/apps/files_versions/appinfo/app.php index 8f2071dd7b6..371162cd16f 100644 --- a/apps/files_versions/appinfo/app.php +++ b/apps/files_versions/appinfo/app.php @@ -14,5 +14,3 @@ OCP\Util::connectHook('OC_Filesystem', 'write', "OCA\Files_Versions\Hooks", "wri OCP\Util::connectHook('OC_Filesystem', 'post_delete', "OCA\Files_Versions\Hooks", "remove_hook"); OCP\Util::connectHook('OC_Filesystem', 'delete', "OCA\Files_Versions\Hooks", "pre_remove_hook"); OCP\Util::connectHook('OC_Filesystem', 'rename', "OCA\Files_Versions\Hooks", "rename_hook"); -//Listen to delete user signal -OCP\Util::connectHook('OC_User', 'pre_deleteUser', "OCA\Files_Versions\Hooks", "deleteUser_hook"); diff --git a/apps/files_versions/lib/hooks.php b/apps/files_versions/lib/hooks.php index 2de4001affd..990f1403e8d 100644 --- a/apps/files_versions/lib/hooks.php +++ b/apps/files_versions/lib/hooks.php @@ -74,19 +74,4 @@ class Hooks { } } - /** - * clean up user specific settings if user gets deleted - * @param array $params array with uid - * - * This function is connected to the pre_deleteUser signal of OC_Users - * to remove the used space for versions stored in the database - */ - public static function deleteUser_hook($params) { - - if (\OCP\App::isEnabled('files_versions')) { - $uid = $params['uid']; - Storage::deleteUser($uid); - } - } - } diff --git a/apps/files_versions/lib/versions.php b/apps/files_versions/lib/versions.php index 15d0e032ea0..b912fc8ba76 100644 --- a/apps/files_versions/lib/versions.php +++ b/apps/files_versions/lib/versions.php @@ -301,17 +301,6 @@ class Storage { } - /** - * deletes used space for files versions in db if user was deleted - * - * @param string $uid id of deleted user - * @return \OC_DB_StatementWrapper of db delete operation - */ - public static function deleteUser($uid) { - $query = \OC_DB::prepare('DELETE FROM `*PREFIX*files_versions` WHERE `user`=?'); - return $query->execute(array($uid)); - } - /** * returns all stored file versions from a given user * @param string $uid id of the user From 9dc0befcca3e95095a217f3cecaf1d187f5d303b Mon Sep 17 00:00:00 2001 From: Bjoern Schiessle Date: Tue, 10 Jun 2014 14:48:19 +0200 Subject: [PATCH 3/3] call self::getNumericStorageId() to get the numeric ID --- lib/private/files/cache/storage.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/private/files/cache/storage.php b/lib/private/files/cache/storage.php index 3a267874431..9ad31a272ea 100644 --- a/lib/private/files/cache/storage.php +++ b/lib/private/files/cache/storage.php @@ -101,7 +101,7 @@ class Storage { $sql = 'DELETE FROM `*PREFIX*storages` WHERE `id` = ?'; \OC_DB::executeAudited($sql, array($storageId)); - $numericId = self::exists($storageId); + $numericId = self::getNumericStorageId($storageId); if (!is_null($numericId)) { $sql = 'DELETE FROM `*PREFIX*filecache` WHERE `storage` = ?'; \OC_DB::executeAudited($sql, array($numericId));