Fix unit tests

Signed-off-by: Joas Schilling <coding@schilljs.com>
pull/32741/head
Joas Schilling 4 years ago
parent a33310f1b1
commit 50c697dbd4
No known key found for this signature in database
GPG Key ID: 7076EA9751AACDDA
  1. 4
      apps/files_sharing/lib/Controller/RemoteController.php
  2. 2
      apps/files_sharing/tests/ApiTest.php
  3. 10
      apps/files_sharing/tests/Controller/ShareAPIControllerTest.php

@ -86,7 +86,7 @@ class RemoteController extends OCSController {
$this->logger->error('Could not accept federated share with id: ' . $id,
['app' => 'files_sharing']);
throw new OCSNotFoundException('wrong share ID, share doesn\'t exist.');
throw new OCSNotFoundException('wrong share ID, share does not exist.');
}
/**
@ -106,7 +106,7 @@ class RemoteController extends OCSController {
// Make sure the user has no notification for something that does not exist anymore.
$this->externalManager->processNotification($id);
throw new OCSNotFoundException('wrong share ID, share doesn\'t exist.');
throw new OCSNotFoundException('wrong share ID, share does not exist.');
}
/**

@ -929,7 +929,7 @@ class ApiTest extends TestCase {
$ocs->getShare(0);
$this->fail();
} catch (OCSNotFoundException $e) {
$this->assertEquals('Wrong share ID, share doesn\'t exist', $e->getMessage());
$this->assertEquals('Wrong share ID, share does not exist', $e->getMessage());
}
$ocs->cleanup();
}

@ -196,7 +196,7 @@ class ShareAPIControllerTest extends TestCase {
public function testDeleteShareShareNotFound() {
$this->expectException(\OCP\AppFramework\OCS\OCSNotFoundException::class);
$this->expectExceptionMessage('Wrong share ID, share doesn\'t exist');
$this->expectExceptionMessage('Wrong share ID, share does not exist');
$this->shareManager
->expects($this->exactly(6))
@ -433,7 +433,7 @@ class ShareAPIControllerTest extends TestCase {
*/
public function testDeleteSharedWithGroupIDontBelongTo() {
$this->expectException(\OCP\AppFramework\OCS\OCSNotFoundException::class);
$this->expectExceptionMessage('Wrong share ID, share doesn\'t exist');
$this->expectExceptionMessage('Wrong share ID, share does not exist');
$node = $this->getMockBuilder(File::class)->getMock();
@ -498,7 +498,7 @@ class ShareAPIControllerTest extends TestCase {
->with('ocinternal:42', 'currentUser')
->will($this->throwException(new \OC\Share20\Exception\ShareNotFound()));
$expected = new \OC\OCS\Result(null, 404, 'wrong share ID, share doesn\'t exist.');
$expected = new \OC\OCS\Result(null, 404, 'wrong share ID, share does not exist.');
$this->assertEquals($expected, $this->ocs->getShare(42));
}
*/
@ -808,7 +808,7 @@ class ShareAPIControllerTest extends TestCase {
public function testGetShareInvalidNode() {
$this->expectException(\OCP\AppFramework\OCS\OCSNotFoundException::class);
$this->expectExceptionMessage('Wrong share ID, share doesn\'t exist');
$this->expectExceptionMessage('Wrong share ID, share does not exist');
$share = \OC::$server->getShareManager()->newShare();
$share->setSharedBy('initiator')
@ -2602,7 +2602,7 @@ class ShareAPIControllerTest extends TestCase {
public function testUpdateShareCantAccess() {
$this->expectException(\OCP\AppFramework\OCS\OCSNotFoundException::class);
$this->expectExceptionMessage('Wrong share ID, share doesn\'t exist');
$this->expectExceptionMessage('Wrong share ID, share does not exist');
$node = $this->getMockBuilder(Folder::class)->getMock();
$share = $this->newShare();

Loading…
Cancel
Save