feat: Add reserved options in a new OCP class so that applications know about them

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

core/Listener/BeforeMessageLoggedEventListener.php

@@ -9,6 +9,7 @@ declare(strict_types=1);
 
 namespace OC\Core\Listener;
 
+use OCP\Console\ReservedOptions;
 use OCP\EventDispatcher\Event;
 use OCP\EventDispatcher\IEventDispatcher;
 use OCP\EventDispatcher\IEventListener;
@@ -54,10 +55,10 @@ class BeforeMessageLoggedEventListener implements IEventListener {
 		$argv = $_SERVER['argv'];
 		$level = 0;
 		foreach ($argv as $key => $arg) {
-			if ($arg === '--debug-log') {
+			if ($arg === '--'.ReservedOptions::DEBUG_LOG) {
 				unset($argv[$key]);
-			} elseif (str_starts_with($arg, '--debug-log-level=')) {
-				$level = (int)substr($arg, strlen('--debug-log-level='));
+			} elseif (str_starts_with($arg, '--'.ReservedOptions::DEBUG_LOG_LEVEL.'=')) {
+				$level = (int)substr($arg, strlen('--'.ReservedOptions::DEBUG_LOG_LEVEL.'='));
 				unset($argv[$key]);
 			}
 		}

lib/composer/composer/autoload_classmap.php

@@ -220,6 +220,7 @@ return array(
     'OCP\\Config\\BeforePreferenceDeletedEvent' => $baseDir . '/lib/public/Config/BeforePreferenceDeletedEvent.php',
     'OCP\\Config\\BeforePreferenceSetEvent' => $baseDir . '/lib/public/Config/BeforePreferenceSetEvent.php',
     'OCP\\Console\\ConsoleEvent' => $baseDir . '/lib/public/Console/ConsoleEvent.php',
+    'OCP\\Console\\ReservedOptions' => $baseDir . '/lib/public/Console/ReservedOptions.php',
     'OCP\\Constants' => $baseDir . '/lib/public/Constants.php',
     'OCP\\Contacts\\ContactsMenu\\IAction' => $baseDir . '/lib/public/Contacts/ContactsMenu/IAction.php',
     'OCP\\Contacts\\ContactsMenu\\IActionFactory' => $baseDir . '/lib/public/Contacts/ContactsMenu/IActionFactory.php',

lib/composer/composer/autoload_static.php

@@ -253,6 +253,7 @@ class ComposerStaticInit749170dad3f5e7f9ca158f5a9f04f6a2
         'OCP\\Config\\BeforePreferenceDeletedEvent' => __DIR__ . '/../../..' . '/lib/public/Config/BeforePreferenceDeletedEvent.php',
         'OCP\\Config\\BeforePreferenceSetEvent' => __DIR__ . '/../../..' . '/lib/public/Config/BeforePreferenceSetEvent.php',
         'OCP\\Console\\ConsoleEvent' => __DIR__ . '/../../..' . '/lib/public/Console/ConsoleEvent.php',
+        'OCP\\Console\\ReservedOptions' => __DIR__ . '/../../..' . '/lib/public/Console/ReservedOptions.php',
         'OCP\\Constants' => __DIR__ . '/../../..' . '/lib/public/Constants.php',
         'OCP\\Contacts\\ContactsMenu\\IAction' => __DIR__ . '/../../..' . '/lib/public/Contacts/ContactsMenu/IAction.php',
         'OCP\\Contacts\\ContactsMenu\\IActionFactory' => __DIR__ . '/../../..' . '/lib/public/Contacts/ContactsMenu/IActionFactory.php',

lib/public/Console/ReservedOptions.php

@@ -0,0 +1,24 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+namespace OCP\Console;
+
+/**
+ * @since 30.0.0
+ */
+final class ReservedOptions {
+	/**
+	 * @since 30.0.0
+	 */
+	public const DEBUG_LOG = 'debug-log';
+	/**
+	 * @since 30.0.0
+	 */
+	public const DEBUG_LOG_LEVEL = 'debug-log-level';
+}