PHP 8+ deprecates openssl_free_key

5 years ago · 63fa7d9354
parent c12be83a0b
commit 63fa7d9354
1 changed files with 4 additions and 1 deletions
--- a/lib/private/Installer.php
+++ b/lib/private/Installer.php
@ -309,7 +309,10 @@ class Installer {
 				// Check if the signature actually matches the downloaded content
 				$certificate = openssl_get_publickey($app['certificate']);
 				$verified = (bool)openssl_verify(file_get_contents($tempFile), base64_decode($app['releases'][0]['signature']), $certificate, OPENSSL_ALGO_SHA512);
-				openssl_free_key($certificate);
+				// PHP 8+ deprecates openssl_free_key and automatically destroys the key instance when it goes out of scope
+				if ((PHP_VERSION_ID < 80000)) {
+					openssl_free_key($certificate);
+				}

 				if ($verified === true) {
 					// Seems to match, let's proceed