use native functions of php to parse the string into the Var

remotes/origin/stable4
Georg Ehrke 13 years ago
parent 9226cb7a6a
commit 6d92ebca45
  1. 2
      core/js/js.js
  2. 13
      lib/base.php
  3. 2
      lib/helper.php

@ -53,7 +53,7 @@ OC={
var isCore=OC.coreApps.indexOf(app)!=-1;
var link=OC.webroot;
if(file.substring(file.length-3) == 'php' && !isCore){
link+='/?app=' + app + '&getfile=' + type + '/' + file;
link+='/?app=' + app + '&getfile=' + encodeURI(type + '/' + file);
}else{
link+='/';
app+='/';

@ -284,7 +284,7 @@ class OC{
if(file_exists(OC::$APPSROOT . '/apps/' . OC::$REQUESTEDAPP . '/' . OC::$REQUESTEDFILE)){
require_once(OC::$APPSROOT . '/apps/' . OC::$REQUESTEDAPP . '/' . OC::$REQUESTEDFILE);
}else{
header('404 Not found');
echo "WTF";
}
}
@ -401,12 +401,11 @@ class OC{
self::$REQUESTEDAPP = (isset($_GET['app'])?strip_tags($_GET['app']):'files');
self::$REQUESTEDFILE = $_GET['getfile'];
if(substr_count(self::$REQUESTEDFILE, '?') != 0){
$pos_questionmark = strpos(self::$REQUESTEDFILE, '?');
$pos_equal = strpos(self::$REQUESTEDFILE, '=');
$pos_and = strpos(self::$REQUESTEDFILE, '?');
$_GET[substr(self::$REQUESTEDFILE, $pos_questionmark + 1, $pos_equal - $pos_questionmark - 1)] = substr(self::$REQUESTEDFILE, $pos_equal + 1, $pos_and);
self::$REQUESTEDFILE = substr(self::$REQUESTEDFILE, 0, $pos_questionmark);
$_GET['getfile'] = OC::$REQUESTEDFILE;
$file = substr(self::$REQUESTEDFILE, 0, strpos(self::$REQUESTEDFILE, '?'));
$param = substr(self::$REQUESTEDFILE, strpos(self::$REQUESTEDFILE, '?') + 1);
parse_str($param, $_GET);
self::$REQUESTEDFILE = $file;
$_GET['getfile'] = $file;
}
self::$REQUESTEDFILE = (isset($_GET['getfile'])?(OC_Helper::issubdirectory(OC::$APPSROOT . '/' . self::$REQUESTEDAPP . '/' . self::$REQUESTEDFILE, OC::$APPSROOT . '/' . self::$REQUESTEDAPP)?self::$REQUESTEDFILE:null):null);
}

@ -45,7 +45,7 @@ class OC_Helper {
$app = substr($app, 0, strlen($app) - 1);
}
$urlLinkTo = OC::$APPSWEBROOT . '/?app=' . $app;
$urlLinkTo .= ($file!='index.php')?'&getfile=' . $file:'';
$urlLinkTo .= ($file!='index.php')?'&getfile=' . urlencode($file):'';
}
else{
$urlLinkTo = OC::$WEBROOT . '/' . $app . $file;

Loading…
Cancel
Save