Merge pull request #923 from owncloud/hooks_try_catch

wrap hooks into a try, catch to prevent a faulty app from crashing the request
13 years ago · 811b571cb3
parent 0c87f666ad 4301cd7f61
commit 811b571cb3
1 changed files with 5 additions and 1 deletions
--- a/lib/hook.php
+++ b/lib/hook.php
@ -59,7 +59,11 @@ class OC_Hook{

 		// Call all slots
 		foreach( self::$registered[$signalclass][$signalname] as $i ) {
-			call_user_func( array( $i["class"], $i["name"] ), $params );
+			try {
+				call_user_func( array( $i["class"], $i["name"] ), $params );
+			} catch (Exception $e){
+				OC_Log::write('hook', 'error while running hook (' . $i["class"] . '::' . $i["name"] . '): '.$e->getMessage(), OC_Log::ERROR);
+			}
 		}

 		// return true